Page MenuHomePhabricator

PostgresInstaller::canCreateAccounts() gives the wrong result
Closed, ResolvedPublic


This was reported on IRC. PostgresInstaller::canCreateAccounts() uses the obsolete pg_user catalog, instead of the new pg_roles. It gets the data from pg_user with a very strange looking query, and then interprets the result with a strange and buggy if statement, the end result being equivalent to a check of usesuper alone.

The reporter on IRC apparently had a user with rolcreaterole=true and rolcreatedb=true but rolsuper=false. The installer declared that this user could not create accounts.

Version: 1.17.x
Severity: normal



Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:36 PM
bzimport set Reference to bz28845.
bzimport added a subscriber: Unknown Object (MLST).

It didn't really work after r88929. It should be fixed properly in r89821.

Jdforrester-WMF subscribed.

Migrating from the old tracking task to a tag for PostgreSQL-related tasks.