Page MenuHomePhabricator

Post - edit highlight on Talk Pages does not cover entire topic container
Closed, ResolvedPublic

Description

Issue: On Talk Pages, after a contributor makes an edit, the post-edit highlight does not cover the entire topic container.

Screen_Shot_2022-05-13_at_9.47.41_AM.png (362×1 px, 257 KB)

Possible Solution: Include the "subscribe" link as apart of the topic container.

Event Timeline

matmarex moved this task from Incoming to Doing on the Editing-team (Kanban Board) board.
matmarex added a subscriber: matmarex.

Even worse when your comment is very short:
image.png (1×3 px, 161 KB)
The topic containers UI isn't considered at all when drawing the highlight, it is drawn exactly around the text of the heading and comment.

There is a similar issue when following links from notifications: because the highlight is drawn exactly around the text of the comments, the right edge is unpleasantly jaggy (example):
image.png (1×2 px, 541 KB) image.png (1×2 px, 560 KB)
(Personally, I like the jagginess of the left edge – it feels natural because it matches the comment indentation.)

I'd like to fix both of these problems by making the right edge of the highlights aligned with the edge of the page.

@matmarex +1 good catch.

feed two birds with one seed :)

Change 805499 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Tweak positioning of highlights to make them prettier

https://gerrit.wikimedia.org/r/805499

Change 805499 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Tweak positioning of highlights to make them prettier

https://gerrit.wikimedia.org/r/805499

The edit highlight covers the topic container as expected. See:

Screenshot 2022-06-30 at 03.59.25.png (662×3 px, 328 KB)

Screenshot 2022-06-30 at 04.01.18.png (596×1 px, 176 KB)

Screenshot 2022-06-30 at 04.04.45.png (1×3 px, 661 KB)

Screenshot 2022-06-30 at 03.58.15.png (294×1 px, 43 KB)