Page MenuHomePhabricator
Create Task
Maniphest T309749

[wmf.14 - minor] hewiki - "Get a mentor" uses RTL variant for oo-ui-icon-mentor icon
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
• mewoph
Authored By
Etonkovidova
Jun 2 2022, 12:13 AM
Tags
Referenced Files
F35223567: Screen Shot 2022-06-09 at 3.38.33 PM.png
Jun 9 2022, 10:40 PM
F35201138: Screen Shot 2022-06-02 at 1.50.25 PM.png
Jun 2 2022, 8:58 PM
F35201140: Screen Shot 2022-06-02 at 1.50.58 PM.png
Jun 2 2022, 8:58 PM
F35197981: Screen Shot 2022-06-01 at 5.03.42 PM.png
Jun 2 2022, 12:13 AM
Subscribers
Aklapper
Etonkovidova
kostajh
• mewoph
Sgs
Tgr
Urbanecm_WMF

Description

List of steps to reproduce (step by step, including full links if applicable):

  • On hewiki wmf.14 Special:Homepage opt-out from being mentored.
  • The module "Mentor for editing" will display the RTL icon variant:

Screen Shot 2022-06-01 at 5.03.42 PM.png (906×1 px, 75 KB)

Details

SubjectRepoBranchLines +/-
Mentorship: Use LTR icon for Hebrew in mentorship-optin modulemediawiki/extensions/GrowthExperimentsmaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jun 2 2022, 12:13 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 2 2022, 12:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova mentioned this in T303224: [wmf.24] hewiki - RTL oo-ui-icon-mentor icon is used for Mentorship module.Jun 2 2022, 12:14 AM
Urbanecm_WMF added a project: Regression.Jun 2 2022, 6:43 AM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jun 2 2022, 7:37 AM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
Aklapper added a project: I18n.Jun 2 2022, 8:37 AM
kostajh triaged this task as Medium priority.Jun 2 2022, 12:02 PM
• mewoph claimed this task.Jun 2 2022, 4:57 PM
• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Jun 2 2022, 8:57 PM

Change 802634 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Mentorship: Use LTR icon for Hebrew in mentorship-optin module

https://gerrit.wikimedia.org/r/802634

gerritbot added a project: Patch-For-Review.Jun 2 2022, 8:57 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 2 2022, 8:58 PM

With fix:

hear
Screen Shot 2022-06-02 at 1.50.25 PM.png (354×986 px, 32 KB)
Screen Shot 2022-06-02 at 1.50.58 PM.png (298×994 px, 34 KB)
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 2 2022, 9:36 PM
gerritbot added a comment.Jun 2 2022, 10:01 PM

Change 802634 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentorship: Use LTR icon for Hebrew in mentorship-optin module

https://gerrit.wikimedia.org/r/802634

Maintenance_bot removed a project: Patch-For-Review.Jun 2 2022, 10:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 2 2022, 11:00 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 3 2022, 11:45 PM
Etonkovidova closed this task as Resolved.Jun 9 2022, 10:40 PM

Checked in wmf.15- the issue is Resolved.

Screen Shot 2022-06-09 at 3.38.33 PM.png (976×916 px, 88 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL