Page MenuHomePhabricator
Create Task
Maniphest T310214

Wikimedia\Rdbms\DBQueryError: Error 1146: Table 'enwikinews.`categorylinks`' doesn't exist
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   Wikimedia\Rdbms\DBQueryError: Error 1146: Table 'enwikinews.`categorylinks`' doesn't exist
Function: MediaWiki\Extension\GoogleNewsSitemap\Specials\GoogleNewsSitemap::getCategories
Query: SELECT  page_namespace,page_title,page_
exception.trace
from /srv/mediawiki/php-1.39.0-wmf.15/includes/libs/rdbms/database/Database.php(1767)
#0 /srv/mediawiki/php-1.39.0-wmf.15/includes/libs/rdbms/database/Database.php(1751): Wikimedia\Rdbms\Database->getQueryException(string, integer, string, string)
#1 /srv/mediawiki/php-1.39.0-wmf.15/includes/libs/rdbms/database/Database.php(1725): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#2 /srv/mediawiki/php-1.39.0-wmf.15/includes/libs/rdbms/database/Database.php(1226): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#3 /srv/mediawiki/php-1.39.0-wmf.15/includes/libs/rdbms/database/Database.php(1857): Wikimedia\Rdbms\Database->query(string, string, integer)
#4 /srv/mediawiki/php-1.39.0-wmf.15/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
#5 /srv/mediawiki/php-1.39.0-wmf.15/includes/libs/rdbms/database/DBConnRef.php(277): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#6 /srv/mediawiki/php-1.39.0-wmf.15/extensions/GoogleNewsSitemap/includes/Specials/GoogleNewsSitemap.php(409): Wikimedia\Rdbms\DBConnRef->select(array, array, array, string, array, array)
#7 /srv/mediawiki/php-1.39.0-wmf.15/extensions/GoogleNewsSitemap/includes/Specials/GoogleNewsSitemap.php(145): MediaWiki\Extension\GoogleNewsSitemap\Specials\GoogleNewsSitemap->getCategories(array, array, array)
#8 /srv/mediawiki/php-1.39.0-wmf.15/includes/specialpage/SpecialPage.php(688): MediaWiki\Extension\GoogleNewsSitemap\Specials\GoogleNewsSitemap->execute(NULL)
#9 /srv/mediawiki/php-1.39.0-wmf.15/includes/specialpage/SpecialPageFactory.php(1415): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-1.39.0-wmf.15/includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#11 /srv/mediawiki/php-1.39.0-wmf.15/includes/MediaWiki.php(916): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.39.0-wmf.15/includes/MediaWiki.php(570): MediaWiki->main()
#13 /srv/mediawiki/php-1.39.0-wmf.15/index.php(50): MediaWiki->run()
#14 /srv/mediawiki/php-1.39.0-wmf.15/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}
Impact

A number of these and related errors noticed during group1 promotion of 1.39.0-wmf.15.

Notes

Details

Request URL
https://en.wikinews.org/w/index.php?title=*&feed=*&categories=*&notcategories=*&namespace=*&count=*&ordermethod=*&stablepages=*
SubjectRepoBranchLines +/-
rdbms: move mysql isQuotedIdentifier() override to SQLPlatformmediawiki/corewmf/1.39.0-wmf.15+8 -8
rdbms: move mysql isQuotedIdentifier() override to SQLPlatformmediawiki/coremaster+8 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

dduvall created this task.Jun 8 2022, 6:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2022, 6:27 PM
dduvall triaged this task as Unbreak Now! priority.Jun 8 2022, 6:30 PM
dduvall added a parent task: T308068: 1.39.0-wmf.15 deployment blockers.
Zabe subscribed.Jun 8 2022, 6:36 PM
RhinosF1 subscribed.Jun 8 2022, 7:14 PM
dduvall renamed this task from PHP Deprecated: Caller from LinkBatch::doQuery (for Skin::preloadExistence) ignored an error originally raised from MediaWiki\Extension\GoogleNewsSitemap\Specials\GoogleNewsSitemap::getCategories: [1146] Table 'nlwikinews.`cate to Wikimedia\Rdbms\DBQueryError: Error 1146: Table 'enwikinews.`categorylinks`' doesn't exist.Jun 8 2022, 7:14 PM
dduvall changed Request URL from https://nl.wikinews.org/wiki/Speciaal:Nieuwsfeed?categories=*&feed=* to https://en.wikinews.org/w/index.php?title=*&feed=*&categories=*&notcategories=*&namespace=*&count=*&ordermethod=*&stablepages=*.
dduvall updated the task description. (Show Details)

Edited to reflect original (and likely more relevant) error instead of the re-raised one.

RhinosF1 added a subscriber: Ladsgroup.EditedJun 8 2022, 7:16 PM

Links will likely be @Ladsgroup I think although T299951: Normalize categorylinks table doesn't show any changes.

Krinkle added projects: MediaWiki-extensions-GoogleNewsSitemap, MediaWiki-libs-Rdbms.EditedJun 8 2022, 7:24 PM
Krinkle subscribed.

I do not believe this is related to T299951. The categorylinks table exists just fine. If it didn't, there'd be a lot more errors.

This error is specific and limited to queries from the GoogleNewsSitemap extension. Tagging as such.

From a quick glance, I suspect the problem is in the SQL syntax:

Table 'enwikinews.`categorylinks`'

This is mixing single quotes and backticks at the same time. I'm not 100% sure, but that seems like invalid to me and thus seen as a literal name which doesn't exist.

The GoogleNewsSitemap extension has not substantially changed since April.

Looking at the Logstash dashboard for "mediawiki-errors" and querying for message:"GoogleNewsSitemap::getCategories" in the past 90 days shows that this is a new error, introduced today with the wmf15 promotion to group1 wikis.

Reviewing https://www.mediawiki.org/wiki/MediaWiki_1.39/wmf.15 shows that the only significant changes for this extension and/or core Rdbms are:

MediaWiki core:

  • git #dd9b44b1 - rdbms: Move selectSQLText to SQLPlatform (task T307616) by Amir Sarabadani
  • git #496332e4 - rdbms: avoid DBReadOnlyRoleError in Database::doFlushSession() (task T306632) by Aaron Schulz

No changes:

  • GoogleNewsSitemap

As such, It seems most likely that the Rdbms refactor caused selectSQLText to mishave in the rather unusual way that GoogleNewsSitemap makes use of.

GoogleNewsSitemap.php
public function getCategories( $params, $categories, $notCategories ) {
	$categorylinks = $dbr->tableName( 'categorylinks' );
..
	$tables["c$currentTableNumber"] = $categorylinks;
..
	return $dbr->select( $tables, $fields, $conditions, __METHOD__, $options, $joins );
Restricted Application added a project: Performance-Team. · View Herald TranscriptJun 8 2022, 7:24 PM
dduvall added a comment.EditedJun 8 2022, 7:28 PM

Thanks for investigating, @Krinkle and @RhinosF1 !

Nikerabbit subscribed.Jun 8 2022, 8:01 PM
Krinkle mentioned this in T310141: Some SemanticMediaWiki queries fail due to duplicated table prefix.Jun 8 2022, 8:11 PM
Stashbot added a comment.Jun 8 2022, 8:33 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-08T20:33:08Z] <dduvall> rolling back group0 as well due to T310214

aaron subscribed.Jun 8 2022, 9:58 PM

Looks like SQLPlatform::isQuotedIdentifier() needs to be overridden for mysql. Database::selectSQLText() no longer uses DatabaseMysqlBase::isQuotedIdentifier() now that the work happens in SQLPlatform.

gerritbot added a comment.Jun 8 2022, 10:00 PM

Change 803994 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] rdbms: move mysql isQuotedIdentifier() override to SQLPlatform

https://gerrit.wikimedia.org/r/803994

gerritbot added a project: Patch-For-Review.Jun 8 2022, 10:00 PM
Krinkle mentioned this in T307616: Move SQL building code from Database class to SQLPlatform.Jun 8 2022, 10:07 PM
gerritbot added a comment.Jun 8 2022, 10:25 PM

Change 803909 had a related patch set uploaded (by Krinkle; author: Aaron Schulz):

[mediawiki/core@wmf/1.39.0-wmf.15] rdbms: move mysql isQuotedIdentifier() override to SQLPlatform

https://gerrit.wikimedia.org/r/803909

gerritbot added a comment.Jun 8 2022, 10:44 PM

Change 803994 merged by jenkins-bot:

[mediawiki/core@master] rdbms: move mysql isQuotedIdentifier() override to SQLPlatform

https://gerrit.wikimedia.org/r/803994

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 8 2022, 11:00 PM
Agusbou2015 subscribed.Jun 8 2022, 11:10 PM
gerritbot added a comment.Jun 9 2022, 12:25 AM

Change 803909 merged by jenkins-bot:

[mediawiki/core@wmf/1.39.0-wmf.15] rdbms: move mysql isQuotedIdentifier() override to SQLPlatform

https://gerrit.wikimedia.org/r/803909

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2022, 12:30 AM
Stashbot added a comment.Jun 9 2022, 12:49 AM

Mentioned in SAL (#wikimedia-operations) [2022-06-09T00:49:51Z] <krinkle@deploy1002> Synchronized php-1.39.0-wmf.15/includes/libs/rdbms/: I99b817b3d50ffcdf56, T310214 (duration: 03m 23s)

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.15; 2022-06-06); removed MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 9 2022, 1:00 AM
Nikerabbit merged a task: T310141: Some SemanticMediaWiki queries fail due to duplicated table prefix.Jun 9 2022, 5:45 AM
thcipriani moved this task from Untriaged to Jun 2022 on the Wikimedia-production-error board.Jun 9 2022, 4:08 PM
dduvall closed this task as Resolved.Jun 9 2022, 8:01 PM
dduvall claimed this task.

Thanks again for the quick turnaround.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL