Page MenuHomePhabricator
Create Task
Maniphest T310759

Fix interface messages for IP Info
Closed, ResolvedPublic
Actions

Description

@NguoiDungKhongDinhDanh has proposed some improvements to the IP Info interface messages:

MediaWiki:Ipinfo-widget-error-ip-no-edits

  • Currently: IP information for this address cannot be retrieved since it hasn't made any edits on this wiki.
  • Proposed: IP information for this address cannot be retrieved since no edits have been made from it.
  • Rationale: According to MediaWiki:Action-ipinfo et. al. IP addresses are considered attach[ments] to revisions and log entries, not identifiers by themselves. Also, per en:WP:IPHUMAN.

MediaWiki:Ipinfo-property-no-data:

  • Currently: Not Available
  • Proposed: Not available

MediaWiki:Ipinfo-property-label-connectiontype:

  • Currently: Connection Method
  • Proposed: Connection method

MediaWiki:Ipinfo-property-label-usertype:

  • Currently: Connection Owner
  • Proposed: Connection owner

MediaWiki:Ipinfo-property-label-active-blocks:

  • Currently: Active Blocks
  • Proposed: Active blocks
  • Rationale (for both 4): Bad casing.

MediaWiki:Ipinfo-infobox-disable-instructions:

  • Currently: If you'd like to disable this feature you can do so from [[Special:Preferences|Special:Preferences]].
  • Proposed: If you'd like to disable this feature you can do so from [[{{#special:Preferences}}]].

MediaWiki:Ipinfo-beta-feature-description:

  • Currently: [...] next to IP addresses on Log, Contributions and RecentChanges pages.
  • Proposed: [...] next to IP addresses on {{PAGENAME:{{#special:Log}}}}, {{PAGENAME:{{#special:Contributions}}}} and {{PAGENAME:{{#special:RecentChanges}}}} pages.
  • Rationale (for both): Interface messages are displayed in user language while that of special pages is site language.

Details

SubjectRepoBranchLines +/-
Avoid the #special magic word in messagesmediawiki/extensions/IPInfomaster+3 -3
Fixing interface messages in IP Infomediawiki/extensions/IPInfomaster+7 -7
Fixing interface messages in IP Infomediawiki/extensions/IPInfomaster+8 -4
Customize query in gerrit

Related Objects

Event Timeline

• Niharika triaged this task as Medium priority.Jun 15 2022, 11:17 PM
• Niharika created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2022, 11:17 PM
MarcoAurelio subscribed.Jun 16 2022, 9:24 AM

@Niharika I'd not mind uploading a patch for this Task if no one is assigned already to do this or requires discussion.

• Prtksxna moved this task from Design to Triage/To be Estimated on the Anti-Harassment board.Jun 17 2022, 4:36 AM
• Prtksxna subscribed.
gerritbot added a comment.Jun 17 2022, 12:35 PM

Change 806411 had a related patch set uploaded (by Diesel kapasule; author: Diesel kapasule):

[mediawiki/extensions/IPInfo@master] Fixing interface messages in IP Info

https://gerrit.wikimedia.org/r/806411

gerritbot added a project: Patch-For-Review.Jun 17 2022, 12:35 PM
Diesel_kapasule changed the task status from Open to In Progress.Jun 17 2022, 12:43 PM
Diesel_kapasule claimed this task.
Tchanders edited projects, added Anti-Harassment (AHaT Sprint 10: The Mokorotlo); removed Anti-Harassment.Jun 22 2022, 6:48 AM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.Jun 22 2022, 6:51 AM
gerritbot added a comment.Jun 23 2022, 11:36 AM

Change 807957 had a related patch set uploaded (by Diesel kapasule; author: Diesel kapasule):

[mediawiki/extensions/IPInfo@master] Fixing interface messages in IP Info

https://gerrit.wikimedia.org/r/807957

gerritbot added a comment.Jun 23 2022, 11:37 AM

Change 807957 abandoned by Diesel kapasule:

[mediawiki/extensions/IPInfo@master] Fixing interface messages in IP Info

Reason:

Patch is picking unrelated files

https://gerrit.wikimedia.org/r/807957

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.Jun 23 2022, 11:52 PM
gerritbot added a comment.Jun 23 2022, 11:53 PM

Change 806411 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Fixing interface messages in IP Info

https://gerrit.wikimedia.org/r/806411

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 24 2022, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 24 2022, 12:30 AM
dom_walden subscribed.Jun 24 2022, 6:26 AM

@Diesel_kapasule ipinfo-infobox-disable-instructions isn't displaying for me correctly on beta. It displays as: If you'd like to disable this feature you can do so from [[{{#special:Preferences}}]].

On Special:Contributions before you have checked ipinfo-use-agreement:

disable_instructions.png (284×1 px, 41 KB)

gerritbot added a comment.Jun 24 2022, 7:29 AM

Change 808128 had a related patch set uploaded (by Amire80; author: Amire80):

[mediawiki/extensions/IPInfo@master] Avoid the #special magic word in messages

https://gerrit.wikimedia.org/r/808128

gerritbot added a project: Patch-For-Review.Jun 24 2022, 7:29 AM
Amire80 subscribed.Jun 24 2022, 7:30 AM

MediaWiki:Ipinfo-infobox-disable-instructions:
Currently: If you'd like to disable this feature you can do so from [[Special:Preferences|Special:Preferences]].
Proposed: If you'd like to disable this feature you can do so from [[{{#special:Preferences}}]].

Neither is very good.

The most natural thing is to do this: If you'd like to disable this feature, you can do so in [[Special:Preferences|your preferences]].

Explanation:

  • The {{#special:Preferences}} magic word is rarely used.
  • The English link target Special:Preferences works in all languages, and it's the usual practice to use canonical English special page names in links of this kind.
  • Using freely translatable text after the pipe is a common practice. It makes the sentence natural and allows grammar adaptations.
  • Also, a couple of minor changes: a comma and a preposition.

Other usages of #special should be removed, too, for similar reasons.

I've submitted a patch to fix it all in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/808128 .

Diesel_kapasule added a comment.Jun 24 2022, 7:39 AM

@Amire80 thank you for the explanation.

dom_walden added a comment.Jun 24 2022, 8:33 AM

@Niharika How far do we want to go with these changes?

For the ipinfo-property-label-proxytypes should we change Real IP/Proxy to Real IP/proxy?

Similarly, all the ipinfo-property-value-proxytype-* messages are capitalised. For example, ipinfo-property-value-proxytype-istorexitnode is Tor Exit Node should be Tor exit node?

I also notice we use several different ways to refer to IPInfo: IPInfo, IP Info, ipinfo, IP information, IP Information.

Messages which use IPInfo:

  • group-no-ipinfo
  • group-no-ipinfo-member
  • grouppage-no-ipinfo
  • ipinfo-log-name
  • ipinfo-log-header
  • logentry-ipinfo-change_access

Messages which use IP Info:

  • ipinfo-extensionname
  • ipinfo-beta-feature-title
  • ipinfo-beta-feature-description

Messages which use ipinfo:

  • ipinfo-rest-revision-registered
  • ipinfo-rest-log-registered

Messages which use IP information:

  • ipinfo-widget-error-default
  • ipinfo-widget-error-ip-no-edits
  • prefs-ipinfo
  • action-ipinfo-view-*
  • right-ipinfo-view-*

Messages which use IP Information:

  • ipinfo-infobox-title
  • ipinfo-preference-enable
  • ipinfo-preference-agreement-error
  • ipinfo-infobox-use-terms
  • ipinfo-infobox-submit-agreement
  • logentry-ipinfo-view_infobox
  • logentry-ipinfo-view_popup
Tchanders moved this task from QA/Testing 🐞 to Needs Design/Product 🎨 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.Jun 24 2022, 3:42 PM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 11: The Fascinator); removed Anti-Harassment (AHaT Sprint 10: The Mokorotlo).Jun 28 2022, 5:20 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Needs Design/Product 🎨 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.
• Prtksxna mentioned this in T311683: IP Info: Fix capitalization in messages.Jun 30 2022, 4:09 AM
• Prtksxna added a comment.Jun 30 2022, 4:12 AM

Thanks for pointing this out @dom_walden. You're right things have gotten inconsistent with the capitalization and the naming of the product. I've created T311683: IP Info: Fix capitalization in messages to track this. If the initial scope of the task is complete, would it be okay to move this to the done column and do the other changes as part of the new task?

Amire80 added a comment.Jun 30 2022, 4:16 AM
In T310759#8024944, @Diesel_kapasule wrote:

@Amire80 thank you for the explanation.

You're welcome. Can anyone merge https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/808128 ? :)

dom_walden moved this task from Needs Design/Product 🎨 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.Jun 30 2022, 12:06 PM
In T310759#8038987, @Prtksxna wrote:

Thanks for pointing this out @dom_walden. You're right things have gotten inconsistent with the capitalization and the naming of the product. I've created T311683: IP Info: Fix capitalization in messages to track this. If the initial scope of the task is complete, would it be okay to move this to the done column and do the other changes as part of the new task?

I will move this into code review first as there is an outstanding patch.

Tchanders subscribed.Jul 1 2022, 2:00 PM
In T310759#8038990, @Amire80 wrote:
In T310759#8024944, @Diesel_kapasule wrote:

@Amire80 thank you for the explanation.

You're welcome. Can anyone merge https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/808128 ? :)

Done - thank you

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.Jul 1 2022, 2:00 PM
gerritbot added a comment.Jul 1 2022, 2:03 PM

Change 808128 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Avoid the #special magic word in messages

https://gerrit.wikimedia.org/r/808128

Maintenance_bot removed a project: Patch-For-Review.Jul 1 2022, 2:31 PM
Diesel_kapasule closed this task as Resolved.Jul 1 2022, 7:53 PM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.21; 2022-07-18); removed MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jul 11 2022, 11:01 PM
• Prtksxna moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 4:07 AM
• Prtksxna moved this task from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.Aug 8 2022, 4:14 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL