Page MenuHomePhabricator

Fix interface messages for IP Info
Closed, ResolvedPublic

Description

@NguoiDungKhongDinhDanh has proposed some improvements to the IP Info interface messages:

MediaWiki:Ipinfo-widget-error-ip-no-edits

  • Currently: IP information for this address cannot be retrieved since it hasn't made any edits on this wiki.
  • Proposed: IP information for this address cannot be retrieved since no edits have been made from it.
  • Rationale: According to MediaWiki:Action-ipinfo et. al. IP addresses are considered attach[ments] to revisions and log entries, not identifiers by themselves. Also, per en:WP:IPHUMAN.

MediaWiki:Ipinfo-property-no-data:

  • Currently: Not Available
  • Proposed: Not available

MediaWiki:Ipinfo-property-label-connectiontype:

  • Currently: Connection Method
  • Proposed: Connection method

MediaWiki:Ipinfo-property-label-usertype:

  • Currently: Connection Owner
  • Proposed: Connection owner

MediaWiki:Ipinfo-property-label-active-blocks:

  • Currently: Active Blocks
  • Proposed: Active blocks
  • Rationale (for both 4): Bad casing.

MediaWiki:Ipinfo-infobox-disable-instructions:

  • Currently: If you'd like to disable this feature you can do so from [[Special:Preferences|Special:Preferences]].
  • Proposed: If you'd like to disable this feature you can do so from [[{{#special:Preferences}}]].

MediaWiki:Ipinfo-beta-feature-description:

  • Currently: [...] next to IP addresses on Log, Contributions and RecentChanges pages.
  • Proposed: [...] next to IP addresses on {{PAGENAME:{{#special:Log}}}}, {{PAGENAME:{{#special:Contributions}}}} and {{PAGENAME:{{#special:RecentChanges}}}} pages.
  • Rationale (for both): Interface messages are displayed in user language while that of special pages is site language.

Event Timeline

Niharika triaged this task as Medium priority.Jun 15 2022, 11:17 PM
Niharika created this task.
Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptJun 15 2022, 11:17 PM

@Niharika I'd not mind uploading a patch for this Task if no one is assigned already to do this or requires discussion.

Change 806411 had a related patch set uploaded (by Diesel kapasule; author: Diesel kapasule):

[mediawiki/extensions/IPInfo@master] Fixing interface messages in IP Info

https://gerrit.wikimedia.org/r/806411

Diesel_kapasule changed the task status from Open to In Progress.Jun 17 2022, 12:43 PM
Diesel_kapasule claimed this task.

Change 807957 had a related patch set uploaded (by Diesel kapasule; author: Diesel kapasule):

[mediawiki/extensions/IPInfo@master] Fixing interface messages in IP Info

https://gerrit.wikimedia.org/r/807957

Change 807957 abandoned by Diesel kapasule:

[mediawiki/extensions/IPInfo@master] Fixing interface messages in IP Info

Reason:

Patch is picking unrelated files

https://gerrit.wikimedia.org/r/807957

Change 806411 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Fixing interface messages in IP Info

https://gerrit.wikimedia.org/r/806411

@Diesel_kapasule ipinfo-infobox-disable-instructions isn't displaying for me correctly on beta. It displays as: If you'd like to disable this feature you can do so from [[{{#special:Preferences}}]].

On Special:Contributions before you have checked ipinfo-use-agreement:

disable_instructions.png (284ร—1 px, 41 KB)

Change 808128 had a related patch set uploaded (by Amire80; author: Amire80):

[mediawiki/extensions/IPInfo@master] Avoid the #special magic word in messages

https://gerrit.wikimedia.org/r/808128

MediaWiki:Ipinfo-infobox-disable-instructions:
Currently: If you'd like to disable this feature you can do so from [[Special:Preferences|Special:Preferences]].
Proposed: If you'd like to disable this feature you can do so from [[{{#special:Preferences}}]].

Neither is very good.

The most natural thing is to do this: If you'd like to disable this feature, you can do so in [[Special:Preferences|your preferences]].

Explanation:

  • The {{#special:Preferences}} magic word is rarely used.
  • The English link target Special:Preferences works in all languages, and it's the usual practice to use canonical English special page names in links of this kind.
  • Using freely translatable text after the pipe is a common practice. It makes the sentence natural and allows grammar adaptations.
  • Also, a couple of minor changes: a comma and a preposition.

Other usages of #special should be removed, too, for similar reasons.

I've submitted a patch to fix it all in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/808128 .

@Niharika How far do we want to go with these changes?

For the ipinfo-property-label-proxytypes should we change Real IP/Proxy to Real IP/proxy?

Similarly, all the ipinfo-property-value-proxytype-* messages are capitalised. For example, ipinfo-property-value-proxytype-istorexitnode is Tor Exit Node should be Tor exit node?

I also notice we use several different ways to refer to IPInfo: IPInfo, IP Info, ipinfo, IP information, IP Information.

Messages which use IPInfo:

  • group-no-ipinfo
  • group-no-ipinfo-member
  • grouppage-no-ipinfo
  • ipinfo-log-name
  • ipinfo-log-header
  • logentry-ipinfo-change_access

Messages which use IP Info:

  • ipinfo-extensionname
  • ipinfo-beta-feature-title
  • ipinfo-beta-feature-description

Messages which use ipinfo:

  • ipinfo-rest-revision-registered
  • ipinfo-rest-log-registered

Messages which use IP information:

  • ipinfo-widget-error-default
  • ipinfo-widget-error-ip-no-edits
  • prefs-ipinfo
  • action-ipinfo-view-*
  • right-ipinfo-view-*

Messages which use IP Information:

  • ipinfo-infobox-title
  • ipinfo-preference-enable
  • ipinfo-preference-agreement-error
  • ipinfo-infobox-use-terms
  • ipinfo-infobox-submit-agreement
  • logentry-ipinfo-view_infobox
  • logentry-ipinfo-view_popup

Thanks for pointing this out @dom_walden. You're right things have gotten inconsistent with the capitalization and the naming of the product. I've created T311683: IP Info: Fix capitalization in messages to track this. If the initial scope of the task is complete, would it be okay to move this to the done column and do the other changes as part of the new task?

Thanks for pointing this out @dom_walden. You're right things have gotten inconsistent with the capitalization and the naming of the product. I've created T311683: IP Info: Fix capitalization in messages to track this. If the initial scope of the task is complete, would it be okay to move this to the done column and do the other changes as part of the new task?

I will move this into code review first as there is an outstanding patch.

Change 808128 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Avoid the #special magic word in messages

https://gerrit.wikimedia.org/r/808128