Page MenuHomePhabricator

[wmf.18 - regression] Add image article card displays thumbnail image
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce:

  • On arwiki wmf.18 (the issue was also found on bnwiki) go to Special:Homepage and select "Add a suggested image" task
  • Some article cards display a reduced image instead of the placeholder image
  • Click on one of such article cards
Screen Shot 2022-06-30 at 2.22.35 PM.png (1×1 px, 237 KB)
Screen Shot 2022-06-30 at 2.27.43 PM.png (1×1 px, 156 KB)

What happens?:
The image recommendation surface is not loading- "Back to suggested edits" message will be displayed (the Console dispalays: e.g. "No recommendation found for page: إكراه " for the page https://ar.wikipedia.org/w/index.php?title=إكراه&gesuggestededit=1&veaction=edit&action=edit

What should have happened instead?:

  • the placeholder image should be displayed for the article cards for "Add a suggested image" task
  • there should be no "Back to suggested edits" message displayed when a user lands on a image recommendation article

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

For the thumbnail image showing up, this occurs only when the article has a thumbnail and only for tasks in the preloaded task queue mw.config.get( 'homepagemodules' )[ 'suggested-edits' ]['task-queue'] since thumbnailSource is removed by GrowthTasksApi.fetchTasks but not when fetching extra data.

Another issue is that some of these articles with thumbnails have images in them so they should not be suggested as add image tasks.

Change 810124 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: set thumbnailSource to null when fetching extra data for image-recommendation task

https://gerrit.wikimedia.org/r/810124

Change 810301 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Adjust thumbnailSource logic

https://gerrit.wikimedia.org/r/810301

@kostajh - here are few examples of the fetched articles in suggested image feed:

arwiki

pageId: 343044  thumbnailSource: "https://upload.wikimedia.org/wikipedia/commons/thumb/8/85/CIAJMK1209-ar.svg/langar-332px-CIAJMK1209-ar.svg.png"

pageId: 717897  thumbnailSource: "https://upload.wikimedia.org/wikipedia/commons/thumb/d/df/Dharma_Wheel.svg/langar-332px-Dharma_Wheel.svg.png"

pageId: 2558221 thumbnailSource: "https://upload.wikimedia.org/wikipedia/commons/thumb/0/06/Honeymoon_Island_State_Park_-_panoramio_%281%29.jpg/332px-Honeymoon_Island_State_Park_-_panoramio_%281%29.jpg"

pageId: 343044 thumbnailSource: "https://upload.wikimedia.org/wikipedia/commons/thumb/8/85/CIAJMK1209-ar.svg/langar-332px-CIAJMK1209-ar.svg.png"

cswiki

pageId: 756735  thumbnailSource: "https://upload.wikimedia.org/wikipedia/commons/thumb/5/5f/Louis_XIV_of_France.jpg/332px-Louis_XIV_of_France.jpg"

Notes:

  • it seems that the articles with thumbnails are displayed only in the first 20 articles
  • the issue much more common on arwiki ~3-4 articles from 20
  • reloading Homepage brings new examples of articles with thumbnails

Change 810124 abandoned by MewOphaswongse:

[mediawiki/extensions/GrowthExperiments@master] Add an image: set thumbnailSource to null when fetching extra data for image-recommendation task

Reason:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/810301

https://gerrit.wikimedia.org/r/810124

Change 810142 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.18] SuggestedEdits: Adjust thumbnailSource logic

https://gerrit.wikimedia.org/r/810142

@Kstyo

@kostajh - here are few examples of the fetched articles in suggested image feed:

arwiki

pageId: 343044  thumbnailSource: "https://upload.wikimedia.org/wikipedia/commons/thumb/8/85/CIAJMK1209-ar.svg/langar-332px-CIAJMK1209-ar.svg.png"

pageId: 717897  thumbnailSource: "https://upload.wikimedia.org/wikipedia/commons/thumb/d/df/Dharma_Wheel.svg/langar-332px-Dharma_Wheel.svg.png"

pageId: 2558221 thumbnailSource: "https://upload.wikimedia.org/wikipedia/commons/thumb/0/06/Honeymoon_Island_State_Park_-_panoramio_%281%29.jpg/332px-Honeymoon_Island_State_Park_-_panoramio_%281%29.jpg"

pageId: 343044 thumbnailSource: "https://upload.wikimedia.org/wikipedia/commons/thumb/8/85/CIAJMK1209-ar.svg/langar-332px-CIAJMK1209-ar.svg.png"

cswiki

pageId: 756735  thumbnailSource: "https://upload.wikimedia.org/wikipedia/commons/thumb/5/5f/Louis_XIV_of_France.jpg/332px-Louis_XIV_of_France.jpg"

Notes:

  • it seems that the articles with thumbnails are displayed only in the first 20 articles
  • the issue much more common on arwiki ~3-4 articles from 20
  • reloading Homepage brings new examples of articles with thumbnails

Thanks @Etonkovidov!

Change 810142 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.18] SuggestedEdits: Adjust thumbnailSource logic

https://gerrit.wikimedia.org/r/810142

@KStoller-WMF we haev a fix merged, but the earliest we can deploy the backport is Tuesday July 5, I've scheduled the backport for the UTC morning backport/deploy window.

Change 810301 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Adjust thumbnailSource logic

https://gerrit.wikimedia.org/r/810301

Change 810142 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.18] SuggestedEdits: Adjust thumbnailSource logic

https://gerrit.wikimedia.org/r/810142

Mentioned in SAL (#wikimedia-operations) [2022-07-05T07:33:43Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.18/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php: ce64780fbd78a414c6ab08fc374186ae4dd58bac: SuggestedEdits: Adjust thumbnailSource logic (T311789) (duration: 03m 32s)

Etonkovidova claimed this task.