Page MenuHomePhabricator
Create Task
Maniphest T312426

Migrate usage of Database::select to SelectQueryBuilder in IPInfo
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

AC

Details

SubjectRepoBranchLines +/-
Migrate usage of Database::select to SelectQueryBuilder in IPInfomediawiki/extensions/IPInfomaster+105 -63
Migrate usage of Database::select to SelectQueryBuilder in IPInfomediawiki/extensions/IPInfomaster+53 -79
Customize query in gerrit

Related Objects
Search...

Event Timeline

Maintenance_bot created this task.Jul 7 2022, 6:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2022, 6:27 AM
Ladsgroup added a project: IP Info.Jul 7 2022, 6:55 AM
Tchanders added a project: Anti-Harassment.Aug 8 2022, 4:04 PM
Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.
Tchanders added a subscriber: STran.Aug 8 2022, 4:35 PM
STran updated the task description. (Show Details)Aug 8 2022, 5:38 PM
STran set the point value for this task to 5.
• Prtksxna moved this task from Backlog to Up Next on the IP Info board.Aug 10 2022, 4:09 AM
STran moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.Aug 15 2022, 4:48 PM
ARamirez_WMF moved this task from Cards ready for development to AHaT Sprint 14: The Umbrella Hat on the Anti-Harassment board.Aug 16 2022, 5:17 PM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 14: The Umbrella Hat); removed Anti-Harassment.
• Prtksxna moved this task from Up Next to In Progress on the IP Info board.Aug 17 2022, 2:21 PM
Tchanders assigned this task to • TThoabala.Aug 22 2022, 10:41 AM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 14: The Umbrella Hat) board.
gerritbot added a comment.Aug 28 2022, 5:30 AM

Change 826981 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] Migrate usage of Database::select to SelectQueryBuilder in IPInfo

https://gerrit.wikimedia.org/r/826981

gerritbot added a project: Patch-For-Review.Aug 28 2022, 5:30 AM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 15: The Gandhi Cap); removed Anti-Harassment (AHaT Sprint 14: The Umbrella Hat).Aug 30 2022, 2:09 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 15: The Gandhi Cap) board.
• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 15: The Gandhi Cap) board.Sep 1 2022, 6:27 AM
dom_walden subscribed.EditedSep 6 2022, 8:30 AM
Testing notes

We probably just need to do some basic regression testing of IPInfo.

  1. It can be tested on beta (e.g. https://en.wikipedia.beta.wmflabs.org).
  2. Give your user the "checkuser" right (via https://en.wikipedia.beta.wmflabs.org/wiki/Special:UserRights/<you user>).
  3. Enable IPInfo via Special:Preferences (enable it in the beta preferences tab and then in the "User profile" tab check the two checkboxes under "IP Information").
  4. Open the IPInfo "popup" by clicking on the (i) icon on pages like:
    1. https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges?userExpLevel=unregistered&limit=500&days=30&enhanced=1&urlversion=2
    2. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Log&logid=994, https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Log&logid=250504 (other examples here)
    3. https://en.wikipedia.beta.wmflabs.org/wiki/0.5848547048459241?action=history (other examples here)
  5. On the above links, click an IP address to get to the Special:Contributions for that IP. Expand the IPInfo "infobox".
  6. Both the popup and infobox have a section for "Contributions" (i.e. edits that IP has made). You can check that this is correct by comparing it to the number of edits which are listed in the Special:Contributions for the IP.
  7. After doing the above, go to https://en.wikipedia.beta.wmflabs.org/wiki/Special:Log?type=ipinfo.
    1. If you looked at the IPInfo popup for an IP, you should see one log entry of the form <your user> viewed IP Information popup for <ip>.
    2. If you looked at the IPInfo infobox for an IP, you should see one log entry of the form <your user> viewed IP Information infobox for <ip>.
    3. If you did both, you should see both the log entries in A and B for the IP address.
    4. You should not see more than two log entries per IP address.
    5. There can be a delay in the log entries appearing. If they do not appear straight away, wait a few minutes.
STran edited projects, added Anti-Harassment (AHaT Sprint 16: The Sorting Hat); removed Anti-Harassment (AHaT Sprint 15: The Gandhi Cap).Sep 13 2022, 12:38 PM
STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 16: The Sorting Hat) board.
gerritbot added a comment.Sep 22 2022, 5:55 AM

Change 833900 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] Migrate usage of Database::select to SelectQueryBuilder in IPInfo

https://gerrit.wikimedia.org/r/833900

gerritbot added a comment.Sep 22 2022, 5:56 AM

Change 826981 abandoned by TsepoThoabala:

[mediawiki/extensions/IPInfo@master] Migrate usage of Database::select to SelectQueryBuilder in IPInfo

Reason:

Had complicated merge conflicts created https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/833900

https://gerrit.wikimedia.org/r/826981

gerritbot added a comment.Sep 22 2022, 5:43 PM

Change 833900 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Migrate usage of Database::select to SelectQueryBuilder in IPInfo

https://gerrit.wikimedia.org/r/833900

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 22 2022, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 22 2022, 6:30 PM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 16: The Sorting Hat) board.Sep 22 2022, 7:30 PM
GMikesell-WMF subscribed.Sep 26 2022, 9:59 PM

Regression testing (Steps 4 & 7) has passed in Beta as seen in the screenshots. Moving ticket to Done.

T312426_IPInfo_Contributions_PASS.png (502×1 px, 266 KB)

T312426_IPInfo_PASS.png (875×3 px, 149 KB)

OS: Chrome
Env: Beta

In T312426#8213064, @dom_walden wrote:
Testing notes

We probably just need to do some basic regression testing of IPInfo.

  1. It can be tested on beta (e.g. https://en.wikipedia.beta.wmflabs.org).
  2. Give your user the "checkuser" right (via https://en.wikipedia.beta.wmflabs.org/wiki/Special:UserRights/<you user>).
  3. Enable IPInfo via Special:Preferences (enable it in the beta preferences tab and then in the "User profile" tab check the two checkboxes under "IP Information").
  4. Open the IPInfo "popup" by clicking on the (i) icon on pages like:
    1. https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges?userExpLevel=unregistered&limit=500&days=30&enhanced=1&urlversion=2
    2. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Log&logid=994, https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Log&logid=250504 (other examples here)
    3. https://en.wikipedia.beta.wmflabs.org/wiki/0.5848547048459241?action=history (other examples here)
  5. On the above links, click an IP address to get to the Special:Contributions for that IP. Expand the IPInfo "infobox".
  6. Both the popup and infobox have a section for "Contributions" (i.e. edits that IP has made). You can check that this is correct by comparing it to the number of edits which are listed in the Special:Contributions for the IP.
  7. After doing the above, go to https://en.wikipedia.beta.wmflabs.org/wiki/Special:Log?type=ipinfo.
    1. If you looked at the IPInfo popup for an IP, you should see one log entry of the form <your user> viewed IP Information popup for <ip>.
    2. If you looked at the IPInfo infobox for an IP, you should see one log entry of the form <your user> viewed IP Information infobox for <ip>.
    3. If you did both, you should see both the log entries in A and B for the IP address.
    4. You should not see more than two log entries per IP address.
    5. There can be a delay in the log entries appearing. If they do not appear straight away, wait a few minutes.
GMikesell-WMF moved this task from QA/Testing 🐞 to Done Q1 2022-2023 on the Anti-Harassment (AHaT Sprint 16: The Sorting Hat) board.Sep 26 2022, 9:59 PM
• Prtksxna closed this task as Resolved.Oct 7 2022, 4:44 AM
• Prtksxna moved this task from In Progress to Closed on the IP Info board.Oct 7 2022, 4:51 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL