Seen in a GrowthExperiments patch (https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/162173/console)
11:46:52 There was 1 error: 11:46:52 11:46:52 1) Kartographer\Tests\ApiQueryMapDataTest::testStableAndLatest 11:46:52 Error: Call to a member function getRevId() on null 11:46:52 11:46:52 /workspace/src/extensions/Kartographer/tests/phpunit/ApiQueryMapDataTest.php:191 11:46:52 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:486
Change 811941 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/Kartographer@master] phpunit: Skip ApiQueryMapDataTest::testStableAndLatest
Change 811941 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] phpunit: Skip ApiQueryMapDataTest::testStableAndLatest
No longer UBN, but tagging Content-Transform-Team and @MSantos for further investigation, as I have no idea what caused this.
Change 813663 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Kartographer@master] Try to make Kartographer vs. FlaggedRev test more stable
I suspect this (and T312709) were both caused by these patches: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/807926 and https://gerrit.wikimedia.org/r/c/mediawiki/core/+/807121
My analysis of T312709 leads me to believe that the issue is specific to parser tests. That would imply that the issue here is different - that doesn't mean it couldn't have been caused by my work on caching in tests, but the mechanism would have to be different.
[…] believe that the issue is specific to parser tests. That would imply that the issue here is different - that doesn't mean it couldn't have been caused by my work on caching in tests, but the mechanism would have to be different.
The ApiQueryMapDataTest is kind of a parser test. It's a full end-to-end test that starts with plain wikitext and expects the combination of parser cache and MediaWiki-extensions-FlaggedRevs to behave in a specific way.
Is there a ticket where the changes made in the two patches linked above are tracked?
Change 813663 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Try to make Kartographer vs. FlaggedRev test more stable
@kostajh I'm changing assignee to reflect reality. Let me know if this can be closed.