Page MenuHomePhabricator
Create Task
Maniphest T31284

Upload form should change file extensions to the canonical form automatically (lowercase, jpeg→jpg etc.)
Open, LowPublic
Actions

Description

Patch for skins/common/upload.js

IMHO upload form should make file extensions lowercase automatically during file name editbox autofill.
Patch is attached.

Version: unspecified
Severity: normal
See Also:
T42479: File extensions should be automatically decided by MIME type at upload
T34660: File extensions for the same file type should not allow variations of a file name (File:X.jpg, File:X.jpeg, File:X.JPG should all refer to the same file)
T31284: Upload form should change file extensions to the canonical form automatically (lowercase, jpeg→jpg etc.)
T213484: Normalize file extensions (capital vs small letters; jpg vs jpeg) for new uploads on Commons

Attached:

Autofill-Lowercase-Extensions-svn89562.diff482 BDownload

Details

Reference
bz29284

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:26 PM
• bzimport added a project: MediaWiki-File-management.
• bzimport set Reference to bz29284.
• bzimport added a subscriber: Unknown Object (MLST).
VitaliyFilippov created this task.Jun 6 2011, 2:54 PM
• brooke added a comment.Jun 6 2011, 5:54 PM

A few things to consider...

It looks like the name-changing in this patch is stuffed into the AJAX license preview code... it probably belongs over with fillDestFilename or other stuff that's related to the filename getting set.

When dealing with reuploading new versions over existing files, we need to make sure that the name doesn't get changed.

Patch needs to come with test cases if possible; see tests/qunit & http://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing for more info on our new JavaScript testing framework.

Since it looks like this name transformation isn't currently applied on the PHP side either, if done here it should also be done on the PHP side. This again would need to deal with the case of existing files that violate the new recommendation.

• bzimport added a comment.Sep 24 2012, 4:41 PM

johnnymrninja wrote:

Noting that bug 40479 would resolve this issue.

• Gilles added a project: Multimedia.Nov 24 2014, 3:29 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:40 PM
Restricted Application added subscribers: Steinsplitter, Matanya, Aklapper. · View Herald TranscriptSep 4 2015, 6:40 PM
Peachey88 unsubscribed.Sep 5 2015, 12:15 AM
matmarex mentioned this in T144593: File extension changes automatically while moving ogg audio file on Commons, caused by a gadget.Sep 2 2016, 1:45 PM
matmarex renamed this task from Upload form should make file extensions lowercase automatically to Upload form should change file extensions to the canonical form automatically (lowercase, jpeg→jpg etc.).Sep 6 2016, 6:08 PM
matmarex set Security to None.
matmarex removed a subscriber: • wikibugs-l-list.
Restricted Application added a project: Commons. · View Herald TranscriptSep 6 2016, 6:08 PM
Aklapper mentioned this in T42479: File extensions should be automatically decided by MIME type at upload.May 30 2019, 10:34 AM
Aklapper updated the task description. (Show Details)May 30 2019, 10:37 AM
Aklapper mentioned this in T34660: File extensions for the same file type should not allow variations of a file name (File:X.jpg, File:X.jpeg, File:X.JPG should all refer to the same file).May 30 2019, 10:43 AM
Aklapper mentioned this in T213484: Normalize file extensions (capital vs small letters; jpg vs jpeg) for new uploads on Commons.
Aklapper updated the task description. (Show Details)May 30 2019, 10:45 AM
Aklapper lowered the priority of this task from Medium to Low.Mar 21 2020, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits