| Jdlrobson | |
| Jul 14 2022, 5:03 PM |
| F35317203: Screen Shot 2022-07-14 at 9.36.00 AM.png | |
| Jul 14 2022, 5:03 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
What should have happened instead?:
Tthe table of contents narrow screen mode work here
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove non grid support handling, just show the TOC | mediawiki/skins/Vector | master | +2 -2 | |
| IE11: Tweak display | mediawiki/skins/Vector | master | +37 -3 |
Change 813937 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] IE11: Tweak display
Change 813937 abandoned by Jdlrobson:
[mediawiki/skins/Vector@master] IE11: Tweak display
Reason:
Not working on this for now.
- The user menu when opened introduces a horizontal scroll like so:
{F35317203}
This screenshot has not been attached
Looked at IE11 today and the situation is much improved. The table of contents is still not accessible, but Since we are dropping support for IE11 in T178356 it might be worth waiting until then.
So the issue here is CSS grid support not grade C. We should make the table of contents work when CSS grid is not available.
T178356 hasn't fixed this and potentially has made this worse.
Change 933599 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Remove non grid support handling, just show the TOC
Test wiki created on Patch demo by BWang (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/7098023a31/w
Currently browsers that dont support grid just hide the TOC, which isnt ideal because the TOC is considered content. For this task, I chose to just avoid hiding the TOC when grid isnt supported, resulting in this:
https://jmp.sh/J4dilGgl
https://jmp.sh/SrU2Cx3d
I looked into styling the TOC as a dropdown when grid support isnt there, but its seems very complicated. It might be possible if we could use "not supports(:grid)", but thats not recommended due to browser support of "supports()". IMO this is the simplest solution, and the design can be revisited perhaps with T340571
Change 933599 abandoned by Bernard Wang:
[mediawiki/skins/Vector@master] Remove non grid support handling, just show the TOC
Reason:
After talking to @Jdlrobson, we decided that unhiding the TOC on browsers that dont support grid create an experience that looks more broken than the status quo. Instead of handling the TOC separately, we will continue to hide all pinned elements (main menu, page tools, toc) on browsers that dont support grid on all viewports
Test wiki on Patch demo by BWang (WMF) using patch(es) linked to this task was deleted: