IP Info: The loading animation is now not the same size as the infobox while it is loading
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• TThoabala
	Aug 2 2022, 2:24 PM

Description

Following on this https://phabricator.wikimedia.org/T306746#8118371
We need to update the loading animation to be same size as the infobox.

Screenshot:

Details

	Subject	Repo	Branch	Lines +/-
	Make loading animation the same size as the infobox	mediawiki/extensions/IPInfo	master	+1 -1
	Load animation same size as infobox	mediawiki/extensions/IPInfo	master	+5 -0

Customize query in gerrit

Related Objects

Mentioned In: T315005: Empty space in IPInfo menu when no edit from an IP address
T306746: Layout shift when IP Info arrives into expanded state (insufficient height reserved)
Mentioned Here: rEIPI2eaf682199db: Merge "Load animation same size as infobox"
T306746: Layout shift when IP Info arrives into expanded state (insufficient height reserved)

Event Timeline

• TThoabala created this task.Aug 2 2022, 2:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 2 2022, 2:24 PM

• TThoabala mentioned this in T306746: Layout shift when IP Info arrives into expanded state (insufficient height reserved).Aug 2 2022, 2:25 PM

Tchanders updated the task description. (Show Details)Aug 2 2022, 3:51 PM

Tchanders attached a referenced file: F35382172: loading.png. (Show Details)

• Di3sel1975 added a subtask: T314452: VisualEditor returns error in blkwiki.Aug 3 2022, 6:34 AM

Aklapper removed a subtask: T314452: VisualEditor returns error in blkwiki.Aug 3 2022, 6:41 AM

Tchanders added a project: Anti-Harassment.Aug 3 2022, 2:26 PM

Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.

STran set the point value for this task to 1.Aug 8 2022, 5:15 PM

• Prtksxna moved this task from Backlog to Up Next on the IP Info board.Aug 10 2022, 4:09 AM

STran moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.Aug 15 2022, 4:48 PM

ARamirez_WMF moved this task from Cards ready for development to AHaT Sprint 14: The Umbrella Hat on the Anti-Harassment board.Aug 16 2022, 5:17 PM

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 14: The Umbrella Hat); removed Anti-Harassment.

ARamirez_WMF assigned this task to Cyndymediawiksim.Aug 16 2022, 5:20 PM

Cyndymediawiksim moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 14: The Umbrella Hat) board.Aug 17 2022, 9:43 AM

Cyndymediawiksim moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 14: The Umbrella Hat) board.Aug 17 2022, 10:48 AM

Change 824187 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/IPInfo@master] Load animation same size as infobox

https://gerrit.wikimedia.org/r/824187

gerritbot added a project: Patch-For-Review.Aug 17 2022, 11:39 AM

• Prtksxna moved this task from Up Next to In Progress on the IP Info board.Aug 17 2022, 2:21 PM

Cyndymediawiksim mentioned this in T315005: Empty space in IPInfo menu when no edit from an IP address.Aug 22 2022, 9:28 AM

I am happy with the patch , but I think we might be adding some extra space at the end of info box...

Screenshot at Aug 22 18-29-00.png (924×2 px, 323 KB)

@Prtksxna is this ok?

In T314394#8175048, @TThoabala wrote:

I am happy with the patch , but I think we might be adding some extra space at the end of info box...

@Prtksxna is this ok?

Thanks for catching that! No, we shouldn't be adding an extra space at the bottom of the box.

Change 824187 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Load animation same size as infobox

https://gerrit.wikimedia.org/r/824187

Maintenance_bot removed a project: Patch-For-Review.Aug 25 2022, 8:30 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.27; 2022-08-29).Aug 25 2022, 9:00 AM

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 14: The Umbrella Hat) board.Aug 25 2022, 12:55 PM

Example of the loading animation on Vector 2022:

I notice the margin at the bottom is slightly bigger than the right and left. This is the same for all the skins. @Prtksxna is this OK?

I tested on Vector 2010, Vector 2022, Minerva, MonoBook and Timeless. We haven't changed the "jump" behaviour from T306746#8133298.

Test environment: https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (2eaf682) 08:27, 25 August 2022.

In T314394#8187936, @dom_walden wrote:

I notice the margin at the bottom is slightly bigger than the right and left. This is the same for all the skins. @Prtksxna is this OK?

Thanks Dom! We should maintain the same margin from the bottom as well. @Cyndymediawiksim @TThoabala, I'm moving this to In Progress, hope that is okay!

• Prtksxna moved this task from Design Review 🔬 to In Progress 💪 on the Anti-Harassment (AHaT Sprint 14: The Umbrella Hat) board.Aug 29 2022, 4:56 AM

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 15: The Gandhi Cap); removed Anti-Harassment (AHaT Sprint 14: The Umbrella Hat).Aug 30 2022, 2:09 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 15: The Gandhi Cap) board.

Change 828478 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/IPInfo@master] Loading animation is now same size as the infobox

https://gerrit.wikimedia.org/r/828478

gerritbot added a project: Patch-For-Review.Aug 31 2022, 9:02 AM

What's this for this bored

Cyndymediawiksim moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 15: The Gandhi Cap) board.Aug 31 2022, 9:55 AM

Change 828478 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Make loading animation the same size as the infobox

https://gerrit.wikimedia.org/r/828478

I've merged the follow-up, assuming that this is close enough:

The space at the bottom is slightly larger than the space at the sides, but I think we'd need to do a px/em calculation to get it exact. @Prtksxna How does this look?

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.28; 2022-09-05); removed MW-1.39-notes (1.39.0-wmf.27; 2022-08-29).Aug 31 2022, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 31 2022, 4:30 PM

Looks good, moving to done :)

• Prtksxna closed this task as Resolved.Sep 22 2022, 3:20 PM

• Prtksxna moved this task from In Progress to Closed on the IP Info board.Oct 7 2022, 4:51 AM

	F35484174: Screenshot at Aug 22 18-29-00.png
	Aug 22 2022, 4:33 PM

	F35501330: image.png
	Aug 31 2022, 3:49 PM

IP Info: The loading animation is now not the same size as the infobox while it is loadingClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

IP Info: The loading animation is now not the same size as the infobox while it is loading
Closed, ResolvedPublic1 Estimated Story Points
Actions