Page MenuHomePhabricator

Mention autocompletion doesn't work as expected with the reply tool
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Open a talk page on it.wikipedia and try to answer to the last discussion by clicking on the button "reply"
  • in the form, try to notify the user who you want to reply to, by clicking on the account icon

What happens?:

  • The list to select users to notify doesn't show any suggestion, even if you are beginning to write some letters of the account of the user below.

What should have happened instead?:

  • In the notification list, you should see the accounts of the users talking in the current discussion.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Wikipedia_Officina - Wikipedia — Mozilla Firefox 25_08_2022 14_31_06.png (249×904 px, 17 KB)

See discussions about this subject on fr.wiktionary and it.wikipedia

Event Timeline

Thanks for the bug report, I can reproduce.

Seems to be caused by this change in the last OOUI update: https://gerrit.wikimedia.org/r/c/oojs/ui/+/819000/1/src/widgets/SelectWidget.js#617
…combined with this hack in our completion code: https://gerrit.wikimedia.org/g/VisualEditor/VisualEditor/+/f2995f346b4680fd9d3752e236b8a6f510d90b4a/src/ui/widgets/ve.ui.CompletionWidget.js#134

Basically, we were pretending that the menu has at least one item even when it has none, so that the menu wouldn't be hidden. But now OOUI expects to find at least one item in the menu when we do that, and fails horribly.

matmarex renamed this task from Notification doesn't work as expected with the New Discussion to Mention autocompletion doesn't work as expected with the New Discussion.Aug 25 2022, 1:08 PM

Change 826562 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] ve.ui.CompletionWidget: Fix showing with no items for latest OOUI

https://gerrit.wikimedia.org/r/826562

Xaosflux added a subscriber: Xaosflux.

This is a default utility on production projects, impacting even logged out users.

Change 826562 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] ve.ui.CompletionWidget: Fix showing with no items for latest OOUI

https://gerrit.wikimedia.org/r/826562

Change 826580 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d4c438548)

https://gerrit.wikimedia.org/r/826580

Change 826580 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d4c438548)

https://gerrit.wikimedia.org/r/826580

Change 826345 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.26] Update VE core submodule to master (d4c438548)

https://gerrit.wikimedia.org/r/826345

Esanders renamed this task from Mention autocompletion doesn't work as expected with the New Discussion to Mention autocompletion doesn't work as expected with the reply tool.Aug 25 2022, 5:30 PM

Change 826345 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.26] Update VE core submodule to master (d4c438548)

https://gerrit.wikimedia.org/r/826345

Mentioned in SAL (#wikimedia-operations) [2022-08-25T20:39:25Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.26/extensions/VisualEditor/: 223e81f08e1f62b1ed78bcb2bdcc104e7fb60734: Update VE core submodule to master (d4c438548; T316219) (duration: 03m 42s)

Should be fixed on all Wikimedia wikis now.

Tests on enwiki show it is working.