Maniphest T316434

Migrate usage of Database::select to SelectQueryBuilder in CheckUser's TimelineRowFormatter
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

See the parent task T312479: Migrate usage of Database::select to SelectQueryBuilder in CheckUser for details.

Acceptance criteria

SelectQueryBuilder is used where possible in TimelineRowFormatter

Notes

For more information check T243051 and its documentation.

Details

	Subject	Repo	Branch	Lines +/-
	Migrate usage of Database::select to SelectQueryBuilder in CheckUser's TimelineRowFormatter	mediawiki/extensions/CheckUser	master	+7 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T311866 Migrate Database::select usages to SelectQueryBuilder (in WMF-deployed extensions)
		Resolved		Dreamy_Jazz	T312479 Migrate usage of Database::select to SelectQueryBuilder in CheckUser
		Resolved		• TThoabala	T316434 Migrate usage of Database::select to SelectQueryBuilder in CheckUser's TimelineRowFormatter

Event Timeline

Tchanders created this task.Aug 27 2022, 1:24 PM

Tchanders moved this task from Untriaged to CheckUser on the Anti-Harassment board.

Dreamy_Jazz moved this task from General / Unsorted to Investigate on the CheckUser board.Aug 27 2022, 6:13 PM

Tchanders edited projects, added Anti-Harassment (AHaT Sprint 15: The Gandhi Cap); removed Anti-Harassment.Sep 1 2022, 7:38 PM

Tchanders set the point value for this task to 3.Sep 1 2022, 7:53 PM

• TThoabala claimed this task.Sep 6 2022, 8:18 PM

• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 15: The Gandhi Cap) board.

Change 830482 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/CheckUser@master] Migrate usage of Database::select to SelectQueryBuilder in CheckUser's TimelineRowFormatter

https://gerrit.wikimedia.org/r/830482

gerritbot added a project: Patch-For-Review.Sep 7 2022, 5:31 AM

• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 15: The Gandhi Cap) board.Sep 7 2022, 5:32 AM

• AGueyte moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 15: The Gandhi Cap) board.Sep 7 2022, 3:11 PM

Change 830482 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Migrate usage of Database::select to SelectQueryBuilder in CheckUser's TimelineRowFormatter

https://gerrit.wikimedia.org/r/830482

Maintenance_bot removed a project: Patch-For-Review.Sep 7 2022, 3:30 PM

Tchanders updated the task description. (Show Details)Sep 7 2022, 3:36 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 7 2022, 4:00 PM

STran edited projects, added Anti-Harassment (AHaT Sprint 16: The Sorting Hat); removed Anti-Harassment (AHaT Sprint 15: The Gandhi Cap).Sep 13 2022, 12:39 PM

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 16: The Sorting Hat) board.

I compared the SQL queries before and after this change for the Timeline tab, on both SQLite and MySQL. They were identical.

I also checked that it could successfully return the edit summary of a deleted revision.

Test environments:

local docker (SQLite) CheckUser 2.5 (aea1ef3) 06:33, 20 September 2022.
local bare-metal (MySQL) CheckUser 2.5 (f595564) 07:28, 21 September 2022.

Has been done.