In T314318, cswiki and enwikivoyage opted in to the new media structure. However, that seems to have exposed that not all deployed skins were updated beforehand.
For example, see https://en.m.wikivoyage.org/wiki/Dresden
This should have been fixed in T287965 but seems to have been overlooked.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Arlolra | T51097 Use figure and figcaption HTML5 elements when possible | |||
| Resolved | Arlolra | T71353 Magnify button goes to wrong image if thumbnail caption contains images | |||
| Resolved | BUG REPORT | TheDJ | T321442 MMV uses incorrect caption for images included in the caption of an image | ||
| Resolved | Arlolra | T314318 Disable wgParserEnableLegacyMediaDOM on all wikis | |||
| Resolved | Arlolra | T287965 Skins not loading content-media feature misaligned? | |||
| Resolved | Arlolra | T318300 Media alignment broken with MinervaNeue since disabling wgParserEnableLegacyMediaDOM |
The ResourceLoaderSkinModules are optional. They should be seen as boilerplate styles. In the case of Minerva, given its desire to keep the minimum possible CSS payload it currently ships its own styles.
I assume you'll need to add a minimum set of relevant rules to https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/resources/skins.minerva.base.styles/content/images.less and https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/resources/skins.minerva.base.styles/content/thumbnails.less
Change 834342 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/skins/MinervaNeue@master] [WIP] Fix media alignment since disabling wgParserEnableLegacyMediaDOM
Change 834350 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/skins/MinervaNeue@master] Restrict figure to the size of the media
Change 834350 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Restrict figure to the size of the media
Change 834364 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/skins/MinervaNeue@wmf/1.40.0-wmf.2] Restrict figure to the size of the media
Change 834342 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix media alignment since disabling wgParserEnableLegacyMediaDOM
Change 834366 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/skins/MinervaNeue@wmf/1.40.0-wmf.2] Fix media alignment since disabling wgParserEnableLegacyMediaDOM
Change 834364 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.40.0-wmf.2] Restrict figure to the size of the media
Change 834366 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.40.0-wmf.2] Fix media alignment since disabling wgParserEnableLegacyMediaDOM
Mentioned in SAL (#wikimedia-operations) [2022-09-22T20:47:42Z] <brennen@deploy1002> Started scap: Backport for [[gerrit:834364|Restrict figure to the size of the media (T305357 T318300)]], [[gerrit:834366|Fix media alignment since disabling wgParserEnableLegacyMediaDOM (T318300)]]
Mentioned in SAL (#wikimedia-operations) [2022-09-22T20:48:02Z] <brennen@deploy1002> brennen and arlolra: Backport for [[gerrit:834364|Restrict figure to the size of the media (T305357 T318300)]], [[gerrit:834366|Fix media alignment since disabling wgParserEnableLegacyMediaDOM (T318300)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet
Mentioned in SAL (#wikimedia-operations) [2022-09-22T20:54:16Z] <brennen@deploy1002> Finished scap: Backport for [[gerrit:834364|Restrict figure to the size of the media (T305357 T318300)]], [[gerrit:834366|Fix media alignment since disabling wgParserEnableLegacyMediaDOM (T318300)]] (duration: 06m 33s)
Still missing the vertical alignment for galleries,
https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.skinning/content.media-common.less#L253-L272
Change 834407 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/core@master] [WIP] Separate new gallery styles from content-media feature
Change 834602 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/skins/MinervaNeue@master] Remove redundant styling rules and fix center/none halign for figures
Change 834606 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/skins/MinervaNeue@master] Hide figcaptions for plain and frameless figures
Change 834602 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove redundant styling rules and fix center/none halign for figures
Change 834606 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Hide figcaptions for plain and frameless figures
We are going to let the last set of changes to MinervaNeue ride next week's train. If someone sees an urgency and needs this to be backported to this week's train, please chime in and we'll make it happen.
Change 834407 merged by jenkins-bot:
[mediawiki/core@master] Separate gallery styles from the content-media feature
Change 844078 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/skins/MinervaNeue@master] [WIP] max-width only applies to thumbs
Change 844078 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] max-width only applies to thumbs
Change 852243 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/skins/MinervaNeue@master] Media border option applies to the media element, not the wrapper
Change 852243 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Media border option applies to the media element, not the wrapper
Change 852314 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/skins/MinervaNeue@wmf/1.40.0-wmf.8] Media border option applies to the media element, not the wrapper
Change 852314 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.40.0-wmf.8] Media border option applies to the media element, not the wrapper
Mentioned in SAL (#wikimedia-operations) [2022-11-03T13:50:02Z] <lucaswerkmeister-wmde@deploy1002> Started scap: Backport for [[gerrit:852314|Media border option applies to the media element, not the wrapper (T318300)]]
Mentioned in SAL (#wikimedia-operations) [2022-11-03T13:50:26Z] <lucaswerkmeister-wmde@deploy1002> lucaswerkmeister-wmde and arlolra: Backport for [[gerrit:852314|Media border option applies to the media element, not the wrapper (T318300)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet
Mentioned in SAL (#wikimedia-operations) [2022-11-03T13:56:34Z] <lucaswerkmeister-wmde@deploy1002> Finished scap: Backport for [[gerrit:852314|Media border option applies to the media element, not the wrapper (T318300)]] (duration: 06m 31s)