IP Info accordion should show count of deleted edits to those who have access
Closed, ResolvedPublic3 Estimated Story PointsFeature
Actions

Assigned To

Authored By

	• Prtksxna
	Sep 24 2022, 5:52 AM

Description

from T309366: Investigate: IP info not shown when all IP's edits are deleted

For the purposes of this task, deleting refers to deleting (archiving) a page, rather than suppressing an edit. For example, Special:DeletedContributions shows a user's edits to any pages which have since been deleted.

Feature summary

Add text under the contributions heading that shows number of deleted edits (if there are any)
Add a link to DeletedContributions (if there is more than 0 deleted contributions)

Use case(s)

Admins to have access to more info

Screen Shot 2022-09-24 at 11.22.04 AM.png (464×822 px, 46 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Show deleted edits on IPInfobox	mediawiki/extensions/IPInfo	master	+104 -22

Customize query in gerrit

Related Objects

Mentioned In: T318463: IP Info accordion should show up on the Special:DeletedContributions
T309366: Investigate: IP info not shown when all IP's edits are deleted
Mentioned Here: T325214: Ensure WikimediaMessages links show up on IPInfo infobox on Special:DeletedContributions
T309366: Investigate: IP info not shown when all IP's edits are deleted

Event Timeline

• Prtksxna created this task.Sep 24 2022, 5:52 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2022, 5:52 AM

• Prtksxna mentioned this in T309366: Investigate: IP info not shown when all IP's edits are deleted.Sep 24 2022, 5:53 AM

• Prtksxna moved this task from Backlog to Up Next on the IP Info board.Oct 7 2022, 4:52 AM

• Prtksxna triaged this task as Medium priority.Nov 1 2022, 3:59 AM

Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Nov 7 2022, 1:48 PM

Tchanders renamed this task from IP Info accordion should show count of deleted edits those who have access to IP Info accordion should show count of deleted edits to those who have access.Nov 16 2022, 4:21 PM

Tchanders set the point value for this task to 3.

• AGueyte claimed this task.Nov 21 2022, 4:35 PM

Tchanders moved this task from Triage/To be Estimated to AHaT Sprint 19: The Sanbenito on the Anti-Harassment board.Nov 22 2022, 2:13 PM

Tchanders edited projects, added Anti-Harassment (AHaT Sprint 19: The Sanbenito); removed Anti-Harassment.

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 19: The Sanbenito) board.

Tchanders updated the task description. (Show Details)Nov 22 2022, 2:34 PM

Change 859544 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/IPInfo@master] Show deleted edits on IPInfobox

https://gerrit.wikimedia.org/r/859544

gerritbot added a project: Patch-For-Review.Nov 22 2022, 3:27 PM

ARamirez_WMF edited projects, added Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat); removed Anti-Harassment (AHaT Sprint 19: The Sanbenito).Nov 22 2022, 6:26 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat) board.

• AGueyte mentioned this in T318463: IP Info accordion should show up on the Special:DeletedContributions.Nov 24 2022, 5:39 PM

• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat) board.Nov 30 2022, 5:56 PM

Hi @Prtksxna, when it says "Use case(s): Admins to have access to more info"

Does it mean the information should be seen only by the "ipinfo-view-full" rights?

Or "ipinfo-view-basic" can also see it?

Thanks!

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 22: Asian Conical Hat); removed Anti-Harassment ( AHaT Sprint 21: The Bruntal Hat).Dec 6 2022, 3:52 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.

@Niharika to follow up :)

Tchanders moved this task from Code Review 🔍 to Needs Design/Product 🎨 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Dec 6 2022, 6:46 PM

In T318464#8442757, @AGueyte wrote:

Hi @Prtksxna, when it says "Use case(s): Admins to have access to more info"
Does it mean the information should be seen only by the "ipinfo-view-full" rights?
Or "ipinfo-view-basic" can also see it?

As I understand it, who gets to see this information will depend on two things:

The IP Info right, as you mentioned: I think this should be in ipinfo-view-full right since deleted edits are usually sensitive edits
Access to the deleted edits: The number that we show under this heading would depend on whether or not the user has access to these suppressed edits. IIRC, there are cases where admins can suppress edits from other admins too. In such cases the number might change.

@STran who did the initial investigate would be able to share more.

In T318464#8453097, @Prtksxna wrote:

In T318464#8442757, @AGueyte wrote:

Hi @Prtksxna, when it says "Use case(s): Admins to have access to more info"
Does it mean the information should be seen only by the "ipinfo-view-full" rights?
Or "ipinfo-view-basic" can also see it?

As I understand it, who gets to see this information will depend on two things:

The IP Info right, as you mentioned: I think this should be in ipinfo-view-full right since deleted edits are usually sensitive edits

Access to the deleted edits: The number that we show under this heading would depend on whether or not the user has access to these suppressed edits. IIRC, there are cases where admins can suppress edits from other admins too. In such cases the number might change.

@STran who did the initial investigate would be able to share more.

Just to clarify, this task is about archived edits, not suppressed edits (see task description). But I agree with this, since the 'deletedhistory' right isn't given to everyone either.

Tchanders moved this task from Needs Design/Product 🎨 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Dec 13 2022, 7:07 PM

• AGueyte moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Dec 14 2022, 4:08 PM

• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Dec 22 2022, 5:50 PM

• AGueyte moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Jan 5 2023, 4:31 PM

• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Jan 5 2023, 8:40 PM

• AGueyte moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Jan 9 2023, 4:18 PM

• AGueyte moved this task from In Progress 💪 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.Jan 9 2023, 4:28 PM

• AGueyte moved this task from QA/Testing 🐞 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 22: Asian Conical Hat) board.

Change 859544 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Show deleted edits on IPInfobox

https://gerrit.wikimedia.org/r/859544

I tested this by editing an article from an IP address, then deleting that article (as an admin).

I then visited Special:Contributions:

for that IP address, as a user with the 'deletedhistory' right. I saw the number of deleted edits, plus a link to Special:DeletedContributions for that IP address.
for that IP address, as a user without the 'deletedhistory' right. I saw no information about deleted contributions.
for an IP address with no deleted contributions, as a user with the 'deletedhistory' right. I saw "No deleted edits". There was no link.

Additionally:

It should be possible to test this on beta
In English, there should be different messages depending on whether there are 0, 1 or 2 deleted edits

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Jan 10 2023, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2023, 4:30 PM

@AGueyte @Tchanders

I tested this by editing an article from an IP address, then deleting that article (as an admin).

As an Admin, I did not see Global Contributions and XTools under the Deleted Contributions compared to the screenshot in the description.

OS: Mac 13.0
Brower: Chrome
Environment: Beta

Special:DeletedContributions: Article that was deleted, shows in the deleted contribution history as seen highlighted

T318464_IPInfo_Accordion_SpecialDeletedContributions.png (1×1 px, 271 KB)

Special:Contributions: Article that was deleted, did not show in the contribution history

T318464_IPInfo_Accordion_SpecialContributions.png (1×1 px, 386 KB)

@AGueyte Please see the following results below. Thanks!

OS: macOS 13.0
Browser: Chrome 108
Environment: Beta

Testusterone- with no deletedhistory rights

Special:contributions
W/history: can see it w/Deleted contributions link

T318464_IPinfo_SC_WH.png (778×1 px, 210 KB)

W/o history: has “No deleted edits” with no link

T318464_IPinfo_SC_WOH.png (762×1 px, 169 KB)

Special:deletedcontributions
W/history: unable to proceed
W/o history: unable to proceed

T318464_IPinfo_SDCpng.png (419×1 px, 72 KB)

Admin - with deletedhistory rights

Special:contributions
W/history: yes you see # of deleted edits with “Deleted contributions” link

T318464_IPinfo_Admin_SC_WH.png (741×1 px, 188 KB)

W/o history: has “No deleted edits” with no link

T318464_IPinfo_Admin_SC_WOH.png (710×1 px, 164 KB)

Special:deletedcontributions
W/history: yes you see # of deleted edits with “Deleted contributions” link

T318464_IPinfo_Admin_SDC_WH.png (812×1 px, 165 KB)

W/o history: popup with “IP information for this address cannot be retrieved since no edits have been made from it

T318464_IPinfo_Admin_SDC_WOH.png (680×1 px, 130 KB)

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat); removed Anti-Harassment (AHaT Sprint 22: Asian Conical Hat).Jan 17 2023, 6:06 PM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.

GMikesell-WMF moved this task from QA/Testing 🐞 to Done Q2 2022-2023 on the Anti-Harassment (AHaT Sprint 23: Penguit Santa Hat) board.Jan 18 2023, 5:07 PM

In T318464#8514183, @GMikesell-WMF wrote:

@AGueyte @Tchanders

I tested this by editing an article from an IP address, then deleting that article (as an admin).

As an Admin, I did not see Global Contributions and XTools under the Deleted Contributions compared to the screenshot in the description.

Just a quick note that I'm seeing this on Beta now: https://en.wikipedia.beta.wmflabs.org/wiki/Special:DeletedContributions/47.156.78.174

I think it just needed T325214: Ensure WikimediaMessages links show up on IPInfo infobox on Special:DeletedContributions, which has been done now.

Thanks @GMikesell-WMF !

Got it, thanks for the update @Tchanders !

Niharika closed this task as Resolved.Feb 28 2023, 6:27 PM

Dreamy_Jazz moved this task from Up Next to Closed on the IP Info board.Feb 3 2024, 12:52 AM

	F36152307: T318464_IPinfo_Admin_SDC_WOH.png
	Jan 12 2023, 1:09 AM

	F36152305: T318464_IPinfo_Admin_SDC_WH.png
	Jan 12 2023, 1:09 AM

	F36152317: T318464_IPinfo_Admin_SC_WOH.png
	Jan 12 2023, 1:09 AM

	F36152309: T318464_IPinfo_Admin_SC_WH.png
	Jan 12 2023, 1:09 AM

	F36102001: T318464_IPInfo_Accordion_SpecialContributions.png
	Jan 10 2023, 8:00 PM

IP Info accordion should show count of deleted edits to those who have accessClosed, ResolvedPublic3 Estimated Story PointsFeatureActions

Description

Details

Related Objects

Event Timeline

IP Info accordion should show count of deleted edits to those who have access
Closed, ResolvedPublic3 Estimated Story PointsFeature
Actions