Preview mapframes should appear static if the wiki is configured to only show static mapframes
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Requirements

Disable dynamic features (zooming, panning) so that it becomes a static thumbnail, on wikis where the final mapframe will also be static
Full screen button and double-click must still work for full screen testing and to match final map

Technical background

When a site is configured to show only a static map thumbnail ($wgKartographerStaticMapframe = true), the preview mapframe should behave the same as the pulished map. When previewing, the thumbnail should be static and double-clicking into the map should show a dynamic, full-screen map.

For technical reasons, we can't show a true static thumbnail (because these are rendered on the maps server and it can only be done for saved article content, accessed via the MediaWiki API). But we could make the dynamic thumbnail behave mostly like a static map by disabling all interactions except for the double-click to open a full-screen map.

Opening as full-screen in the preview view already works as expected.

Demo for fix:
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Maptests/Inline_marker&action=edit

Click preview, see the "fake" static preview that cannot be moved around or zoomed

Details

Subject	Repo	Branch	Lines +/-
Disable right click coordinate popup for the static map preview	mediawiki/extensions/Kartographer	master	+12 -3
Don't change map position after fullscreen in static preview mode	mediawiki/extensions/Kartographer	master	+1 -1
Disable keyboard navigation on static preview	mediawiki/extensions/Kartographer	master	+2 -0
Make dynamic preview behave like static map in static mode	mediawiki/extensions/Kartographer	master	+11 -6
Don't renable draggable when map is static	mediawiki/extensions/Kartographer	master	+5 -2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T203863 StaticMapFrame configuration ignored when previewing a page
Open	BUG REPORT	None	T311295 Make "static" preview look more like the static image
Declined	BUG REPORT	None	T318493 mapframe / Kartographer: no dynamic map (ony in preview)
Resolved		thiemowmde	T318510 Preview mapframes should appear static if the wiki is configured to only show static mapframes

Event Timeline

awight created this task.Sep 26 2022, 7:14 AM

Change 835159 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] [POC] Make dynamic preview behave like static map in static mode

https://gerrit.wikimedia.org/r/835159

gerritbot added a project: Patch-For-Review.Sep 26 2022, 12:11 PM

ECohen_WMDE subscribed.Sep 27 2022, 7:49 AM

ECohen_WMDE moved this task from Backlog to Ready for story time on the WMDE-GeoInfo-FocusArea board.Sep 27 2022, 7:52 AM

thiemowmde set the point value for this task to 5.Sep 28 2022, 11:36 AM

ECohen_WMDE moved this task from Ready for story time to Ready for pickup on the WMDE-GeoInfo-FocusArea board.Sep 28 2022, 12:32 PM

ECohen_WMDE renamed this task from Investigation: Edit preview should show a static mapframe to Preview mapframes should static if final mapframe is static.Oct 13 2022, 8:59 AM

ECohen_WMDE updated the task description. (Show Details)

lilients_WMDE renamed this task from Preview mapframes should static if final mapframe is static to Preview mapframes should be static if final mapframe is static.Oct 21 2022, 9:41 AM

awight renamed this task from Preview mapframes should be static if final mapframe is static to Preview mapframes should appear static if the wiki is configured to only show static mapframes.Oct 21 2022, 11:20 AM

awight updated the task description. (Show Details)

awight moved this task from Ready for pickup to In sprint on the WMDE-GeoInfo-FocusArea board.Jan 3 2023, 9:58 AM

awight added a project: WMDE-TechWish-Sprint-2022-11-29.

thiemowmde added a project: WMDE-TechWish-Sprint-2023-01-04.Jan 4 2023, 2:27 PM

awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2023-01-04 board.Jan 6 2023, 1:59 PM

awight moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2023-01-04 board.Jan 9 2023, 7:48 AM

WMDE-Fisch added a project: WMDE-TechWish-Sprint-2023-01-18.Jan 18 2023, 9:11 AM

WMDE-Fisch claimed this task.Jan 26 2023, 10:37 AM

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2023-01-18 board.

Change 883934 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Kartographer@master] Don't renable draggable when map is static

https://gerrit.wikimedia.org/r/883934

Change 883934 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Don't renable draggable when map is static

https://gerrit.wikimedia.org/r/883934

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Jan 26 2023, 3:00 PM

WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Jan 27 2023, 11:35 AM

WMDE-Fisch moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2023-01-18 board.

WMDE-Fisch subscribed.

Change 835159 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Make dynamic preview behave like static map in static mode

https://gerrit.wikimedia.org/r/835159

Maintenance_bot removed a project: Patch-For-Review.Jan 27 2023, 4:30 PM

awight moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2023-01-18 board.Jan 30 2023, 9:19 AM

What about arrow key controls? In beta these appear to be still enabled. Also, if I enter full screen, then zoom/pan and exit full screen, then would it be possible to reset the position?

Change 885271 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Kartographer@master] Disable keyboard navigation on static preview

https://gerrit.wikimedia.org/r/885271

gerritbot added a project: Patch-For-Review.Jan 31 2023, 8:25 AM

In T318510#8569247, @Pikne wrote:

What about arrow key controls? In beta these appear to be still enabled. Also, if I enter full screen, then zoom/pan and exit full screen, then would it be possible to reset the position?

Thanks, we missed the keyboard controls. I added a patch.

Resetting the position seems to be a bit more tricky due to the way the code is connected at that part. Since we try to wrap up the topic area, I'll leave this a step for further improvements. There's another ticket, I'll link here.

WMDE-Fisch added a parent task: T311295: Make "static" preview look more like the static image.Jan 31 2023, 8:54 AM

Fl.schmitt unsubscribed.Jan 31 2023, 8:57 AM

Change 885271 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Disable keyboard navigation on static preview

https://gerrit.wikimedia.org/r/885271

Change 885993 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Don't change map position after fullscreen in static preview mode

https://gerrit.wikimedia.org/r/885993

In T318510#8573348, @WMDE-Fisch wrote:

In T318510#8569247, @Pikne wrote:

What about arrow key controls? In beta these appear to be still enabled. Also, if I enter full screen, then zoom/pan and exit full screen, then would it be possible to reset the position?

Thanks, we missed the keyboard controls. I added a patch.

Resetting the position seems to be a bit more tricky due to the way the code is connected at that part. Since we try to wrap up the topic area, I'll leave this a step for further improvements. There's another ticket, I'll link here.

Ok Thiemo found the place I seemed to miss all the time :-D.

Change 885993 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Don't change map position after fullscreen in static preview mode

https://gerrit.wikimedia.org/r/885993

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.22; 2023-02-06); removed MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Feb 2 2023, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 2 2023, 11:30 AM

Right-clicking the thumbnail causes it to scroll and display coordinates. Perhaps we need to intercept button 3 as well.

Change 886924 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Kartographer@master] Disable right click coordinate popup for static maps in preview

https://gerrit.wikimedia.org/r/886924

gerritbot added a project: Patch-For-Review.Feb 6 2023, 5:19 PM

In T318510#8588662, @awight wrote:

Right-clicking the thumbnail causes it to scroll and display coordinates. Perhaps we need to intercept button 3 as well.

Note: This is a feature that was added for the Wikivoyage users some time ago, so they can get coordinates while editing more easily. See patch notes. Since we would only remove it for the static preview it seems fine though. Users can still use it when expanding the map.

WMDE-Fisch updated the task description. (Show Details)Feb 13 2023, 8:46 AM

thiemowmde closed this task as Resolved.Feb 13 2023, 10:37 AM

thiemowmde claimed this task.

Change 886924 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Disable right click coordinate popup for the static map preview

https://gerrit.wikimedia.org/r/886924

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.23; 2023-02-13); removed MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 13 2023, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2023, 11:31 AM