Page MenuHomePhabricator

New impact module: Allow debugging for arbitrary accounts
Closed, ResolvedPublic

Description

The user impact API (T313330) allows querying impact data for arbitrary users.

For convenience in debugging and understanding display issues, we should enable a mechanism to allow us to see the new impact module (T222310) with data for any user.

Two ways we could do that:

  1. Reuse the existing Special:Impact page to load the new impact module, and allow passing the username as a parameter, e.g. Special:Impact/KHarlan_(WMF).
  2. Pass a query parameter to Special:Homepage, something like Special:Homepage?geImpactModuleUsername=KHarlan_(WMF), where on page load the impact module would load data for KHarlan_(WMF) rather than the current logged-in user.

The first option seems less confusing to me, but open to the second idea too.

I think we should also think about a design variation so that it's obvious that the impact module is showing data for a user other than yourself.

Acceptance Criteria

  1. Should be able to debug the new impact module appearance for arbitrary accounts
  2. ....
Completion checklist

Functionality

  • The patches have been code reviewed and merged
  • The task passes its acceptance criteria

Engineering

  • There are existing and passing unit/integration tests
  • Tests for every involved patch should pass
  • Coverage for every involved project should have improved or stayed the same

Design & QA

  • If the task is UX/Design related: it must be reviewed and approved by the UX/Design team
  • Must be reviewed and approved by Quality Assurance.

Documentation

  • Related and updated documentation done where necessary

Event Timeline

Change 836275 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Allow loading on Special:Impact

https://gerrit.wikimedia.org/r/836275

Reuse the existing Special:Impact page to load the new impact module, and allow passing the username as a parameter, e.g. Special:Impact/KHarlan_(WMF).

I went with this option.

Change 836284 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] SpecialImpact: Pass username and ID to Vue client

https://gerrit.wikimedia.org/r/836284

Since Special:Impact/Username could be used for a broader public not just debugging would it be worth working on the module heading "Your impact" being conditional and showing something like "Username's impact" for this case?

Change 836275 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: Allow loading on Special:Impact

https://gerrit.wikimedia.org/r/836275

Since Special:Impact/Username could be used for a broader public not just debugging would it be worth working on the module heading "Your impact" being conditional and showing something like "Username's impact" for this case?

Yeah, that would make sense. I think we had that in the past as well.

I wonder if we should try to remove "You", "your", "you've" from headings in the module, though, to also make T219025: Impact Module Extensibility: allow transcluding Special:Impact on wikitext pages with {{Special:Impact/username}} easier.

Change 836284 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SpecialImpact: Pass username and ID to Vue client

https://gerrit.wikimedia.org/r/836284

Since Special:Impact/Username could be used for a broader public not just debugging would it be worth working on the module heading "Your impact" being conditional and showing something like "Username's impact" for this case?

I was actually wondering the same thing yesterday! I really like that idea, although I see a few edge case complications:

I don't think that needs to block us from moving in this direction, it's just something we should think about.
I looked at another community contributing app's public view of user's contribution data, and they simply have the Username at the top and avoid possessives and pronouns. So it's just "contributions" not "your contributions" or "Username's contributions".

Etonkovidova subscribed.

Special:Impact/username page (the old one) is present in current production (wmf.8). The new Special:Impact/username page was checked in enwiki betalabs - all looks as expected.

T219025: Impact Module Extensibility: allow transcluding Special:Impact on wikitext pages with {{Special:Impact/username}} captures the comment above - https://phabricator.wikimedia.org/T318540#8276132

Etonkovidova updated the task description. (Show Details)