Page MenuHomePhabricator
Create Task
Maniphest T320338

When using {{REVISIONTIMESTAMP:pagename}} in a template, it displayed as local time
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  1. login test.wikipedia.org
  2. Open [[Special:Preferences]]
  3. Goto 'Appearance' tab
  4. Set 'Time offset' as a time zone (non 'Use wiki default (UTC)')
  5. Click 'Save'
  6. Create page, see https://test.wikipedia.org/wiki/REVISIONTIMESTAMP_test. At this point the timestamp displayed by {{REVISIONTIMESTAMP:REVISIONTIMESTAMP test}} is server time
  7. Create another page: https://test.wikipedia.org/wiki/REVISIONTIMESTAMP_test/1, Content is '{{:REVISIONTIMESTAMP test}}', At this point the timestamp displayed by {{REVISIONTIMESTAMP:REVISIONTIMESTAMP test}} is local time

My test results ('Time offset' as 'Asia/Shanghai', UTC+8):
Content displayed in [[REVISIONTIMESTAMP_test]]:

REVISIONTIMESTAMP with pagename REVISIONTIMESTAMP test: 20221009035405

Content displayed in [[REVISIONTIMESTAMP_test/1]]:

REVISIONTIMESTAMP with pagename REVISIONTIMESTAMP test: 20221009115405

Details

SubjectRepoBranchLines +/-
parser: Use the actual revision timestamp of the page for messagesmediawiki/coremaster+7 -3
parser: Make the behavior of REVISIONTIMESTAMP consistentmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Shizhao created this task.Oct 9 2022, 3:50 AM
Restricted Application added a project: Performance-Team. · View Herald TranscriptOct 9 2022, 3:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Shizhao updated the task description. (Show Details)Oct 9 2022, 3:55 AM
Shizhao added a comment.Oct 9 2022, 4:04 AM

If edit [[REVISIONTIMESTAMP_test]] again, The {{REVISIONTIMESTAMP:REVISIONTIMESTAMP test}} timestamp displayed after refresh [[REVISIONTIMESTAMP test/1]] is the same as that of [[REVISIONTIMESTAMP_test]], both of which are server time.

After that if you edit [[REVISIONTIMESTAMP test/1]] again, the {{REVISIONTIMESTAMP:REVISIONTIMESTAMP test}} timestamp displayed by [[REVISIONTIMESTAMP test/1]] becomes local time again.

Shizhao updated the task description. (Show Details)Oct 9 2022, 4:10 AM
Shizhao updated the task description. (Show Details)Oct 9 2022, 6:01 AM
Func subscribed.EditedOct 9 2022, 9:42 AM

Possible commit that cause this: d08e0cdf209a764edd550651da551a93139fe64b
The last userAdjust() call didn't supply empty string as the second parameter as $parser->getRevisionTimestamp() does.

Func removed a project: MediaWiki-libs-Timestamp.Oct 9 2022, 9:43 AM
gerritbot added a comment.Oct 9 2022, 10:01 AM

Change 840566 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] parser: Make the behavior of REVISIONTIMESTAMP consistent

https://gerrit.wikimedia.org/r/840566

gerritbot added a project: Patch-For-Review.Oct 9 2022, 10:01 AM
Krinkle assigned this task to cscott.Oct 10 2022, 3:19 AM
Krinkle edited projects, added Parsoid; removed MediaWiki-Page-editing, MediaWiki-Templates.
Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.
Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.
Krinkle added subscribers: cscott, tstarling.
PatchDemoBot added a comment.Oct 10 2022, 7:47 AM

Test wiki created on Patch demo by Shizhao using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/f3c5e71f50/w

Shizhao added a comment.EditedOct 10 2022, 8:03 AM

PatchDemo seems to have fixed this issue

gerritbot added a comment.Oct 12 2022, 4:31 AM

Change 840566 merged by jenkins-bot:

[mediawiki/core@master] parser: Make the behavior of REVISIONTIMESTAMP consistent

https://gerrit.wikimedia.org/r/840566

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 12 2022, 5:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 12 2022, 5:30 AM
Shizhao added a project: User-notice.Oct 13 2022, 2:19 AM
• JMcLeod_WMF moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Oct 13 2022, 2:04 PM
Quiddity subscribed.Oct 13 2022, 7:21 PM

Hi. Re: Tech News (User-notice) - What wording would you suggest as the content (I.e. who does it affect, and what do they need to know, and what do they need to do)?
and When should it be included (I.e. If it should be in this Monday's edition, then we need wording before ~24hours from now when it will be frozen for translation) ? Thanks!

Func removed a project: User-notice.Oct 15 2022, 7:06 AM

I don't think this needs a user notice, it's just a small recent mistake and was fixed quickly. We can even close this if nothing needs to do on the Parsoid side.

Shizhao added a comment.Oct 21 2022, 2:55 AM

There still seems to be some problems. In edit mode, {{REVISIONTIMESTAMP}} displays the current time in the preview and edit notile, not the edit time of the last revision.

see https://test.wikipedia.org/w/index.php?title=REVISIONTIMESTAMP_test/6&action=edit

Func added a comment.Oct 21 2022, 3:24 AM
In T320338#8334654, @Shizhao wrote:

There still seems to be some problems. In edit mode, {{REVISIONTIMESTAMP}} displays the current time in the preview and edit notile, not the edit time of the last revision.

I believe this is the expected behaviour, tested on the previous version and that's how the preview works.

Shizhao added a comment.Oct 21 2022, 7:33 AM
在T320338#8334665中，@Func写道：

I believe this is the expected behaviour, tested on the previous version and that's how the preview works.

The previous version was not like this. Used {{REVISIONTIMESTAMP}} on edit notice for several years in zhwiki. The problem has only recently occurred. see:
https://zh.wikipedia.org/w/index.php?title=Template:Itn&action=edit
https://zh.wikipedia.org/wiki/Template:ITN-Update

In edit mode, {{ITN-Update}} in edit notice shows "0 seconds ago"

Func added a comment.Oct 21 2022, 8:22 AM

oh, I see, for message parsing like edit notice, it shouldn't be in the current time.

gerritbot added a comment.Oct 21 2022, 8:35 AM

Change 844560 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] parser: Fix revision timestamp when parsing messages

https://gerrit.wikimedia.org/r/844560

gerritbot added a project: Patch-For-Review.Oct 21 2022, 8:35 AM
PatchDemoBot added a comment.Oct 24 2022, 3:58 AM

Test wiki created on Patch demo by Shizhao using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/640b962919/w

Shizhao added a comment.Oct 24 2022, 4:11 AM
在T320338#8334846中，@gerritbot写道：

Change 844560 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] parser: Fix revision timestamp when parsing messages

https://gerrit.wikimedia.org/r/844560

@Func see https://patchdemo.wmflabs.org/wikis/640b962919/w/index.php?title=REVISIONTIMESTAMP_test&action=submit
still the current time

Func added a comment.Oct 24 2022, 5:29 AM

@Shizhao I only fix for edit notice. for preview, it's an intended change in 5cb4693 by @cscott

By the way, I am not sure from which version the behaviour of timestamp preview getting different with or without the page name, at least for 1.34 they are the same - current time.

ref: https://llwiki.org/mediawiki/index.php?title=User:Func/Sandbox&action=submit

Func added a comment.Oct 24 2022, 5:38 AM

after the patch, the timestamp will be real revision time in both modes for messages, e.g. edit notices.

Quiddity unsubscribed.Oct 24 2022, 6:03 PM
Shizhao added a comment.Oct 25 2022, 3:16 AM
在T320338#8337695中，@Func写道：

after the patch, the timestamp will be real revision time in both modes for messages, e.g. edit notices.

thx

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Jan 26 2023, 7:53 AM
Func added a comment.EditedFeb 24 2023, 2:05 AM
In T320338#8334752, @Shizhao wrote:

The previous version was not like this. Used {{REVISIONTIMESTAMP}} on edit notice for several years in zhwiki. The problem has only recently occurred. see:
https://zh.wikipedia.org/w/index.php?title=Template:Itn&action=edit
https://zh.wikipedia.org/wiki/Template:ITN-Update

In edit mode, {{ITN-Update}} in edit notice shows "0 seconds ago"

Please help to extend the task description, I will extend the commit message.

gerritbot added a comment.Feb 24 2023, 4:58 AM

Change 844560 merged by jenkins-bot:

[mediawiki/core@master] parser: Use the actual revision timestamp of the page for messages

https://gerrit.wikimedia.org/r/844560

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.25; 2023-02-27); removed MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Feb 24 2023, 5:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 24 2023, 5:10 AM
Func mentioned this in T318278: Self-referential Parser::getCachedRevisionObject() doesn't use last saved revision.Feb 24 2023, 5:25 AM
Shizhao closed this task as Resolved.Mar 3 2023, 3:51 AM
PatchDemoBot added a comment.Mar 3 2023, 3:54 AM

Test wiki on Patch demo by Shizhao using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/f3c5e71f50/w/

PatchDemoBot added a comment.Mar 6 2023, 12:43 PM

Test wiki on Patch demo by Shizhao using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/640b962919/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits