Page MenuHomePhabricator

Update GrowthExperiments to Codex 0.2.1
Closed, ResolvedPublic

Description

Some tests for GrowthExperiments fail with updating Codex. We should fix that, so LibUp update Codex to 0.2.2 (and future releases).


Codex was added to the list of repositories in T295420: Add Codex to LibraryUpgrader monitored repos. But @Sgs pointed out to me that based on this search, it does not seem like LibUp is updating repositories with new versions of Codex. (See also T295420#8247738.)

Do we need to do something to enable the updates for e.g. GrowthExperiments?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The used version are visible under https://libraryupgrader2.wmcloud.org/library/npm/%40wikimedia/codex?branch=main

The latest good for libup is 0.2.1 at the moment

You can bump that version under https://gerrit.wikimedia.org/g/labs/libraryupgrader/config/+/master/releases.json#91

I do not know there is a automatic bump to the latest when that version is published and the next run of libup starts. Only when a new version from npm audit is returned, there is a bump in the minor version.

libup starts every 24 hours

But on the first link all repos have a red ❌, that indicates libup has some issues with the repos to update. But the logs does not help me to see an fixable issue.

npm ci can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing.

@Umherirrender @Jdforrester-WMF provided a manual upgrade patch which uncovered failing tests more clearly with the Growth specific update from 0.1.0-alpha.7 to 0.2.2.

kostajh renamed this task from LibUp does not seem to upgrade Codex to Update GrowthExperiments to Codex 0.2.1.Oct 27 2022, 8:59 AM
kostajh updated the task description. (Show Details)
kostajh removed projects: LibUp, Codex, Design-System-Team.

Thanks everyone! It is clearly an issue for us to solve in GrowthExperiments. I learned more about what happens when LibUp fails, so thanks for the comments.

Change 849563 had a related patch set uploaded (by Kosta Harlan; author: Jforrester):

[mediawiki/extensions/GrowthExperiments@master] [WIP] build: Upgrade Codex from 0.1.0-alpha.7 to 0.2.2

https://gerrit.wikimedia.org/r/849563

Change 849563 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] build: Upgrade Codex from 0.1.0-alpha.7 to 0.2.1

https://gerrit.wikimedia.org/r/849563

Change 851616 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] package-lock: Align with package.json contents

https://gerrit.wikimedia.org/r/851616

Change 851616 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] package-lock: Align with package.json contents

https://gerrit.wikimedia.org/r/851616

kostajh claimed this task.

Epilogue: LibraryUpgrader successfully updated Codex to 0.2.2 in this patch rEGRE90ee50693aa7: build: Updating npm dependencies

thanks @Sgs and @Jdforrester-WMF for the patches, and to everyone else for your comments & insight!