Page MenuHomePhabricator

Make the "more details" dialog more similar to the prototypes
Closed, ResolvedPublic

Description

Current designCode
image.png (1×1 px, 187 KB)
image.png (1×1 px, 155 KB)

Design spec

We should also try and use semantic elements (like <h*> headers) for correctness and accessibility.

Notes:

  • the "view on map" link in the current design is just an exploration that should not be part of the actual implementation.

Event Timeline

@gonyeahialam Hello! Can you write a list of what needs to be changed? Thanks in advance!

ldelench_wmf renamed this task from Make the "more details" dialog more similar to the prototypes to [design input needed] Make the "more details" dialog more similar to the prototypes.Dec 15 2022, 3:25 PM
ldelench_wmf renamed this task from [design input needed] Make the "more details" dialog more similar to the prototypes to Make the "more details" dialog more similar to the prototypes.Mar 23 2023, 2:44 PM
Daimona updated the task description. (Show Details)

Change 934561 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Improve layout of event page dialog a bit

https://gerrit.wikimedia.org/r/934561

Change 935172 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] More layout improvements for the "more details" dialog

https://gerrit.wikimedia.org/r/935172

Change 935175 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Rewrite "more details" dialog section with header elements

https://gerrit.wikimedia.org/r/935175

Change 934561 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Improve layout of event page dialog a bit

https://gerrit.wikimedia.org/r/934561

Change 935172 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] More layout improvements for the "more details" dialog

https://gerrit.wikimedia.org/r/935172

Change 935175 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Rewrite "more details" dialog section with header elements

https://gerrit.wikimedia.org/r/935175

Change 952456 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Fix color of location headers in "more details" dialog

https://gerrit.wikimedia.org/r/952456

I would call this ready for QA once the patch above is merged. There are a few inconsistencies with the prototypes that are intentional and that I'm documenting here:

  • The list of organizers should have links to user pages; this is something we discussed a long time ago for usernames in general, and I think it's just that the proto wasn't updated
  • I couldn't find the "view all organizers" link in the prototype, so I just left it as it was in the initial implementation
  • The participant list has bullets because otherwise it would be unclear where a username starts and where it ends. We might explore different approaches, but what's shown in the prototype isn't sufficient
  • The date and time are formatted according to the user preferences, which could be different than what is shown in the proto
  • As noted in the task description, "view on map" is an experimental feature that we haven't implemented

And finally, the inline labels "organized by" and "timezone" are different than the prototype w.r.t. color and, for organizers, font weight. This would be a bigger change because of i18n, so I'd rather create a new task for it.

Change 952456 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Fix color of location headers in "more details" dialog

https://gerrit.wikimedia.org/r/952456

(Reminder of what I wrote in T322962#9120366, and that as we all previously discussed, any new issues should have their own task(s))

vaughnwalters subscribed.

And finally, the inline labels "organized by" and "timezone" are different than the prototype w.r.t. color and, for organizers, font weight. This would be a bigger change because of i18n, so I'd rather create a new task for it.

T345200 is created for this. Moving to design sign off.

And finally, the inline labels "organized by" and "timezone" are different than the prototype w.r.t. color and, for organizers, font weight. This would be a bigger change because of i18n, so I'd rather create a new task for it.

T345200 is created for this. Moving to design sign off.

Since a task has already been created for the changes, I would move this to product sign-off