| Current design | Code |
|---|---|
We should also try and use semantic elements (like <h*> headers) for correctness and accessibility.
Notes:
- the "view on map" link in the current design is just an exploration that should not be part of the actual implementation.
| Daimona | |
| Nov 12 2022, 2:38 PM |
| F37124593: image.png | |
| Jun 30 2023, 2:28 PM |
| F37097121: image.png | |
| Jun 7 2023, 6:48 PM |
| F37097115: image.png | |
| Jun 7 2023, 6:42 PM |
| F35744637: Screenshot 2022-11-10 at 17.47.10.png | |
| Nov 12 2022, 2:38 PM | |
| File Not Attached |
| F35744564: Organizer view.png | |
| Nov 12 2022, 2:38 PM | |
| File Not Attached |
| Current design | Code |
|---|---|
We should also try and use semantic elements (like <h*> headers) for correctness and accessibility.
Notes:
@gonyeahialam Hello! Can you write a list of what needs to be changed? Thanks in advance!
Change 934561 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] Improve layout of event page dialog a bit
Change 935172 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] More layout improvements for the "more details" dialog
Change 935175 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] Rewrite "more details" dialog section with header elements
Change 934561 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Improve layout of event page dialog a bit
Change 935172 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] More layout improvements for the "more details" dialog
Change 935175 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Rewrite "more details" dialog section with header elements
Change 952456 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] Fix color of location headers in "more details" dialog
I would call this ready for QA once the patch above is merged. There are a few inconsistencies with the prototypes that are intentional and that I'm documenting here:
And finally, the inline labels "organized by" and "timezone" are different than the prototype w.r.t. color and, for organizers, font weight. This would be a bigger change because of i18n, so I'd rather create a new task for it.
Change 952456 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Fix color of location headers in "more details" dialog
(Reminder of what I wrote in T322962#9120366, and that as we all previously discussed, any new issues should have their own task(s))
And finally, the inline labels "organized by" and "timezone" are different than the prototype w.r.t. color and, for organizers, font weight. This would be a bigger change because of i18n, so I'd rather create a new task for it.
T345200 is created for this. Moving to design sign off.
Since a task has already been created for the changes, I would move this to product sign-off