Page MenuHomePhabricator
Create Task
Maniphest T323332

Remove jQuery.UI from Extension:Translate or use a local version
Closed, ResolvedPublic8 Estimated Story PointsBUG REPORT
Actions

Assigned To
abi_
Authored By
Jdlrobson
Nov 17 2022, 10:34 PM
Tags
Referenced Files
F37642955: image.png
Aug 30 2023, 2:51 PM
F37642953: image.png
Aug 30 2023, 2:51 PM
F37145670: image.png
Jul 21 2023, 4:24 PM
Subscribers
Aklapper
Jdforrester-WMF
Jdlrobson
Tacsipacsi
Tokens
"Love" token, awarded by Jdlrobson.

Description

jQuery UI has been deprecated since 2017 and is now end of life.

Please help us migrate away from it in MediaWiki core by working out the migration path for this code.

jquery.ui is used in the following modules :

  • ext.translate.groupselector - https://jqueryui.com/position/#default - Used a local copy of jquery.position with tweaks
  • ext.translate.special.aggregategroups - https://jqueryui.com/autocomplete/ - Used OOUI entity.selector
  • ext.translate.special.importtranslations - Does not appear to be used. I think can be safely removed
  • ext.translate.special.managetranslatorsandbox - Does not appear to be used. Can be safely removed.
  • ext.translate.special.searchtranslations.operatorsuggest - Removed and added a hint at the bottom of the control

Details

SubjectRepoBranchLines +/-
GroupSelector: Use jquery.ui.position to remove jquery.ui dependencymediawiki/extensions/Translatemaster+338 -3
SearchTranslations: Remove autocomplete for operator suggestionsmediawiki/extensions/Translatemaster+14 -51
AggregateGroupsSpecialPage: Use entity.selector to select groupsmediawiki/extensions/Translatemaster+130 -105
ManageTranslatorSandbox: Remove jQuery.uimediawiki/extensions/Translatemaster+0 -1
ImportTranslations: Remove jQuery.ui dependencymediawiki/extensions/Translatemaster+0 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Nov 17 2022, 10:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2022, 10:34 PM
Jdlrobson mentioned this in T49145: Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core.Nov 17 2022, 10:35 PM
Jdlrobson added a parent task: T49145: Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core.
Jdlrobson moved this task from Backlog to jquery.ui on the MediaWiki-User-Interface (deprecated JS libraries) board.Nov 21 2022, 4:53 PM
Jdforrester-WMF subscribed.Nov 21 2022, 4:55 PM

or use a local version

Surely if we're saying it's EOL then the Security risk rating for maintaining a local version would not be acceptable?

Jdlrobson added a comment.Nov 21 2022, 5:00 PM

Surely if we're saying it's EOL then the Security risk rating for maintaining a local version would not be acceptable?

Correct, but could be useful as a short term measure to migrate away at own pace.

Nikerabbit triaged this task as Medium priority.May 22 2023, 11:49 AM
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.
Pginer-WMF added a project: Language-Team (Language-2023-April-June).Jun 6 2023, 9:47 AM
abi_ updated the task description. (Show Details)Jun 14 2023, 7:13 AM
abi_ set the point value for this task to 4.
gerritbot added a comment.Jun 14 2023, 7:33 AM

Change 929957 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] ManageTranslatorSandbox: Remove jQuery.ui

https://gerrit.wikimedia.org/r/929957

gerritbot added a project: Patch-For-Review.Jun 14 2023, 7:33 AM
abi_ claimed this task.Jun 14 2023, 7:34 AM
abi_ moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2023-April-June) board.
gerritbot added a comment.Jun 14 2023, 7:38 AM

Change 929959 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] ImportTranslations: Remove jQuery.ui dependency

https://gerrit.wikimedia.org/r/929959

abi_ updated the task description. (Show Details)Jun 14 2023, 8:19 AM
abi_ changed the point value for this task from 4 to 8.
gerritbot added a comment.Jun 19 2023, 5:33 PM

Change 931305 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] AggregateGroupsSpecialPage: Use entity.selector to select groups

https://gerrit.wikimedia.org/r/931305

gerritbot added a comment.Jun 21 2023, 12:52 PM

Change 929959 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] ImportTranslations: Remove jQuery.ui dependency

https://gerrit.wikimedia.org/r/929959

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 21 2023, 1:00 PM
gerritbot added a comment.Jun 21 2023, 1:48 PM

Change 929957 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] ManageTranslatorSandbox: Remove jQuery.ui

https://gerrit.wikimedia.org/r/929957

Jdlrobson awarded a token.Jun 21 2023, 6:11 PM
Pginer-WMF edited projects, added Language-Team (Language-2023-July-September); removed Language-Team (Language-2023-April-June).Jun 30 2023, 11:46 AM
Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2023-July-September) board.
abi_ updated the task description. (Show Details)Jul 4 2023, 4:32 AM
Nikerabbit added a project: Localization Infrastructure FY2023-24.Jul 4 2023, 7:38 AM
Nikerabbit moved this task from Backlog to Support (LM) on the Localization Infrastructure FY2023-24 board.Jul 4 2023, 7:41 AM
Nikerabbit changed the task status from Open to In Progress.Jul 4 2023, 8:41 AM
gerritbot added a comment.Jul 20 2023, 4:16 AM

Change 939792 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] GroupSelector: Use jquery.ui.position to remove jquery.ui dependency

https://gerrit.wikimedia.org/r/939792

gerritbot added a comment.Jul 21 2023, 4:20 PM

Change 940389 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] SearchTranslation: Remove autocomplete for operator suggestions

https://gerrit.wikimedia.org/r/940389

abi_ added a comment.Jul 21 2023, 4:24 PM

To remove jquery.ui from the SearchTranslations page, I've removed the autocomplete that was being used for suggestion operators. Instead I added a help message under the search input.

See image below:

image.png (396×729 px, 29 KB)

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2023-July-September) board.Jul 21 2023, 4:24 PM
gerritbot added a comment.Jul 31 2023, 12:38 PM

Change 931305 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] AggregateGroupsSpecialPage: Use entity.selector to select groups

https://gerrit.wikimedia.org/r/931305

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.20; 2023-08-01); removed MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jul 31 2023, 1:00 PM
gerritbot added a comment.Aug 2 2023, 1:30 PM

Change 940389 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] SearchTranslations: Remove autocomplete for operator suggestions

https://gerrit.wikimedia.org/r/940389

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Aug 2 2023, 2:00 PM
abi_ updated the task description. (Show Details)Aug 22 2023, 9:46 AM
gerritbot added a comment.Aug 29 2023, 2:44 PM

Change 939792 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] GroupSelector: Use jquery.ui.position to remove jquery.ui dependency

https://gerrit.wikimedia.org/r/939792

Maintenance_bot removed a project: Patch-For-Review.Aug 29 2023, 3:11 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.25; 2023-09-05); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 30 2023, 5:01 AM
abi_ updated the task description. (Show Details)Aug 30 2023, 2:49 PM
abi_ moved this task from In Review to Done on the Language-Team (Language-2023-July-September) board.Aug 30 2023, 2:51 PM

We've removed the usage of jQuery.ui in the group selector component. This is deployed on translatewiki.net and tested:

On translatewiki main page:

image.png (691×1 px, 167 KB)

On Special:Translate:

image.png (657×744 px, 44 KB)

abi_ closed this task as Resolved.Aug 30 2023, 2:51 PM
Tacsipacsi subscribed.Aug 31 2023, 3:30 PM

@abi_ You said in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/939792/comments/5dd59da3_2a99a05f that using the copy of jQuery.UI is only a stopgap solution. Since you closed this task as resolved, what other task tracks replacing it with a permanent solution?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL