Page MenuHomePhabricator
Create Task
Maniphest T323883

Adding maintenance tag to page with {{Multiple issues}} should place new tag inside {{Multiple issues}}
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Create a test page
  • Use PageTriage to tag it with two maintenance tags
  • Submit
  • Use PageTriage to tag it with a third (different) maintenance tag
  • Submit

What happens?:

image.png (640×315 px, 19 KB)

What should have happened instead?:

image.png (652×271 px, 19 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
toolbar: include previous tags in the new wrapper when adding new tagsApehitkeymediawiki/extensions/PageTriagemaster+830 -49
toolbar: include previous tags in the new wrapper when adding new tagsApehitkeymediawiki/extensions/PageTriagemaster+721 -44
Fix delete.js breakages due to recent tagging changesSohom Dattamediawiki/extensions/PageTriagemaster+39 -17
Prevent tag wrapper from being duplicatedSohom Dattamediawiki/extensions/PageTriagemaster+362 -209
Customize query in gerrit

Related Objects

Event Timeline

Novem_Linguae created this task.Nov 28 2022, 5:42 AM
Herald added a project: Growth-Team. · View Herald TranscriptNov 28 2022, 5:42 AM
Herald added a subscriber: Aklapper. · View Herald Transcript
Novem_Linguae moved this task from Backlog to Priority bugs on the PageTriage board.Nov 28 2022, 5:43 AM
Sgs moved this task from Inbox to Triaged on the Growth-Team board.Nov 30 2022, 11:23 AM
MPGuy2824 subscribed.Mar 4 2023, 6:13 AM

Also for {{Redirect category shell}}

Novem_Linguae mentioned this in T331187: Adding maintenance tag to redirect with {{Redirect category shell}} should place new tag inside {{Redirect category shell}}.Mar 4 2023, 6:38 AM
Samwalton9-WMF added a project: Moderator-Tools-Team (Kanban).Apr 24 2023, 6:50 PM
Samwalton9-WMF edited projects, added: Moderator-Tools-Team; removed: Moderator-Tools-Team (Kanban).Jun 13 2023, 4:19 PM
Samwalton9-WMF subscribed.

We were going to work on this but have decided to backlog for now as the fix lives in JS and we're going to rewrite the JS in Vue before too long anyway.

Samwalton9-WMF moved this task from Inbox to PageTriage on the Moderator-Tools-Team board.Jun 13 2023, 4:19 PM
Novem_Linguae mentioned this in T343860: {{Redirect category shell}} is duplicated when placing redirect tags.Aug 8 2023, 10:02 PM
Soda merged a task: T347134: PageTriage: Duplicate tagging in {{Multiple issues}}.Sep 22 2023, 7:19 AM
Soda mentioned this in T347134: PageTriage: Duplicate tagging in {{Multiple issues}}.
Soda added a subscriber: Max.
gerritbot added a comment.Oct 13 2023, 9:10 AM

Change 965671 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Prevent tag wrapper from being duplicated

https://gerrit.wikimedia.org/r/965671

gerritbot added a project: Patch-For-Review.Oct 13 2023, 9:10 AM
Soda claimed this task.Oct 13 2023, 9:54 AM
Soda moved this task from Priority bugs to Code Review on the PageTriage board.Oct 13 2023, 10:01 AM
Aklapper removed a project: PageTriage.Oct 17 2023, 9:06 PM
Aklapper edited projects, added: PageTriage; removed: Growth-Team.Oct 17 2023, 9:11 PM
gerritbot added a comment.Oct 20 2023, 11:36 PM

Change 965671 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Prevent tag wrapper from being duplicated

https://gerrit.wikimedia.org/r/965671

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2023, 12:10 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 21 2023, 2:00 AM
gerritbot added a comment.Oct 23 2023, 11:23 AM

Change 967885 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Fix delete.js breakages due to recent tagging changes

https://gerrit.wikimedia.org/r/967885

gerritbot added a project: Patch-For-Review.Oct 23 2023, 11:23 AM
gerritbot added a comment.Oct 23 2023, 6:21 PM

Change 967885 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Fix delete.js breakages due to recent tagging changes

https://gerrit.wikimedia.org/r/967885

Maintenance_bot removed a project: Patch-For-Review.Oct 23 2023, 6:30 PM
Novem_Linguae moved this task from Code Review to Priority bugs on the PageTriage board.Feb 14 2024, 2:00 AM
Novem_Linguae moved this task from Priority bugs to Tagging wikicode bugs on the PageTriage board.Apr 6 2024, 12:02 AM
Novem_Linguae mentioned this in T361988: Adding multiple maintenance tags to page with one maintenance tag and no {{Multiple issues}} should place old tag inside {{Multiple issues}}.Apr 6 2024, 12:10 AM
Samwalton9-WMF moved this task from PageTriage to Triaged on the Moderator-Tools-Team board.Apr 8 2024, 11:30 AM
Soda removed Soda as the assignee of this task.May 16 2024, 5:28 AM
Soda subscribed.
Monkeysmashingkeyboards claimed this task.Wed, Sep 9, 9:02 PM
Monkeysmashingkeyboards subscribed.

I'm going to claim all the wikicode tagging bugs since I recently "rewrote" (stole Novem's code) the toolbar tagging logic. I will hopefully be done with all of them in at most a week.

Monkeysmashingkeyboards added a comment.Wed, Sep 9, 9:17 PM

This should be fixed by the same patch that fixed T346399, though I'm not going to close until I get back home and verify.

Monkeysmashingkeyboards added a comment.Wed, Sep 9, 11:30 PM

Nope, can reproduce. Will submit a patch soon.

gerritbot added a comment.Thu, Sep 10, 1:45 AM

Change #1338368 had a related patch set uploaded (by Apehitkey; author: Apehitkey):

[mediawiki/extensions/PageTriage@master] toolbar: include preexisting tags in the new {{multiple issues}} when adding new tags

https://gerrit.wikimedia.org/r/1338368

gerritbot added a project: Patch-For-Review.Thu, Sep 10, 1:45 AM
Monkeysmashingkeyboards moved this task from Triaged to Code review requests on the Moderator-Tools-Team board.Fri, Sep 11, 3:31 PM
gerritbot added a comment.Mon, Sep 14, 11:42 PM

Change #1341411 had a related patch set uploaded (by Apehitkey; author: Apehitkey):

[mediawiki/extensions/PageTriage@master] toolbar: include previous tags in the new wrapper when adding new tags

https://gerrit.wikimedia.org/r/1341411

gerritbot added a comment.Mon, Sep 14, 11:44 PM

Change #1338368 abandoned by Apehitkey:

[mediawiki/extensions/PageTriage@master] toolbar: include previous tags in the new wrapper when adding new tags

Reason:

Replaced by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/1341411

https://gerrit.wikimedia.org/r/1338368

jsn.sherman edited projects, added: Moderator-Tools-Team (Kanban); removed: Moderator-Tools-Team.Tue, Sep 22, 4:24 PM
jsn.sherman moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.Tue, Sep 22, 4:26 PM
MusikAnimal moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Thu, Sep 24, 12:14 AM
Bugreporter2 awarded a token.Thu, Sep 24, 12:25 AM
MusikAnimal moved this task from Reviewed (waiting for changes) to QA on the Moderator-Tools-Team (Kanban) board.Fri, Sep 25, 9:12 PM
gerritbot added a comment.Fri, Sep 25, 9:20 PM

Change #1341411 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] toolbar: include previous tags in the new wrapper when adding new tags

https://gerrit.wikimedia.org/r/1341411

Maintenance_bot removed a project: Patch-For-Review.Fri, Sep 25, 9:31 PM
Monkeysmashingkeyboards closed this task as Resolved.Sat, Sep 26, 12:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits