Page MenuHomePhabricator

Have wikiphabot follow the same channel announce rules as wikibugs
Closed, ResolvedPublic

Description

wikiphabot should import/respect the rules we've written over the years for wikibugs (what bug updates go to which channels).

Details

Reference
fl504
TitleReferenceAuthorSource BranchDest Branch
Resolve generic types ephemerally.repos/abstract-wiki/wikifunctions/function-orchestrator!144apineapine-ephemeralmain
maintain-kubeusers: document existing quotasrepos/cloud/toolforge/toolforge-deploy!132taavitaavi/maintain-kubeusers-quotasmain
La la labrennen/test!14brennentest-webhook-2022-04-14main
make-release: Start branching RealMerepos/releng/release!18taavitaavi/realmemain
Draft: Mr widget/1brennen/test!13brennenmr-widget/1main
Draft: Mr widget/2brennen/test!12brennenmr-widget/2main
Draft: Mr widget/3brennen/test!11brennenmr-widget/3main
Draft: Mr widget/4brennen/test!10brennenmr-widget/4main
Draft: Mr widget/5brennen/test!9brennenmr-widget/5main
Draft: Mr widget/6brennen/test!8brennenmr-widget/6main
Draft: Mr widget/7brennen/test!7brennenmr-widget/7main
GitLabPatchesCustomField: limit searching to only the Tnnn formrepos/phabricator/extensions!3brennensearch-only-t-formatwmf/stable
test-scap-backport shared change_id testsrepos/releng/train-dev!10jhuneidiT323277main
config template: add gitlab_api_keyrepos/phabricator/deployment!2brennenwork/gitlab-api-keywmf/stable
add GitLabPatchesCustomField to display merge requests that mention a taskrepos/phabricator/extensions!1brennenreview/brennen/mr-widgetwmf/stable
Scap backport: Request dependencies for a specific changerepos/releng/scap!72jhuneidiT323277master
Add analytics webrequest and pageview actor dagsrepos/data-engineering/airflow-dags!223joalwebrequest_actormain
Test change.. disregardrepos/releng/scap!67dancyreview/dancy/testingmaster
Add link to WIP documentationrepos/data-engineering/eventutilities-python!11gmodenaadd-doc-linkmain
Emit sideoutput stream to stdoutrepos/data-engineering/eventutilities-python!7gmodenasideoutput-loggingmain
Show related patches Customize query in GitLab

Event Timeline

flimport raised the priority of this task from to Medium.Sep 12 2014, 1:44 AM
flimport set Reference to fl504.

Nemo_bis wrote on 2014-07-25 14:15:41 (UTC)

"Over the years" is actually just few months ;-) everything used to go to MediaWiki-General till recently.

Where are these "rules we've written over the years for wikibugs (what bug updates go to which channels)" currently stored / can be seen?

valhallasw set Security to None.
valhallasw added a subscriber: Unknown Object (MLST).

Naming of tags will be: (from T43#5660)

Bugzilla productBugzilla componentPhabricator project
MediaWikiChange taggingMediaWiki-Change_tagging
MediaWiki‑Vagrantlabs-vagrantMediaWiki_Vagrant-labs_vagrant
WikimediaGit/GerritWikimedia-Git_and_Gerrit
Wiki Loves MonumentsUnused imagesWiki_Loves_Monuments-Unused_images

I think it would make more sense to configure this directly in phabricator:

We could add a custom field to projects called "irc channel" which would be used to associate a project with a channel.
Then any updates to tickets in a given project would get posted into the relevant irc channel automatically.

In addition to this it would be nice if we had a way to specify the types of notifications that get filtered, on a channel-by-channel basis, but for starters a simple project filter would suffice.

Testing to see if this comment goes into the right channel!

Well, that didn't work. https://github.com/legoktm/phabricator/commit/7b93dd1bb9eae1a350e52d691a2ddfbaddc44dac is how far I got.

I'm not really sure if it's a good idea to hack on the code directly or if there's a preferred way to extend it.

The IRC bot code is 'work in progress' according to the Phab team, so I presume they would be happy to accept patches that improve the bot output (as long as it's configurable).

Naming of tags will be: (from T43#5660)

Bugzilla productBugzilla componentPhabricator project
MediaWikiChange taggingMediaWiki-Change_tagging
MediaWiki‑Vagrantlabs-vagrantMediaWiki_Vagrant-labs_vagrant
WikimediaGit/GerritWikimedia-Git_and_Gerrit
Wiki Loves MonumentsUnused imagesWiki_Loves_Monuments-Unused_images

I'm confused by this comment. Are tag names relevant here? Programmatic access should happen via IDs, I thought.

@Legoktm one way to approach this would be to fork the message handler class ( or subclass/extend it ), that way our changes are mostly isolated to a separate file and hopefully don't cause too much maintenance headaches if we have to maintain our own custom handler outside of the upstream.

Re-opening as this is really a subtask of T131.

See

https://github.com/legoktm/wikibugs2/blob/master/channels.yaml

for the format, although those do not seem to be the current rules. In any case, the actual rules should be in git before Day 1.