wikiphabot should import/respect the rules we've written over the years for wikibugs (what bug updates go to which channels).
Description
Details
- Reference
- fl504
Reference | Source Branch | Dest Branch | Author | Title | |
---|---|---|---|---|---|
brennen/test!13 | mr-widget/1 | main | brennen | Draft: Mr widget/1 | |
brennen/test!12 | mr-widget/2 | main | brennen | Draft: Mr widget/2 | |
brennen/test!11 | mr-widget/3 | main | brennen | Draft: Mr widget/3 | |
brennen/test!10 | mr-widget/4 | main | brennen | Draft: Mr widget/4 | |
brennen/test!9 | mr-widget/5 | main | brennen | Draft: Mr widget/5 | |
brennen/test!8 | mr-widget/6 | main | brennen | Draft: Mr widget/6 | |
brennen/test!7 | mr-widget/7 | main | brennen | Draft: Mr widget/7 | |
repos/phabricator/extensions!3 | search-only-t-format | wmf/stable | brennen | GitLabPatchesCustomField: limit searching to only the Tnnn form | |
repos/releng/train-dev!10 | T323277 | main | jhuneidi | test-scap-backport shared change_id tests | |
brennen/test!6 | moretext | main | brennen | Update README.md with more text. | |
repos/phabricator/deployment!2 | work/gitlab-api-key | wmf/stable | brennen | config template: add gitlab_api_key | |
repos/phabricator/extensions!1 | review/brennen/mr-widget | wmf/stable | brennen | add GitLabPatchesCustomField to display merge requests that mention a task | |
repos/releng/scap!72 | T323277 | master | jhuneidi | Scap backport: Request dependencies for a specific change | |
repos/data-engineering/airflow-dags!223 | webrequest_actor | main | joal | Add analytics webrequest and pageview actor dags | |
repos/releng/scap!67 | review/dancy/testing | master | dancy | Test change.. disregard | |
repos/data-engineering/eventutilities-python!11 | add-doc-link | main | gmodena | Add link to WIP documentation | |
repos/data-engineering/eventutilities-python!7 | sideoutput-logging | main | gmodena | Emit sideoutput stream to stdout | |
repos/data-engineering/eventutilities-python!4 | add-rowtype-info | main | gmodena | Initial effort to add row_type_info | |
repos/data-engineering/eventutilities-python!3 | T324951-test-utils | main | gmodena | Improve support for local development. | |
repos/releng/gitlab-phabricator!9 | review/brennen/mr-update | main | brennen | WIP: handle updated merge requests |
Status | Subtype | Assigned | Task | |
---|---|---|---|---|
· · · | ||||
Resolved | yuvipanda | T131 IRC bot to report Phabricator activity exactly like Wikibugs does with Bugzilla | ||
Resolved | valhallasw | T324 Have wikiphabot follow the same channel announce rules as wikibugs | ||
· · · |
Event Timeline
Nemo_bis wrote on 2014-07-25 14:15:41 (UTC)
"Over the years" is actually just few months ;-) everything used to go to MediaWiki-General till recently.
Where are these "rules we've written over the years for wikibugs (what bug updates go to which channels)" currently stored / can be seen?
If we decide this is the way to go: https://github.com/wikimedia/labs-tools-pywikibugs/blob/master/channels.py
Naming of tags will be: (from T43#5660)
Bugzilla product | Bugzilla component | Phabricator project |
MediaWiki | Change tagging | MediaWiki-Change_tagging |
MediaWiki‑Vagrant | labs-vagrant | MediaWiki_Vagrant-labs_vagrant |
Wikimedia | Git/Gerrit | Wikimedia-Git_and_Gerrit |
Wiki Loves Monuments | Unused images | Wiki_Loves_Monuments-Unused_images |
I think it would make more sense to configure this directly in phabricator:
We could add a custom field to projects called "irc channel" which would be used to associate a project with a channel.
Then any updates to tickets in a given project would get posted into the relevant irc channel automatically.
In addition to this it would be nice if we had a way to specify the types of notifications that get filtered, on a channel-by-channel basis, but for starters a simple project filter would suffice.
Would this approach also help fixing T763: Phabricator far too spammy and off-topic to continue posting to wikibugs-l?
Well, that didn't work. https://github.com/legoktm/phabricator/commit/7b93dd1bb9eae1a350e52d691a2ddfbaddc44dac is how far I got.
I'm not really sure if it's a good idea to hack on the code directly or if there's a preferred way to extend it.
The IRC bot code is 'work in progress' according to the Phab team, so I presume they would be happy to accept patches that improve the bot output (as long as it's configurable).
I'm confused by this comment. Are tag names relevant here? Programmatic access should happen via IDs, I thought.
@Legoktm one way to approach this would be to fork the message handler class ( or subclass/extend it ), that way our changes are mostly isolated to a separate file and hopefully don't cause too much maintenance headaches if we have to maintain our own custom handler outside of the upstream.
See
https://github.com/legoktm/wikibugs2/blob/master/channels.yaml
for the format, although those do not seem to be the current rules. In any case, the actual rules should be in git before Day 1.
Resolved in https://github.com/legoktm/wikibugs2/commit/7ef9a5f08a9ef1a48ac2288702de98fd0c4974d3 and the few previous commits.