In T312309#8394540, @Ryasmeen wrote:The interface looks good to me. However, there are some issues with the way it behaves for the special case: when a talk page has a lede section that contains Reply buttons as @matmarex mentioned below:
In T312309#8388224, @matmarex wrote:Known issues:
- When the lede section contains reply buttons, you can still use them from the popup, which mostly works but it's buggy in funny ways. I'm not sure what we should do about it. What if we just displayed the lede section normally, like in articles, if it contained any comments?
(…)
The issues are:
- When you click on the Reply link from within this new pop-up, it doesn't scroll all the way down to the bottom of the pop-up where the Reply tool has opened.
- Once you post a reply from within this pop-up, it doesn't show the newly posted comment in the same session unless you refresh the page and click on ℹ Learn more about this page and re-open this pop-up.
- Also after posting a comment from within this pop-up, the Reply tool doesn't open the next time. If you click on it, it throws the following JS error:
Uncaught TypeError: Cannot read properties of null (reading 'ownerDocument')
Description
Description
Details
Details
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 862322 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Don't collapse the lede section when it has comments
Comment Actions
It might be interesting to get a maintenance category or something for this case, at least on en.wp it's non-idiomatic to have comments without a section head. I expect most wikis work like that. This is a local case where it's idiomatic, but I don't think that would be a big deal there?
Comment Actions
I agree that it's non-idiomatic. However, we're not trying to push people to change talk page content to avoid it. However, if it's something you're interested in, give me a name for that tracking category and I'll be happy to add it.
Comment Actions
Category:Talk pages with comments in the first section or ...before the first section? I kind of anticipate it getting overwritten anyway onwiki for namespace support and possibly ROOTPAGENAME for e.g. the Signpost cases. If that's possible with system tracking categories, I don't remember.
Comment Actions
Change 862322 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Don't collapse the lede section when it has comments
Comment Actions
We had a short discussion in a team meeting yesterday and a few folks were worried that people on other projects would be annoyed to be nagged about this, so I'm going to add the code to do this, but keep it disabled by default, and you'll need to override a MediaWiki: namespace message to enable it on English Wikipedia.
Comment Actions
That works for me. Will it show up in https://en.wikipedia.org/wiki/Special:TrackingCategories ? (I ask this half as a "consider if you haven't whether that's possible" and half as a "just checking")
Comment Actions
I think so, I haven't checked how exactly tracking categories work, but I'm going to look how other extensions do it and do the same thing. I think there's some nice method to define them.
Comment Actions
Change 865780 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Add optional tracking category for comments in the lede section (before first heading)
Comment Actions
Thanks for the link to Special:TrackingCategories by the way, I didn't realize we had that special page, and it was helpful in figuring out the conventions to follow.
Comment Actions
Change 865780 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Add optional tracking category for comments in the lede section (before first heading)