Page MenuHomePhabricator
Create Task
Maniphest T324930

NewImpact: Cannot read properties of undefined (reading 'days')
Closed, ResolvedPublicBUG REPORT
Actions

Description

From the JS error logs: NewImpact: Cannot read properties of undefined (reading 'days') (184 last week), triggered by access to Proxy.longestEditingStreakCount

Steps to reproduce:

On mobile:

  • Register a new account
  • Make the first edit of the account on a non-mainspace edit eg: UserPage
  • Navigate to the newcomers homepage

What happens:
The "Last edited" fields shows 53 years ago. The "Longest streak" shows empty as opposite of using the no data character ....

What should happen:
Show the no data character for both data fields ...

Screenshot 2023-02-09 at 19.15.40.png (512×1 px, 51 KB)

See code review comments

Details

SubjectRepoBranchLines +/-
ImpactHooks: Refresh impact for any namespacemediawiki/extensions/GrowthExperimentsmaster+1 -2
NewImpact: More defensive check for longestEditingStreak.datePeriod.daysmediawiki/extensions/GrowthExperimentsmaster+5 -1
User impact: read edit count from primary db in save complete hookmediawiki/extensions/GrowthExperimentswmf/1.40.0-wmf.14+57 -20
User impact: read edit count from primary db in save complete hookmediawiki/extensions/GrowthExperimentsmaster+57 -20
[WIP] New impact: assume the user has edited when onPageSaveComplete is calledmediawiki/extensions/GrowthExperimentsmaster+4 -7
[WIP] User impact: read from primary db on post save hookmediawiki/extensions/GrowthExperimentsmaster+53 -19
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Dec 12 2022, 4:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 12 2022, 4:49 AM
Tgr updated the task description. (Show Details)Dec 12 2022, 4:49 AM
Sgs claimed this task.Dec 12 2022, 1:10 PM
Sgs moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh triaged this task as High priority.Dec 13 2022, 9:34 AM
kostajh subscribed.

We will want to backport the fix this week. It is happening because we are querying the replica DB in ImpactHooks.php, and we need to query the primary DB instead.

gerritbot added a comment.Dec 13 2022, 1:32 PM

Change 867585 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] [WIP] User impact: read from primary db on post save hook

https://gerrit.wikimedia.org/r/867585

gerritbot added a project: Patch-For-Review.Dec 13 2022, 1:32 PM
Sgs added a comment.Dec 13 2022, 1:41 PM

I can consistently reproduce the issue (no matter what type of task) on a user’s first edit using a db replica setup. I think the problem might be in ImpactHooks::userIsInImpactDataCohort

$lastEditTimestamp = $this->userEditTracker->getLatestEditTimestamp( $userIdentity );
if ( !$lastEditTimestamp ) {
  return false;
}

userEditTracker->getLatestEditTimestamp() seems to use the replica db and return false. Since we’re only calling this from an onPageSaveComplete hook maybe it’s fine to assume the user has indeed edited.

gerritbot added a comment.Dec 13 2022, 1:44 PM

Change 867593 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] [WIP] New impact: assume the user has edited when onPageSaveComplete is called

https://gerrit.wikimedia.org/r/867593

gerritbot added a comment.Dec 13 2022, 4:56 PM

Change 867674 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] User impact: read edit count from primary db in save complete hook

https://gerrit.wikimedia.org/r/867674

gerritbot added a comment.Dec 13 2022, 4:57 PM

Change 867585 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@master] [WIP] User impact: read from primary db on post save hook

Reason:

Re-worked in I6bd0daf5e77ca5f1ff82983f830bb01f3acab9cd

https://gerrit.wikimedia.org/r/867585

gerritbot added a comment.Dec 13 2022, 4:57 PM

Change 867593 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@master] [WIP] New impact: assume the user has edited when onPageSaveComplete is called

Reason:

Re-worked I6bd0daf5e77ca5f1ff82983f830bb01f3acab9cd

https://gerrit.wikimedia.org/r/867593

Tgr mentioned this in T323253: NewImpact module: Page view data should be limited to when user made their first edit.Dec 14 2022, 2:08 AM
Sgs changed the task status from Open to In Progress.Dec 14 2022, 10:57 AM
Sgs moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Dec 14 2022, 11:15 AM

Change 867674 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] User impact: read edit count from primary db in save complete hook

https://gerrit.wikimedia.org/r/867674

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2022, 11:30 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 14 2022, 12:01 PM
gerritbot added a comment.Dec 14 2022, 8:00 PM

Change 868052 had a related patch set uploaded (by Gergő Tisza; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.14] User impact: read edit count from primary db in save complete hook

https://gerrit.wikimedia.org/r/868052

gerritbot added a project: Patch-For-Review.Dec 14 2022, 8:00 PM
gerritbot added a comment.Dec 14 2022, 11:20 PM

Change 868052 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.40.0-wmf.14] User impact: read edit count from primary db in save complete hook

https://gerrit.wikimedia.org/r/868052

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2022, 11:30 PM
Stashbot added a comment.Dec 15 2022, 12:05 AM

Mentioned in SAL (#wikimedia-operations) [2022-12-15T00:05:06Z] <tgr@deploy1002> Synchronized php-1.40.0-wmf.14/extensions/GrowthExperiments/: Backport: [[gerrit:868052|User impact: read edit count from primary db in save complete hook (T324930)]] (duration: 07m 03s)

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.14; 2022-12-12); removed MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 15 2022, 2:01 AM
Etonkovidova closed this task as Resolved.Dec 15 2022, 8:03 PM
Etonkovidova subscribed.

Last timestamp Dec 15, 2022 @ 02:24:43.193 - the logstash link.

Sgs moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.EditedJan 19 2023, 12:59 PM

Still seeing this in 1.40.0-wmf.19 see logstash. I think this should be fixed when gerrit 860987 lands in production since it adds a defensive check for the longestEditingStreakCount but better keep an eye. Same for the error this.data.longestEditingStreak.datePeriod is undefined (logstash).

Etonkovidova added a comment.Jan 21 2023, 2:35 AM
In T324930#8540139, @Sgs wrote:

Still seeing this in 1.40.0-wmf.19 see logstash. I think this should be fixed when gerrit 860987 lands in production since it adds a defensive check for the longestEditingStreakCount but better keep an eye. Same for the error this.data.longestEditingStreak.datePeriod is undefined (logstash).

Thx, @Sgs - I noticed it too. I'll monitor for few days.

Tgr merged a task: T328092: Cannot read properties of undefined (reading 'days').Jan 27 2023, 2:53 AM
Tgr added subscribers: Jdlrobson, Masumrezarock100.
Etonkovidova added a comment.Feb 1 2023, 5:51 PM

Last 7 days - logstash for wmf.20 shows 11 errors (the last timestamp Jan 31, 2023 @ 13:29:33.816).

Etonkovidova reopened this task as Open.Feb 3 2023, 4:21 PM

Re-opened - there seems to be a spike after wmf.21 deployment - logstash wmf.21 - 134 errors (the last timestamp - Feb 3, 2023 @ 16:13:53.597.

gerritbot added a comment.Feb 8 2023, 11:09 AM

Change 887766 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] NewImpact: More defensive check for longestEditingStreak.datePeriod.days

https://gerrit.wikimedia.org/r/887766

gerritbot added a project: Patch-For-Review.Feb 8 2023, 11:09 AM
kostajh claimed this task.Feb 8 2023, 11:10 AM
kostajh moved this task from QA to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh added a subscriber: Sgs.
thcipriani moved this task from Untriaged to Dec 2022 on the Wikimedia-production-error board.Feb 9 2023, 4:48 PM
Sgs updated the task description. (Show Details)Feb 9 2023, 6:20 PM
Sgs updated the task description. (Show Details)Feb 9 2023, 6:28 PM
Tgr mentioned this in T330614: New Impact module's empty state on mobile: research spike.Feb 28 2023, 12:35 AM
gerritbot added a comment.Feb 28 2023, 9:21 AM

Change 892897 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] ImpactHooks: Refresh impact for any namespace

https://gerrit.wikimedia.org/r/892897

gerritbot added a comment.Feb 28 2023, 9:21 AM

Change 887766 abandoned by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@master] NewImpact: More defensive check for longestEditingStreak.datePeriod.days

Reason:

Dropped in favor of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/892897

https://gerrit.wikimedia.org/r/887766

gerritbot added a comment.Feb 28 2023, 11:18 AM

Change 892897 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ImpactHooks: Refresh impact for any namespace

https://gerrit.wikimedia.org/r/892897

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 28 2023, 11:19 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 28 2023, 11:30 AM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.26; 2023-03-06); removed MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Feb 28 2023, 12:00 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 3 2023, 2:04 AM
Etonkovidova added a comment.EditedMar 10 2023, 12:00 AM

As of March 09 23:59 UTC there were 22 errors in logstash in 24 hours - I'll recheck tomorrow to see if the rate is even lower.

Checked - the rate is 5 errors - the most recent timestamp Mar 9, 2023 @ 23:16:34.156 {F36905594}

Etonkovidova closed this task as Resolved.Mar 10 2023, 9:22 PM
Sgs added a comment.EditedMar 23 2023, 5:39 PM

Still seeing 27 errors in last 7 days on Special:Homepage 1.40.0-wmf.27. The conditions to reproduce are different though; It seems all the errors are coming from the mobile site. Not sure if we should re-open 887766 or try to find the steps to reproduce it.

kostajh added a comment.Mar 27 2023, 10:07 AM
In T324930#8722229, @Sgs wrote:

Still seeing 27 errors in last 7 days on Special:Homepage 1.40.0-wmf.27. The conditions to reproduce are different though; It seems all the errors are coming from the mobile site. Not sure if we should re-open 887766 or try to find the steps to reproduce it.

Hmm, there are so few, that I am tempted to leave it alone, even if it would be nice to track this down and get the number to zero.

Sgs added a comment.Jun 14 2023, 3:57 PM

Still seeing 53 errors in last 7 days on Special:Homepage 1.41.0-wmf.12. The conditions to reproduce are different though; It seems all the errors are coming from the mobile site. I'll try to track the mobile code path causing this.

Sgs mentioned this in T338647: MentorshipNewImpact: Undefined is not an object (evaluating 'this.data.longestEditingStreak.datePeriod.days').Jun 22 2023, 11:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits