Based on comments in T300273#8411707:
A good opportunity to replace the campaign class with a proper hook.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T327655 Epic: Migration of some GrowthExperiments features into MediaWiki core | |||
| Resolved | Tgr | T325655 Replace SpecialCreateAccountCampaign.php with proper hook |
Event Timeline
Comment Actions
One thing to figure out is that mobile signup page (ie. signup on the Minerva skin) looks very different. For the campaigns landing page we used mostly the same content for both, which might not have been a good idea as it pushes the login form itself below the fold. So the responsibility for formatting the landing page is somewhat split between the extension that wants to provide a custom landing experience for some specific case and the skin.
Comment Actions
Although on second thought I'm not sure we can do much about that. The extension will just have provide a Minerva version if it wants to support that skin well.
Comment Actions
Change 884482 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):
[mediawiki/core@master] Add SpecialCreateAccountsBenefits hook
Comment Actions
Change 884483 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Replace SpecialCreateAccountCampaign.php with proper hook
Comment Actions
Change 884482 merged by jenkins-bot:
[mediawiki/core@master] Add SpecialCreateAccountsBenefits hook
Comment Actions
Change 884483 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Replace SpecialCreateAccountCampaign.php with proper hook