Page MenuHomePhabricator
Create Task
Maniphest T326405

Make target of desktop-only Wikibase modules explicit
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Currently, many Wikibase modules are implicitly desktop-only because they don’t specify 'targets', whether intentionally or not. As part of work surrounding T324723, the default 'targets' will soon change from [ 'desktop' ] to [ 'desktop', 'mobile' ]; as at least some Wikibase modules are definitely not suitable for mobile, we want to avoid this change applying to Wikibase, and explicitly add 'targets' => [ 'desktop' ] to all Wikibase modules that don’t already specify targets.

Later, some of these modules should be set to desktop+mobile after all, but that will be done separately, and with PM involvement.

Details

SubjectRepoBranchLines +/-
ResourceLoader: Define "desktop" only target for propertySuggester.suggestionsmediawiki/extensions/PropertySuggestermaster+2 -0
Explicitly mark target of modulemediawiki/extensions/PropertySuggestermaster+2 -0
Set explicit targets of most ResourceLoader modulesmediawiki/extensions/WikibaseLexememaster+22 -11
Explicitly set targets of SitesModulemediawiki/extensions/Wikibasemaster+2 -0
Set explicit targets of ResourceLoader modulesmediawiki/extensions/WikibaseQualityConstraintsmaster+10 -1
Explicitly set target on PropertyValueExpertsModulemediawiki/extensions/Wikibasemaster+2 -0
Explicitly set modules as desktop targetedmediawiki/extensions/Wikibasemaster+109 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jan 6 2023, 11:52 AM
Restricted Application added a project: Performance-Team. · View Herald TranscriptJan 6 2023, 11:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lucas_Werkmeister_WMDE added a comment.Jan 6 2023, 11:52 AM

See also T324991: Make Wikibase not rely on the ResourceLoader target system (I’m not sure how these tasks should look in a subtask graph, tbh).

Lucas_Werkmeister_WMDE added a comment.EditedJan 6 2023, 11:55 AM

Later, some of these modules should be set to desktop+mobile after all, but that will be done separately, and with PM involvement.

One random candidate that I found: wikibase.special.languageLabelDescriptionAliases, which is responsible for updating the placeholders on Special:NewItem and Special:NewProperty when you select a different language, works perfectly well on mobile, as far as I can tell. We should probably have a separate “make as many modules desktop+mobile as we can” task later (which might also reduce the amount of T324723 warnings).

Lucas_Werkmeister_WMDE mentioned this in T326428: Make more Wikibase ResourceLoader modules available on mobile as well.Jan 6 2023, 4:26 PM

Later, some of these modules should be set to desktop+mobile after all, but that will be done separately, and with PM involvement.

We should probably have a separate “make as many modules desktop+mobile as we can” task later (which might also reduce the amount of T324723 warnings).

⇒ T326428: Make more Wikibase ResourceLoader modules available on mobile as well

gerritbot added a comment.Jan 6 2023, 6:21 PM

Change 875440 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Wikibase@master] Explicitly set modules as desktop targeted

https://gerrit.wikimedia.org/r/875440

gerritbot added a project: Patch-For-Review.Jan 6 2023, 6:21 PM
Lucas_Werkmeister_WMDE assigned this task to Jdlrobson.Jan 6 2023, 6:29 PM
gerritbot added a comment.Jan 6 2023, 7:09 PM

Change 875440 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Explicitly set modules as desktop targeted

https://gerrit.wikimedia.org/r/875440

Maintenance_bot removed a project: Patch-For-Review.Jan 6 2023, 7:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 6 2023, 8:00 PM
gerritbot added a comment.Jan 6 2023, 8:11 PM

Change 876255 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Wikibase@master] Explicitly set target on PropertyValueExpertsModule

https://gerrit.wikimedia.org/r/876255

gerritbot added a project: Patch-For-Review.Jan 6 2023, 8:11 PM
larissagaulia removed projects: Performance-Team, MediaWiki-ResourceLoader.Jan 12 2023, 7:11 AM
gerritbot added a comment.Jan 13 2023, 11:27 AM

Change 876255 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Explicitly set target on PropertyValueExpertsModule

https://gerrit.wikimedia.org/r/876255

Maintenance_bot removed a project: Patch-For-Review.Jan 13 2023, 11:30 AM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.19; 2023-01-16); removed MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 13 2023, 12:00 PM
gerritbot added a comment.Jan 13 2023, 12:10 PM

Change 879773 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Explicitly set targets of SitesModule

https://gerrit.wikimedia.org/r/879773

gerritbot added a project: Patch-For-Review.Jan 13 2023, 12:10 PM
gerritbot added a comment.Jan 13 2023, 1:29 PM

Change 879785 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Set explicit targets of most ResourceLoader modules

https://gerrit.wikimedia.org/r/879785

gerritbot added a comment.Jan 13 2023, 1:43 PM

Change 879808 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Set explicit targets of ResourceLoader modules

https://gerrit.wikimedia.org/r/879808

gerritbot added a comment.Jan 13 2023, 5:32 PM

Change 879808 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Set explicit targets of ResourceLoader modules

https://gerrit.wikimedia.org/r/879808

Lucas_Werkmeister_WMDE added projects: [DEPRECATED] wdwb-tech, Wikidata Dev Team.Jan 16 2023, 4:38 PM

Adding Wikidata Dev Team for review of the remaining changes.

Lucas_Werkmeister_WMDE added a project: wmde-wikidata-tech.Jan 18 2023, 10:55 AM
Maintenance_bot moved this task from Inbox to Sorted Team A on the [DEPRECATED] wdwb-tech board.Jan 18 2023, 11:15 AM
ItamarWMDE subscribed.Jan 18 2023, 4:18 PM

Task Review / Prio Notes:

  • As this only has patches for review, this will go to the top of the tech backlog, and will be picked up next sprint as per team process.
ItamarWMDE moved this task from Incoming to [DOT] Prioritized on the wmde-wikidata-tech board.Jan 18 2023, 4:18 PM
ItamarWMDE moved this task from Incoming to [DOT] Tech Backlog on the Wikidata Dev Team board.
gerritbot added a comment.Jan 31 2023, 11:37 AM

Change 879773 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Explicitly set targets of SitesModule

https://gerrit.wikimedia.org/r/879773

gerritbot added a comment.Jan 31 2023, 11:38 AM

Change 879785 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Set explicit targets of most ResourceLoader modules

https://gerrit.wikimedia.org/r/879785

Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.Jan 31 2023, 11:46 AM
Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Tech Verification on the Wikidata Dev Team (Sprint-∞) board.
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.22; 2023-02-06); removed MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Jan 31 2023, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 31 2023, 12:30 PM
ItamarWMDE moved this task from [DOT] Prioritized to Ongoing on the wmde-wikidata-tech board.Jan 31 2023, 2:03 PM
HasanAkgun_WMDE subscribed.Jan 31 2023, 3:27 PM

I think everything is merged now.

Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 31 2023, 3:45 PM
Lucas_Werkmeister_WMDE moved this task from Tech Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.
HasanAkgun_WMDE reassigned this task from Jdlrobson to Lucas_Werkmeister_WMDE.Jan 31 2023, 4:09 PM
gerritbot added a comment.Jan 31 2023, 10:29 PM

Change 885432 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/PropertySuggester@master] Explicitly mark target of module

https://gerrit.wikimedia.org/r/885432

gerritbot added a project: Patch-For-Review.Jan 31 2023, 10:29 PM
gerritbot added a comment.Feb 1 2023, 9:22 AM

Change 885735 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PropertySuggester@master] ResourceLoader: Define "desktop" only target for propertySuggester.suggestions

https://gerrit.wikimedia.org/r/885735

gerritbot added a comment.Feb 1 2023, 9:47 AM

Change 885432 merged by jenkins-bot:

[mediawiki/extensions/PropertySuggester@master] Explicitly mark target of module

https://gerrit.wikimedia.org/r/885432

gerritbot added a comment.Feb 1 2023, 10:05 AM

Change 885735 abandoned by Kosta Harlan:

[mediawiki/extensions/PropertySuggester@master] ResourceLoader: Define "desktop" only target for propertySuggester.suggestions

Reason:

See I92e284e5d42568d3bcbdb40a239641bdca09fe7f

https://gerrit.wikimedia.org/r/885735

kostajh mentioned this in rEPSfd079bce9efb: Explicitly mark target of module.Feb 1 2023, 10:06 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 1 2023, 10:31 AM
karapayneWMDE moved this task from Our work done to 2023 completed tasks on the Wikidata Dev Team (Sprint-∞) board.Feb 6 2023, 4:28 PM
karapayneWMDE set the point value for this task to 3.Feb 7 2023, 9:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL