Page MenuHomePhabricator
Create Task
Maniphest T326538

Vector 2022: Username does not display properly in personal tools section when GrowthExperiments enabled
Closed, ResolvedPublic
Actions

Assigned To
kostajh
Authored By
kostajh
Jan 9 2023, 10:26 AM
Tags
Referenced Files
F36078273: Screen Shot 2023-01-09 at 10.54.38 AM.png
Jan 9 2023, 5:55 PM
F36067239: image.png
Jan 9 2023, 10:26 AM
F36067236: image.png
Jan 9 2023, 10:26 AM
F36067234: image.png
Jan 9 2023, 10:26 AM
Subscribers
Aklapper
DLynch
Jdlrobson
kostajh
Nikerabbit
• nray
Tgr

Description

Expected display:

image.png (578×768 px, 41 KB)

Actual (local):

image.png (578×768 px, 22 KB)

Beta:

image.png (578×768 px, 39 KB)

Details

SubjectRepoBranchLines +/-
Revert "Add language settings button inside dropdown for non-content pages"mediawiki/extensions/UniversalLanguageSelectormaster+0 -59
HomepageHooks: Populate user-page from user-menu item datamediawiki/extensions/GrowthExperimentsmaster+3 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Jan 9 2023, 10:26 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 9 2023, 10:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jan 9 2023, 10:27 AM

Change 877106 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] HomepageHooks: Populate user-page from user-menu item data

https://gerrit.wikimedia.org/r/877106

gerritbot added a project: Patch-For-Review.Jan 9 2023, 10:27 AM
Nikerabbit subscribed.Jan 9 2023, 12:23 PM
Tgr subscribed.Jan 9 2023, 4:50 PM
DLynch subscribed.Jan 9 2023, 5:05 PM
kostajh added a project: Web-Team-Backlog.Jan 9 2023, 5:44 PM
• nray subscribed.EditedJan 9 2023, 5:55 PM

This is also getting flagged by our visual regression tests. It must have been a recent change because I didn't notice this last Friday (Jan 6)

Screen Shot 2023-01-09 at 10.54.38 AM.png (968×3 px, 633 KB)

kostajh added a comment.EditedJan 9 2023, 6:04 PM
In T326538#8510325, @nray wrote:

This is also getting flagged by our visual regression tests. It must have been a recent change because I didn't notice this last Friday (Jan 6)

Screen Shot 2023-01-09 at 10.54.38 AM.png (968×3 px, 633 KB)

Tentatively marking this as a blocker to T325581: 1.40.0-wmf.18 deployment blockers, then.

kostajh added a parent task: T325581: 1.40.0-wmf.18 deployment blockers.Jan 9 2023, 6:04 PM
ovasileva triaged this task as High priority.Jan 9 2023, 7:27 PM
ovasileva added a project: Web-Team FY2022-23 Q3 Sprint 1.
Jdlrobson added projects: Language-Team, UniversalLanguageSelector.Jan 9 2023, 8:04 PM
Jdlrobson subscribed.

This appears to have been caused by this change in UniversalLanguageSelector: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/852140

gerritbot added a comment.Jan 9 2023, 8:08 PM

Change 877209 had a related patch set uploaded (by Kosta Harlan; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@master] Revert "Add language settings button inside dropdown for non-content pages"

https://gerrit.wikimedia.org/r/877209

Jdlrobson raised the priority of this task from High to Unbreak Now!.Jan 9 2023, 8:08 PM
gerritbot added a comment.Jan 9 2023, 8:09 PM

Change 877106 abandoned by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@master] HomepageHooks: Populate user-page from user-menu item data

Reason:

See Ie5d079deae414eb199d2a40b98d04b57439eaac4

https://gerrit.wikimedia.org/r/877106

gerritbot added a comment.Jan 9 2023, 8:25 PM

Change 877209 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Revert "Add language settings button inside dropdown for non-content pages"

https://gerrit.wikimedia.org/r/877209

Maintenance_bot removed a project: Patch-For-Review.Jan 9 2023, 8:30 PM
Jdlrobson moved this task from Incoming to Ready for Signoff on the Web-Team FY2022-23 Q3 Sprint 1 board.Jan 9 2023, 8:49 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Jan 9 2023, 9:00 PM
Jdlrobson moved this task from Incoming to Tracking on the Web-Team-Backlog board.Jan 9 2023, 10:27 PM
kostajh closed this task as Resolved.Jan 10 2023, 11:29 AM
kostajh claimed this task.
kostajh mentioned this in T316559: Communicate when pages are not supported in other languages in the current language selector.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL