Page MenuHomePhabricator
Create Task
Maniphest T327469

Subscribe buttons/links are displayed out of place due to new heading HTML structure
Closed, ResolvedPublic
Actions

Description

Subscribe buttons/links are displayed out of place due to new heading HTML structure (T314714). The bug looks like T318872, but this time affects all skins.

Details

SubjectRepoBranchLines +/-
Tweaks for new heading HTML structuremediawiki/extensions/DiscussionToolswmf/1.40.0-wmf.19+28 -2
Tweaks for new heading HTML structuremediawiki/extensions/DiscussionToolsmaster+28 -2
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Jan 20 2023, 4:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2023, 4:28 AM
matmarex claimed this task.Jan 20 2023, 4:28 AM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.
Izno subscribed.Jan 20 2023, 4:53 AM
gerritbot added a comment.Jan 20 2023, 5:24 AM

Change 881747 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Tweaks for new heading HTML structure

https://gerrit.wikimedia.org/r/881747

gerritbot added a project: Patch-For-Review.Jan 20 2023, 5:24 AM
matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Jan 20 2023, 5:28 AM
gerritbot added a comment.Jan 20 2023, 12:50 PM

Change 881747 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Tweaks for new heading HTML structure

https://gerrit.wikimedia.org/r/881747

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 20 2023, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 20 2023, 1:30 PM
gerritbot added a comment.Jan 22 2023, 6:52 PM

Change 882174 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.19] Tweaks for new heading HTML structure

https://gerrit.wikimedia.org/r/882174

gerritbot added a project: Patch-For-Review.Jan 22 2023, 6:52 PM
gerritbot added a comment.Jan 23 2023, 8:12 AM

Change 882174 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.19] Tweaks for new heading HTML structure

https://gerrit.wikimedia.org/r/882174

Stashbot added a comment.Jan 23 2023, 8:12 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-23T08:12:47Z] <ladsgroup@deploy1002> Started scap: Backport for [[gerrit:882174|Tweaks for new heading HTML structure (T327328 T327469)]]

Stashbot mentioned this in T327328: Highlight skips the topic container for new topics, which looks odd.Jan 23 2023, 8:12 AM
Stashbot added a comment.Jan 23 2023, 8:22 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-23T08:22:33Z] <ladsgroup@deploy1002> ladsgroup and matmarex: Backport for [[gerrit:882174|Tweaks for new heading HTML structure (T327328 T327469)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Jan 23 2023, 8:30 AM

Mentioned in SAL (#wikimedia-operations) [2023-01-23T08:30:00Z] <ladsgroup@deploy1002> Finished scap: Backport for [[gerrit:882174|Tweaks for new heading HTML structure (T327328 T327469)]] (duration: 17m 12s)

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2023, 8:30 AM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.19; 2023-01-16); removed MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 23 2023, 9:00 AM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jan 23 2023, 9:10 AM
matmarex added a project: Editing QA.
EAkinloose edited projects, added Verified; removed Editing QA.Jan 24 2023, 4:42 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Jan 26 2023, 4:45 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits