Page MenuHomePhabricator
Create Task
Maniphest T327605

Special:UserRights: changing an already set permission's expiry to any new value fails
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Be an admin
  • Pick a test account to target
  • Visit Special:UserRights for the test account
  • Award it a temporary, expiring permission, such as "extended confirmed user, expires 1 month"
  • Click "save user groups"
  • Visit Special:UserRights for the test account again
  • Change the "expires" dropdown to "does not expire"
  • Click "save user groups"

What happens?:

  • Success popup
  • Permission expiration date does not change
  • No entry in Special:Log

What should have happened instead?:

  • Success popup
  • Permission should have correctly been set to not expire
  • Entry should have been created in Special:Log

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

image.png (690×993 px, 57 KB)

image.png (169×623 px, 8 KB)

image.png (289×2 px, 47 KB)

Details

SubjectRepoBranchLines +/-
SpecialUserrights: Allow updating the expiry of user groupsmediawiki/corewmf/1.40.0-wmf.19+1 -1
SpecialUserrights: Allow updating the expiry of user groupsmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Novem_Linguae created this task.Jan 23 2023, 1:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 23 2023, 1:27 AM
Novem_Linguae renamed this task from Special:UserRights changing a temporary permission to "does not expire" fails to Special:UserRights changing a temporary permission's expiry dropdown box to any value fails.Jan 23 2023, 1:58 AM
Novem_Linguae added a subscriber: Umherirrender.

Git bisect narrowed this down to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/856063 / T275148. cc @Umherirrender

Novem_Linguae renamed this task from Special:UserRights changing a temporary permission's expiry dropdown box to any value fails to Special:UserRights changing an already set temporary permission's expiry to any new value fails.Jan 23 2023, 2:01 AM
gerritbot added a comment.Jan 23 2023, 4:37 AM

Change 882255 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] SpecialUserrights: Allow update the expiry of user groups

https://gerrit.wikimedia.org/r/882255

gerritbot added a project: Patch-For-Review.Jan 23 2023, 4:37 AM
EchidnaLives subscribed.Jan 23 2023, 5:11 AM
Legoktm triaged this task as High priority.Jan 23 2023, 6:23 AM
Legoktm subscribed.

I would recommend backporting this at the next opportunity.

Novem_Linguae renamed this task from Special:UserRights changing an already set temporary permission's expiry to any new value fails to Special:UserRights: changing an already set permission's expiry to any new value fails.Jan 23 2023, 6:32 AM
gerritbot added a comment.Jan 23 2023, 6:38 AM

Change 882255 merged by jenkins-bot:

[mediawiki/core@master] SpecialUserrights: Allow updating the expiry of user groups

https://gerrit.wikimedia.org/r/882255

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 23 2023, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 23 2023, 7:30 AM
gerritbot added a comment.Jan 23 2023, 8:10 AM

Change 882179 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@wmf/1.40.0-wmf.19] SpecialUserrights: Allow updating the expiry of user groups

https://gerrit.wikimedia.org/r/882179

gerritbot added a project: Patch-For-Review.Jan 23 2023, 8:10 AM
gerritbot added a comment.Jan 23 2023, 2:30 PM

Change 882179 merged by jenkins-bot:

[mediawiki/core@wmf/1.40.0-wmf.19] SpecialUserrights: Allow updating the expiry of user groups

https://gerrit.wikimedia.org/r/882179

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2023, 2:31 PM
Stashbot added a comment.Jan 23 2023, 2:37 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-23T14:37:52Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:882179|SpecialUserrights: Allow updating the expiry of user groups (T327605)]]

Stashbot added a comment.Jan 23 2023, 2:39 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-23T14:39:31Z] <taavi@deploy1002> taavi and func: Backport for [[gerrit:882179|SpecialUserrights: Allow updating the expiry of user groups (T327605)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Jan 23 2023, 2:46 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-23T14:46:41Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:882179|SpecialUserrights: Allow updating the expiry of user groups (T327605)]] (duration: 08m 48s)

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.19; 2023-01-16); removed MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 23 2023, 3:00 PM
Novem_Linguae closed this task as Resolved.Jan 23 2023, 4:00 PM
Novem_Linguae assigned this task to Func.

Works on testwiki now. Thanks for the quick backport.

AmandaNP reopened this task as Open.Feb 2 2023, 3:01 PM

Unless I'm really out to lunch - which I don't think I am - this bug has reappeared.
I tried to remove importer and transwiki-importer from Addshore@testwikidatawiki via Meta.

Edit saying I made the attempt: https://meta.wikimedia.org/wiki/Steward_requests/Permissions/2023-02#Addshore@testwikidata
Notice on my talk that it's not done: https://meta.wikimedia.org/wiki/User_talk:AmandaNP#c-Ameisenigel-20230202113900-SRP
Log of it actually being completed: https://meta.wikimedia.org/w/index.php?title=Special:Log&logid=51083518

Ameisenigel subscribed.Feb 2 2023, 3:22 PM
Umherirrender closed this task as Resolved.Feb 3 2023, 5:44 PM
In T327605#8582413, @AmandaNP wrote:

Unless I'm really out to lunch - which I don't think I am - this bug has reappeared.
I tried to remove importer and transwiki-importer from Addshore@testwikidatawiki via Meta.

Edit saying I made the attempt: https://meta.wikimedia.org/wiki/Steward_requests/Permissions/2023-02#Addshore@testwikidata
Notice on my talk that it's not done: https://meta.wikimedia.org/wiki/User_talk:AmandaNP#c-Ameisenigel-20230202113900-SRP
Log of it actually being completed: https://meta.wikimedia.org/w/index.php?title=Special:Log&logid=51083518

This task is about a failure on changing the expriy time of a user group, not to remove user groups from a user.
The first attempt to remove the user rights seems not logged at meta (Signature of the edit says "06:52, 2 February 2023 (UTC)", while there is no log around that)

Unless you have set the expriry of the groups to get them removed there is nothing to match this task. Please create a new task if there are still issues and explain what was done (Setting expiry or using the api to do the action or ...)
Without public log is not possible to follow the problem, not sure if the server logs would show that attempt, but that needs at least a new task to get the necessary attention and tags for someone to look into the server logs (not sure if that could be done, often only exceptions are searched in the logs)

All logs at meta: https://meta.wikimedia.org/wiki/Special:Log?type=rights&page=Addshore%40testwikidatawiki
All logs local: https://test.wikidata.org/wiki/Special:Log?type=rights&page=Addshore

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL