Page MenuHomePhabricator

Link temporary account names to user:contribs
Closed, ResolvedPublic2 Estimated Story Points

Assigned To
Authored By
Niharika
Jan 25 2023, 6:54 PM

Description

Motivation

Temporary account name links should take the user to the temp user's contributions page -- consistent with what happens for unregistered users at the moment.

Note that temporary account links in signatures already do this: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/778684/8/includes/parser/Parser.php#4743

Spec
  • Link temporary account username to the Special:Contributions page for the temp account
Notes
Testing Notes
  • Click on temporary account usernames e.g on History Page.
  • You should be redirected to the accounts' Special:Contribution page.

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptJan 25 2023, 6:54 PM

Change 887069 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/core@master] Link temporary account names to user:contribs

https://gerrit.wikimedia.org/r/887069

@Niharika It was pointed out in code review that there is often a contribs link shown after an unregisted account user link, e.g. on the history pages:

image.png (44ร—258 px, 5 KB)

What should we do?

Here's the gerrit comment from @Umherirrender, on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/887069/ :

There is already a "contribs" behind the user name, at least on action=history, which makes this looks duplicated. If this get changed, maybe T319081 is related

@RHo flagging for attention. should we remove the contribs links in favor of linking through the username?

@RHo flagging for attention. should we remove the contribs links in favor of linking through the username?

I tend to agree with T319081 in making it consistent for all editors to show talk & contribs, so would decline this task in favour of doing that one.

I agree. Let's push this change through as is. We can follow-up with T319081.

@Cyndymediawiksim Before I proceed to more testing, I've tested a couple from Admin and the TempUser (* Unregistered 29) account itself and it doesn't look like it's redirecting to the Special:Contribution page but creating the User as seen in the Result column. This was tested on History and Recent changes.

OS: macOS 13.0
Browser: Chrome 109
Environment: Local

LoginView historyResult
Admin
T327944_IPMasking_TempUser_TempLinktoContributions.png (433ร—3 px, 186 KB)
T327944_IPMasking_Admin_TempLinktoContributions_ResultError.png (536ร—3 px, 129 KB)
TempUser
T327944_IPMasking_TempUser_TempLinktoContributions.png (433ร—3 px, 186 KB)
T327944_IPMasking_TempUser_TempLinktoContributions_ResultError.png (553ร—3 px, 128 KB)
LoginSpecial:RecentChangesResult
Admin
T327944_IPMasking_TempUser_RC_TempLinktoContributions.png (499ร—3 px, 165 KB)
T327944_IPMasking_TempUser_TempLinktoContributions_ResultError.png (553ร—3 px, 128 KB)

@GMikesell-WMF I just had a look, and it seems as though the patch didn't merge.

@Cyndymediawiksim While I was looking, I spotted something so left a review. I'll move this task back into code review.

@Cyndymediawiksim @AGueyte I updated core and Checkuser for my Local but it does not look like it's linked to Special:Contribution since when I click on the temp user (*Unregister 31), I am getting a Creating User.

OS: macOS 13.0
Browser: Chrome 110
Environment: Local

T327944_IPMasking_TempUser_TempLinktoContributions1.png (1ร—3 px, 568 KB)

T327944_IPMasking_TempUser_TempLinktoContributions_ResultError1.png (762ร—3 px, 212 KB)

Change 887069 abandoned by Cyndywikime:

[mediawiki/core@master] Link temporary account names to user:contribs

Reason:

Media Wiki Interface Helper file got in this commit

https://gerrit.wikimedia.org/r/887069

Change 894243 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/core@master] Link temporary account names to user:contribs

https://gerrit.wikimedia.org/r/894243

Change 894243 merged by jenkins-bot:

[mediawiki/core@master] Link temporary account names to user:contribs

https://gerrit.wikimedia.org/r/894243

@Cyndymediawiksim @AGueyte I updated core and Checkuser for my Local but it does not look like it's linked to Special:Contribution since when I click on the temp user (*Unregister 53), I am getting a Creating User as seen below.

OS: macOS 13.0
Browser: Chrome 110
Environment: Local

T327944_IPMasking_TempUser_TempLinktoContributions_ResultError2a.png (928ร—3 px, 443 KB)

T327944_IPMasking_TempUser_TempLinktoContributions_ResultError2b.png (692ร—3 px, 205 KB)

@Cyndymediawiksim @AGueyte I updated core and Checkuser for my Local but it does not look like it's linked to Special:Contribution since when I click on the temp user (*Unregister 53), I am getting a Creating User as seen below.

OS: macOS 13.0
Browser: Chrome 110
Environment: Local

T327944_IPMasking_TempUser_TempLinktoContributions_ResultError2a.png (928ร—3 px, 443 KB)

T327944_IPMasking_TempUser_TempLinktoContributions_ResultError2b.png (692ร—3 px, 205 KB)

Interesting, thanks for this!
Is this the only place it doesn't create a contribution URL? Or is it this behavior on all pages?

I've tested on Special:Log, Special:RecentChanges, Revision History, with the latest pull and even logged out I have the contribution links.

Thank you,

@AGueyte That is interesting. Yes, it's for all pages meaning that it must be something with my Local config or rights? Do you have anything different?

Admin rights: Stewards, Administrators, Autoconfirmed users, Bureaucrats, Check users, Interface administrators, Registered users, Suppressors, Users, checkuser-temporary-account

@AGueyte Ok looks like we are good to go now! They all now link to Special:Contribution. I will move this to Done. Thanks again!

T327944_IPMasking_Admin_TempLinktoContributions_Fix.png (1ร—3 px, 646 KB)