| Jdlrobson | |
| Feb 7 2023, 12:52 AM |
| F36819963: Screenshot 2023-02-10 at 4.18.04 PM.png | |
| Feb 11 2023, 12:19 AM |
| F36819962: Screenshot 2023-02-10 at 4.18.15 PM.png | |
| Feb 11 2023, 12:19 AM |
| F36819961: Screenshot 2023-02-10 at 4.17.31 PM.png | |
| Feb 11 2023, 12:19 AM |
| F36816651: Screenshot 2023-02-08 at 5.08.12 PM.png | |
| Feb 9 2023, 1:09 AM |
| F36816650: Screenshot 2023-02-08 at 5.08.23 PM.png | |
| Feb 9 2023, 1:09 AM |
| F36816649: Screenshot 2023-02-08 at 5.09.17 PM.png | |
| Feb 9 2023, 1:09 AM |
| F36781274: image.png | |
| Feb 7 2023, 12:52 AM |
| F36781273: image.png | |
| Feb 7 2023, 12:52 AM |
Flagged by Pixel. The help icon is no longer part of the header. Not sure what caused it and unable to currently replicate it locally.
To replicate:
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T328996#8600051 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T328996#8606712 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | BUG REPORT | ovasileva | T327795 Language list shows in preview (not gadget related) | ||
| Resolved | ovasileva | T328996 [Regression] History page help icon moved out of the header |
I'm able to replicate this locally on any local history page other than Main page. It appears to be caused by the removal of the following lines in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/885411/6/includes/SkinVector22.php#56
if ( $this->getContext()->getActionName() !== 'view' ) {
return false;
}Change 887383 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] Disable languages on history page
Change 887383 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Disable languages on history page
Change 887353 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@wmf/1.40.0-wmf.22] Disable languages on history page
Change 887353 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.40.0-wmf.22] Disable languages on history page
Mentioned in SAL (#wikimedia-operations) [2023-02-07T21:20:28Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:887353|Disable languages on history page (T328996)]], [[gerrit:887351|Remove button styling from log in link (T289212)]], [[gerrit:887350|[followup] mediawiki.feedlink: Atom's link icon overlaps the link (T327717)]]
Mentioned in SAL (#wikimedia-operations) [2023-02-07T21:22:20Z] <urbanecm@deploy1002> urbanecm and jdlrobson: Backport for [[gerrit:887353|Disable languages on history page (T328996)]], [[gerrit:887351|Remove button styling from log in link (T289212)]], [[gerrit:887350|[followup] mediawiki.feedlink: Atom's link icon overlaps the link (T327717)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet
Mentioned in SAL (#wikimedia-operations) [2023-02-07T21:31:38Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:887353|Disable languages on history page (T328996)]], [[gerrit:887351|Remove button styling from log in link (T289212)]], [[gerrit:887350|[followup] mediawiki.feedlink: Atom's link icon overlaps the link (T327717)]] (duration: 11m 10s)
Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: History page help icon/link should remain in the header.
I tested this with various widths and with the main and tools menu in/out their respective sidebars
Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: History page help icon/link should remain in the header.
I tested this with various widths and with the main and tools menu in/out their respective sidebars
This was in archived projects so was being filtered out of our backlog and by chance I just saw it now. I've opened a new ticket: T341394 - thanks for the report.