Page MenuHomePhabricator

Language list shows in preview (not gadget related)
Open, MediumPublic3 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue:

  • Disable VisualEditor in user preferences
  • Go to any article on the Vietnamese Wikipedia (for example: https://vi.wikipedia.org/wiki/K%C3%A9k) which has languages
  • Click Edit source
  • Click PREVIEW button
  • Scroll down a bit and look at the left side bar where you can find the Language list

What happens?:

image.png (740×401 px, 29 KB)

The full list appears (instead of a compacted list), there's a letter "G" in every other line, and when you hover your cursor over it, it will jump randomly.

What should have happened instead?:

The languages should appear in the top right under the language button

Event Timeline

sgrabarczuk renamed this task from Language list doesn't look right after the new Page tool feature for Vector 2022 was deploited to Language list doesn't look right after the new Page tool feature for Vector 2022 was deployed.Tue, Jan 24, 5:53 PM
sgrabarczuk awarded a token.
matmarex added a subscriber: matmarex.

(Doesn't seem related to Editing-team's work)

Jdlrobson changed the task status from Open to Stalled.Mon, Jan 30, 7:17 PM
Jdlrobson added a subscriber: Jdlrobson.

I can't replicate this issue. I enabled all gadgets on Vietnamese Wikipedia and was still unable to get the screenshot. It is highly likely that this issue is a caching issue that occurred during the rollout of page tools .

@PPham are you still able to replicate this ? If so could you please provide some more information:

  • What URL can you replicate the issue?
  • Are you logged in or logged out?

@Jdlrobson It's still there.

The URL: https://vi.wikipedia.org/w/index.php?title=Cytisophyllum_sessilifolium&action=edit

I'm logging in. But it's really odd, I can only replicate this issue when I use my personal account. The list of languages disappeared (like the Chrome version above) when I changed to my WMF account, still the same browser.

There is also sbd else (seemingly) reporting this issue too.

Jdlrobson renamed this task from Language list doesn't look right after the new Page tool feature for Vector 2022 was deployed to Language list shows in preview (not gadget related).Tue, Jan 31, 7:16 PM
Jdlrobson changed the task status from Stalled to Open.
Jdlrobson updated the task description. (Show Details)

Change 885411 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Languages should be at top on edit preview

https://gerrit.wikimedia.org/r/885411

Jdlrobson triaged this task as Medium priority.Tue, Jan 31, 7:23 PM

Ok I can replicate this now. Doesn't seem to be gadget related. Rather Vector 2022 is overly restrictive over where we show the language button.
@ovasileva this is ready for estimation.

Please also test with "Show preview when starting to edit" user preference and the "Do not show page content below diffs" user preference (see https://vi.wikipedia.org/w/index.php?title=K%C3%A9k&diff=0&diffonly=1)

Would be nice to know what should happen there for further code review.

Change 885411 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Languages should be in HTML at top whenever languages are added to page

https://gerrit.wikimedia.org/r/885411