Page MenuHomePhabricator
Create Task
Maniphest T327795

Language list shows in preview (not gadget related)
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To
ovasileva
Authored By
PPham
Jan 24 2023, 3:39 PM
Tags
Referenced Files
F36819973: Screenshot 2023-02-10 at 4.25.18 PM.png
Feb 11 2023, 12:27 AM
F36816633: Screenshot 2023-02-08 at 4.55.51 PM.png
Feb 9 2023, 1:02 AM
F36816631: Screenshot 2023-02-08 at 4.56.08 PM.png
Feb 9 2023, 1:02 AM
F36476415: image.png
Jan 24 2023, 3:39 PM
F36476106: image.png
Jan 24 2023, 3:39 PM
F36476421: image.png
Jan 24 2023, 3:39 PM
Subscribers
Aklapper
Edtadros
Jdlrobson
Jdrewniak
ovasileva
PPham
sgrabarczuk
Umherirrender
Tokens
"Like" token, awarded by sgrabarczuk.

Description

Steps to replicate the issue:

  • Disable VisualEditor in user preferences
  • Go to any article on the Vietnamese Wikipedia (for example: https://vi.wikipedia.org/wiki/K%C3%A9k) which has languages
  • Click Edit source
  • Click PREVIEW button
  • Scroll down a bit and look at the left side bar where you can find the Language list

What happens?:

image.png (740×401 px, 29 KB)

The full list appears (instead of a compacted list), there's a letter "G" in every other line, and when you hover your cursor over it, it will jump randomly.

What should have happened instead?:

The languages should appear in the top right under the language button

QA Results - Beta

ACStatusDetails
1✅T327795#8600044

QA Results - Prod

ACStatusDetails
1✅T327795#8606729

Details

SubjectRepoBranchLines +/-
Languages should be in HTML at top whenever languages are added to pagemediawiki/skins/Vectormaster+10 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

PPham created this task.Jan 24 2023, 3:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2023, 3:39 PM
sgrabarczuk renamed this task from Language list doesn't look right after the new Page tool feature for Vector 2022 was deploited to Language list doesn't look right after the new Page tool feature for Vector 2022 was deployed.Jan 24 2023, 5:53 PM
sgrabarczuk awarded a token.
Jdlrobson added a project: Web-Team-Backlog.Jan 24 2023, 10:37 PM
Jdlrobson added a project: Editing-team.
Jdlrobson moved this task from Incoming to Search on the Desktop Improvements (Vector 2022) board.Jan 26 2023, 8:20 PM
Jdlrobson added a project: UniversalLanguageSelector.
matmarex removed a project: Editing-team.Jan 27 2023, 2:58 PM
matmarex subscribed.

(Doesn't seem related to Editing-team's work)

matmarex unsubscribed.Jan 27 2023, 2:59 PM
ovasileva added a project: Web-Team FY2022-23 Q3 Sprint 1.Jan 27 2023, 3:05 PM
ovasileva edited projects, added Web-Team FY2022-23 Q3 Sprint 2; removed Web-Team FY2022-23 Q3 Sprint 1.Jan 30 2023, 4:06 PM
Jdlrobson changed the task status from Open to Stalled.Jan 30 2023, 7:17 PM
Jdlrobson subscribed.

I can't replicate this issue. I enabled all gadgets on Vietnamese Wikipedia and was still unable to get the screenshot. It is highly likely that this issue is a caching issue that occurred during the rollout of page tools .

@PPham are you still able to replicate this ? If so could you please provide some more information:

  • What URL can you replicate the issue?
  • Are you logged in or logged out?
PPham added a comment.Jan 31 2023, 8:13 AM

@Jdlrobson It's still there.

The URL: https://vi.wikipedia.org/w/index.php?title=Cytisophyllum_sessilifolium&action=edit

I'm logging in. But it's really odd, I can only replicate this issue when I use my personal account. The list of languages disappeared (like the Chrome version above) when I changed to my WMF account, still the same browser.

There is also sbd else (seemingly) reporting this issue too.

Jdlrobson updated the task description. (Show Details)Jan 31 2023, 7:13 PM
Jdlrobson renamed this task from Language list doesn't look right after the new Page tool feature for Vector 2022 was deployed to Language list shows in preview (not gadget related).Jan 31 2023, 7:16 PM
Jdlrobson changed the task status from Stalled to Open.
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)Jan 31 2023, 7:18 PM
gerritbot added a comment.Jan 31 2023, 7:22 PM

Change 885411 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Languages should be at top on edit preview

https://gerrit.wikimedia.org/r/885411

gerritbot added a project: Patch-For-Review.Jan 31 2023, 7:22 PM
Jdlrobson triaged this task as Medium priority.Jan 31 2023, 7:23 PM

Ok I can replicate this now. Doesn't seem to be gadget related. Rather Vector 2022 is overly restrictive over where we show the language button.
@ovasileva this is ready for estimation.

Jdlrobson moved this task from Incoming to Q3 Sprint 2 (non milestone) on the Web-Team-Backlog board.Jan 31 2023, 11:50 PM
ovasileva set the point value for this task to 3.Feb 2 2023, 5:48 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team FY2022-23 Q3 Sprint 2 board.
Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team FY2022-23 Q3 Sprint 2 board.Feb 2 2023, 5:55 PM
Umherirrender subscribed.Feb 3 2023, 8:26 PM

Please also test with "Show preview when starting to edit" user preference and the "Do not show page content below diffs" user preference (see https://vi.wikipedia.org/w/index.php?title=K%C3%A9k&diff=0&diffonly=1)

Would be nice to know what should happen there for further code review.

LGoto assigned this task to Jdrewniak.Feb 6 2023, 6:17 PM
gerritbot added a comment.Feb 6 2023, 11:52 PM

Change 885411 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Languages should be in HTML at top whenever languages are added to page

https://gerrit.wikimedia.org/r/885411

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 7 2023, 12:00 AM
Jdlrobson reassigned this task from Jdrewniak to Edtadros.Feb 7 2023, 12:09 AM
Jdlrobson moved this task from Code Review to QA on the Web-Team FY2022-23 Q3 Sprint 2 board.
Jdlrobson added a subscriber: Jdrewniak.
Maintenance_bot removed a project: Patch-For-Review.Feb 7 2023, 12:30 AM
Jdlrobson added a subtask: T328996: [Regression] History page help icon moved out of the header.Feb 7 2023, 5:39 PM
Edtadros moved this task from QA to QA in Production on the Web-Team FY2022-23 Q3 Sprint 2 board.Feb 9 2023, 1:02 AM

Test Result - Beta

Status: ✅ PASS
Environment: vibeta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Disable VisualEditor in user preferences
Go to any article on the Vietnamese Wikipedia (for example: https://vi.wikipedia.org/wiki/K%C3%A9k) which has languages
Click Edit source
Click PREVIEW button
✅ AC1: The languages should appear in the top right under the language button

Screenshot 2023-02-08 at 4.56.08 PM.png (708×1 px, 191 KB)

Screenshot 2023-02-08 at 4.55.51 PM.png (744×1 px, 194 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Feb 11 2023, 12:27 AM
Edtadros moved this task from QA in Production to Ready for Signoff on the Web-Team FY2022-23 Q3 Sprint 2 board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: viwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Disable VisualEditor in user preferences
Go to any article on the Vietnamese Wikipedia (for example: https://vi.wikipedia.org/wiki/K%C3%A9k) which has languages
Click Edit source
Click PREVIEW button
✅ AC1: The languages should appear in the top right under the language button

Screenshot 2023-02-10 at 4.25.18 PM.png (753×1 px, 298 KB)

Edtadros updated the task description. (Show Details)Feb 11 2023, 12:29 AM
ovasileva closed this task as Resolved.Feb 17 2023, 6:21 PM
ovasileva closed subtask T328996: [Regression] History page help icon moved out of the header as Resolved.
Func reopened subtask T328996: [Regression] History page help icon moved out of the header as Open.Jun 30 2023, 2:50 PM
Jdlrobson closed subtask T328996: [Regression] History page help icon moved out of the header as Resolved.Jul 7 2023, 10:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits