Page MenuHomePhabricator
Create Task
Maniphest T327717

Page tools: Support icon for Atom link
Open, Stalled, MediumPublicBUG REPORT
Actions

Assigned To
None
Authored By
TheDJ
Jan 23 2023, 9:49 PM
Tags
Referenced Files
F36856326: obraz.png
Feb 16 2023, 10:41 PM
F36823879: Screen Shot 2023-02-13 at 10.22.29 AM.png
Feb 13 2023, 6:22 PM
F36823877: Screen Shot 2023-02-13 at 10.22.07 AM.png
Feb 13 2023, 6:22 PM
F36525200: Screenshot 2023-01-27 at 12-32-46 Vouiquipèdia Lo Câfè du Velâjo — Vouiquipèdia.png
Jan 27 2023, 11:33 AM
F36525196: Screenshot 2023-01-27 at 12-29-01 Vouiquipèdia Lo Câfè du Velâjo — Vouiquipèdia.png
Jan 27 2023, 11:31 AM
F36455931: Screenshot 2023-01-23 at 22.48.14.png
Jan 23 2023, 9:49 PM
Subscribers
Aklapper
Jdlrobson
Jonesey95
• Mabualruz
Nux
Satricious
Terasail
View All 10 Subscribers
Tokens
"Doubloon" token, awarded by Nemo_bis.

Description

NOTE: Blocked on https://phabricator.wikimedia.org/T329794

In Vector an Atom icon showed next to the menu item. This is not shown in Vector 2022 skin.

https://en.wikipedia.org/wiki/Special:Contributions/TheDJ?useskin=vector
https://en.wikipedia.org/wiki/Special:Contributions/TheDJ?useskin=vector-2022

Screen Shot 2023-02-13 at 10.22.07 AM.png (167×133 px, 10 KB)

Screen Shot 2023-02-13 at 10.22.29 AM.png (333×1 px, 59 KB)

TODO

  • It should be possible to register the feed icon using the icon property on menu item data
  • The icon should appear in Vector 2022 next to the feed icon. Technically it should be using mw-ui-icon

QA Steps

  • There should be an icon for the feed icon
  • No other menu items should have icons.

Background

Previously icon was overlapping, but we disabled that in Web-Team FY2022-23 Q3 Sprint 2

Screenshot 2023-01-23 at 22.48.14.png (618×656 px, 48 KB)

Now no icon shows at all.

  • Disable icon styling for Vector 2022

Details

SubjectRepoBranchLines +/-
[POC][DO NOT MERGE] Page tools: Support Link's Iconsmediawiki/skins/Vectormaster+78 -1
[POC][DO NOT MERGE] P Page tools: Atom's link icon overlaps the linkmediawiki/coremaster+5 -2
[followup] mediawiki.feedlink: Atom's link icon overlaps the linkmediawiki/corewmf/1.40.0-wmf.22+0 -1
[followup] mediawiki.feedlink: Atom's link icon overlaps the linkmediawiki/coremaster+0 -1
mediawiki.feedlink: Atom's link icon overlaps the linkmediawiki/coremaster+6 -0
Page tools: Atom's link icon overlaps the linkmediawiki/skins/Vectormaster+4 -0
[WIP] Page tools: Atom's link icon overlaps the linkmediawiki/skins/Vectormaster+124 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DuplicateBUG REPORTNoneT327719 Vector 2022 Tools sidebar formatting issues
 StalledBUG REPORTNoneT327717 Page tools: Support icon for Atom link

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 23 2023, 9:49 PM
Terasail mentioned this in T327719: Vector 2022 Tools sidebar formatting issues.Jan 23 2023, 10:02 PM
ovasileva triaged this task as Medium priority.Jan 23 2023, 10:02 PM
ovasileva edited projects, added Web-Team FY2022-23 Q3 Sprint 1; removed Web-Team-Backlog.
Jdlrobson subscribed.Jan 24 2023, 1:37 AM

I guess we'll need to do a temporary fix here as we did for the watchstar since this menu doesn't officially support icons yet.

Jdlrobson added a parent task: T327719: Vector 2022 Tools sidebar formatting issues.Jan 24 2023, 1:38 AM
Vahurzpu subscribed.Jan 24 2023, 4:51 PM
DavidBrooks subscribed.Jan 24 2023, 6:24 PM
DavidBrooks unsubscribed.Jan 24 2023, 11:31 PM
Jdlrobson edited projects, added Web-Team FY2022-23 Q3 Sprint 2; removed Web-Team FY2022-23 Q3 Sprint 1.Jan 26 2023, 6:12 PM
Jdlrobson added a comment.Jan 26 2023, 6:35 PM

Style is coming from a module in core (not sure why it needs its own module)
I suggest we move this to a skin style module on the short term and add a specific rule for Vector 2022.
https://gerrit.wikimedia.org/g/mediawiki/core/+/595da3dec864e8a0f827d703be040370d0be27e2/resources/src/mediawiki.feedlink/feedlink.css#4

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team FY2022-23 Q3 Sprint 2 board.Jan 26 2023, 6:36 PM
LGoto set the point value for this task to 3.Jan 26 2023, 6:36 PM
Jdlrobson merged a task: T327719: Vector 2022 Tools sidebar formatting issues.Jan 26 2023, 7:10 PM
Jdlrobson added subscribers: Terasail, Patafisik, Jonesey95.
Jdlrobson moved this task from Incoming to Page Tools on the Desktop Improvements (Vector 2022) board.Jan 26 2023, 8:20 PM
Patafisik added a comment.EditedJan 27 2023, 11:31 AM

Hi, FYI there is a similar issue on frp.wikipedia for sister projects icons
actually

Screenshot 2023-01-27 at 12-29-01 Vouiquipèdia Lo Câfè du Velâjo — Vouiquipèdia.png (890×244 px, 28 KB)

with ?vectorpagetools=1

Screenshot 2023-01-27 at 12-32-46 Vouiquipèdia Lo Câfè du Velâjo — Vouiquipèdia.png (914×575 px, 62 KB)

Patafisik attached a referenced file: F36525200: Screenshot 2023-01-27 at 12-32-46 Vouiquipèdia Lo Câfè du Velâjo — Vouiquipèdia.png. (Show Details)Jan 27 2023, 11:38 AM
ovasileva raised the priority of this task from Medium to High.Jan 27 2023, 4:42 PM
Satricious merged a task: T328156: Vector 2022: RSS Feed icon overlaps text due to 0px left padding.Jan 27 2023, 5:44 PM
Satricious subscribed.
Satricious added a comment.EditedJan 27 2023, 5:51 PM

I mistakenly reported this issue again (as you can see above), didn't know there already was a task open. It might be useful to see my task as I reported where the issue was originating from (namely, the 16px left padding on the feed icon is not applied because of a rule with more specificity with a 0px left and right padding).

Jdlrobson mentioned this in T328157: Sister project icons overlap text on frp.wikipedia.org.Jan 27 2023, 5:54 PM

@Patafisik I've opened T328157 for the sister icons. I suggest fixing this one first has hopefully solution can be applied there too.

Patafisik unsubscribed.Jan 28 2023, 10:50 AM
• Mabualruz claimed this task.Jan 30 2023, 7:23 PM
gerritbot added a comment.Jan 30 2023, 7:57 PM

Change 885006 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] Page tools: Atom's link icon overlaps the link

https://gerrit.wikimedia.org/r/885006

gerritbot added a project: Patch-For-Review.Jan 30 2023, 7:57 PM
• Mabualruz moved this task from Ready for Development to Doing on the Web-Team FY2022-23 Q3 Sprint 2 board.Jan 31 2023, 3:58 PM
gerritbot added a comment.Feb 2 2023, 5:14 PM

Change 885478 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] [WIP] Page tools: Atom's link icon overlaps the link

https://gerrit.wikimedia.org/r/885478

Urbanecm_WMF merged a task: T328766: In Vector 2022 with Page tools enabled, the RSS icon overlaps with "Atom" at Special:Watchlist / history of pages.Feb 3 2023, 1:36 PM
Urbanecm_WMF subscribed.
gerritbot added a comment.Feb 4 2023, 3:19 AM

Change 885480 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] [WIP][Core] Page tools: Atom's link icon overlaps the link

https://gerrit.wikimedia.org/r/885480

gerritbot added a comment.Feb 4 2023, 3:26 AM

Change 885478 abandoned by Mabualruz:

[mediawiki/skins/Vector@master] [WIP] Page tools: Atom's link icon overlaps the link

Reason:

https://gerrit.wikimedia.org/r/885478

gerritbot added a comment.Feb 4 2023, 3:28 AM

Change 885006 abandoned by Mabualruz:

[mediawiki/skins/Vector@master] Page tools: Atom's link icon overlaps the link

Reason:

https://gerrit.wikimedia.org/r/885006

gerritbot added a comment.Feb 6 2023, 6:29 PM

Change 886847 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] [Core][quickfix] Page tools: Atom's link icon overlaps the link

https://gerrit.wikimedia.org/r/886847

gerritbot added a comment.Feb 6 2023, 11:00 PM

Change 886847 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.feedlink: Atom's link icon overlaps the link

https://gerrit.wikimedia.org/r/886847

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 7 2023, 12:00 AM
gerritbot added a comment.Feb 7 2023, 3:33 PM

Change 886852 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] [followup] mediawiki.feedlink: Atom's link icon overlaps the link

https://gerrit.wikimedia.org/r/886852

gerritbot added a comment.Feb 7 2023, 4:54 PM

Change 886852 merged by jenkins-bot:

[mediawiki/core@master] [followup] mediawiki.feedlink: Atom's link icon overlaps the link

https://gerrit.wikimedia.org/r/886852

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.23; 2023-02-13); removed MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 7 2023, 5:01 PM
gerritbot added a comment.Feb 7 2023, 5:28 PM

Change 887350 had a related patch set uploaded (by Jdlrobson; author: Mabualruz):

[mediawiki/core@wmf/1.40.0-wmf.22] [followup] mediawiki.feedlink: Atom's link icon overlaps the link

https://gerrit.wikimedia.org/r/887350

• Mabualruz added a comment.Feb 7 2023, 5:40 PM

I think this would benefit of a break down to 2 more tasks, and moving this one along to QA.

  1. Prepare Core Icons config
  2. Change the generation of the pagetools to use vector components
Jdlrobson renamed this task from Page tools: Atom's link icon overlaps the link to Page tools: Support icon for Atom link (was Atom's link icon overlaps the link).Feb 7 2023, 7:59 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Feb 7 2023, 9:20 PM

Change 887350 merged by jenkins-bot:

[mediawiki/core@wmf/1.40.0-wmf.22] [followup] mediawiki.feedlink: Atom's link icon overlaps the link

https://gerrit.wikimedia.org/r/887350

Stashbot added a comment.Feb 7 2023, 9:20 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-07T21:20:28Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:887353|Disable languages on history page (T328996)]], [[gerrit:887351|Remove button styling from log in link (T289212)]], [[gerrit:887350|[followup] mediawiki.feedlink: Atom's link icon overlaps the link (T327717)]]

Stashbot mentioned this in T289212: Feature request: Make login button appear besides the create account text outside new compact user menu.Feb 7 2023, 9:20 PM
Stashbot mentioned this in T328996: [Regression] History page help icon moved out of the header.

Mentioned in SAL (#wikimedia-operations) [2023-02-07T21:22:20Z] <urbanecm@deploy1002> urbanecm and jdlrobson: Backport for [[gerrit:887353|Disable languages on history page (T328996)]], [[gerrit:887351|Remove button styling from log in link (T289212)]], [[gerrit:887350|[followup] mediawiki.feedlink: Atom's link icon overlaps the link (T327717)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Feb 7 2023, 9:31 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-07T21:31:38Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:887353|Disable languages on history page (T328996)]], [[gerrit:887351|Remove button styling from log in link (T289212)]], [[gerrit:887350|[followup] mediawiki.feedlink: Atom's link icon overlaps the link (T327717)]] (duration: 11m 10s)

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.22; 2023-02-06); removed MW-1.40-notes (1.40.0-wmf.23; 2023-02-13).Feb 7 2023, 10:00 PM
• Mabualruz added a comment.EditedFeb 9 2023, 2:20 PM

I have documented some of what we need here:

https://docs.google.com/document/d/1Y6pFRGbMj1d8pONRobv09wIEe5nI4Cp_tM1DiqlaPfw/edit?usp=sharing

I will continue to work on the task now, still document needs input/discussion and further filling and refining

Jdlrobson updated the task description. (Show Details)Feb 9 2023, 5:44 PM
Jdlrobson moved this task from Doing to Needs More Work on the Web-Team FY2022-23 Q3 Sprint 2 board.Feb 9 2023, 10:49 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team FY2022-23 Q3 Sprint 2.Feb 13 2023, 6:20 PM

Sprint 2 is now complete and this work was not finished so we've agreed to drop it off the sprint board.

Jdlrobson renamed this task from Page tools: Support icon for Atom link (was Atom's link icon overlaps the link) to Page tools: Support icon for Atom link.Feb 13 2023, 6:22 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Feb 13 2023, 6:39 PM
Nemo_bis awarded a token.Feb 15 2023, 2:02 PM
Nux subscribed.Feb 16 2023, 9:56 PM
Nux added a comment.Feb 16 2023, 10:41 PM

Hi, note that on en.wiki there is a default gadget (also show for anons) with an icon. "Edit interlanguage links"

obraz.png (920×660 px, 90 KB)

Not a fan of that icon, but I guess that should be fixed too.

Note that the script that adds this probably needs fixing too as it doesn't add a menu item in a standard way (and so doesn't have text in a span element).

Jdlrobson added a comment.Feb 16 2023, 11:12 PM

@Nux we're tracking that issue in T328069.

Jdlrobson mentioned this in T329794: Menus: Make Tabs template fully-data driven to support upcoming navigation restructure work.Feb 23 2023, 12:29 AM
Jdlrobson changed the task status from Open to Stalled.Feb 23 2023, 12:59 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson removed the point value for this task.

Blocked on https://phabricator.wikimedia.org/T329794

ovasileva lowered the priority of this task from High to Medium.Mar 1 2023, 11:40 PM
ovasileva moved this task from Not ready to estimate to Current Quarter on the Web-Team-Backlog board.
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 2 2023, 1:20 AM
Jdlrobson moved this task from Current Quarter to Web Team FY2022-23 Q4 Sprint 3 on the Web-Team-Backlog board.Apr 5 2023, 5:40 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3); removed Web-Team-Backlog.
Jdlrobson moved this task from Web Team FY2022-23 Q4 Sprint 3 to Current Fiscal Year on the Web-Team-Backlog board.Apr 5 2023, 5:43 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3).
gerritbot added a comment.Mar 18 2024, 7:45 AM

Change 1011429 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/skins/Vector@master] [POC][DO NOT MERGE] Page tools: Support Link's Icons

https://gerrit.wikimedia.org/r/1011429

gerritbot added a project: Patch-For-Review.Mar 18 2024, 7:45 AM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptMar 18 2024, 7:46 AM
• Mabualruz added a comment.Mar 18 2024, 8:02 AM

I've created a new proof of concept for this Task. Moving forward, we will require:

  • Input from the design
  • An overview of the technical design
• Mabualruz added a comment.Mar 18 2024, 5:00 PM

Will be abandoned but can be used as a future reference if we get back to this issue

gerritbot added a comment.Mar 18 2024, 5:00 PM

Change 885480 abandoned by Mabualruz:

[mediawiki/core@master] [POC][DO NOT MERGE] P Page tools: Atom's link icon overlaps the link

Reason:

Old and will be used as a reference for future development only

https://gerrit.wikimedia.org/r/885480

gerritbot added a comment.Mar 18 2024, 5:01 PM

Change 1011429 abandoned by Mabualruz:

[mediawiki/skins/Vector@master] [POC][DO NOT MERGE] Page tools: Support Link's Icons

Reason:

Not needed in the current work linked to task for future reference

https://gerrit.wikimedia.org/r/1011429

Jdlrobson moved this task from Current Fiscal Year to Groomed on the Web-Team-Backlog board.Mar 19 2024, 5:56 PM
• Mabualruz removed • Mabualruz as the assignee of this task.Mar 21 2024, 1:53 PM
• Mabualruz subscribed.
Jdlrobson moved this task from Page Tools to User interface on the Desktop Improvements (Vector 2022) board.Tue, May 28, 9:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL