Page MenuHomePhabricator

Old alt text remains after changing the caption in a gallery
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Edit an article with a gallery in visual editor on the desktop.
  • Edit the gallery.
  • Edit an existing caption in which "Use the caption as the alternative text" is checked.

What happens?:

After editing the caption, the old alt text remains.

What should have happened instead?:

The old alt text should immediately change.

Event Timeline

Tagging Parsoid as we think this issue might get resolved by the work @Arlolra is doing to improve support for galleries.

The old alt text should immediately change.

To clarify, what you mean is that, as you type in the "Caption" box, the "Alternative text" field should update itself to match.

At present, while the "Use the caption as the alternative text" is checked, the "Alternative text" is greyed out and uneditable and the field is ignored. In other words, it's working as intended but there isn't enough visual feedback.

Yes—the wrong visual feedback makes me think it doesn't work as intended :)

Change 896168 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/VisualEditor@master] [WIP] Update gallery alt with caption when set as same

https://gerrit.wikimedia.org/r/896168

Yes—the wrong visual feedback makes me think it doesn't work as intended :)

Wrong is pretty subjective

@ppelberg I believe the above patch satisfies the request. Please decide if it's something your team wants. Thanks

Arlolra triaged this task as Medium priority.Mar 13 2023, 3:32 PM
Arlolra moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.

Change 896168 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update gallery alt with caption when set as same

https://gerrit.wikimedia.org/r/896168

EAkinloose subscribed.

✅ alt text is updated to match caption when Use the caption as the alternative text is checked

Screenshot 2023-03-21 at 03.25.42.png (652×1 px, 61 KB)

Screenshot 2023-03-21 at 03.25.54.png (402×1 px, 64 KB)

✅ behaves as expected when `Use the caption as the alternative text isn't checked

Screenshot 2023-03-21 at 03.27.44.png (684×944 px, 52 KB)