Page MenuHomePhabricator

"Show IP" button not shown on the Page information page
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Make a test edit using a temporary account
  • Log into an account that can view temporary account IPs
  • View the page that the temporary account made the edit to
  • Click on "Page information" in the page tools menu
  • Scroll down to "Edit history" and look at the Latest editor row in the associated table.

What happens?:
No "Show IP" button is shown

What should have happened instead?:
The "Show IP" button should be shown

Software version (skip for WMF-hosted wikis like Wikipedia):
Latest CheckUser and core code

Other information (browser name/version, screenshots, etc.):
Example screenshot:

image.png (124×1 px, 23 KB)

Testing Notes

  • Make a test edit using a temporary account
  • Log into an account that can view temporary account IPs
  • View the page that the temporary account made the edit to
  • Click on "Page information" in the page tools menu
  • Scroll down to "Edit history" and look at the Latest editor row in the associated table.
  • "Show IP" button should now be visible at the Latest editor row in the associated table.

Event Timeline

Should be able to be shown by making the PageDisplay hook check for action=info in the query parameters.

Thanks for filing this one, @Dreamy_Jazz! Will add it to our next sprint.

Tchanders set the point value for this task to 1.Mar 14 2023, 2:43 PM

Change 899623 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/CheckUser@master] Add "Show IP" button on the Page information page

https://gerrit.wikimedia.org/r/899623

Change 899623 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add "Show IP" button on the Page information page

https://gerrit.wikimedia.org/r/899623

@Cyndymediawiksim I tried to test in my Local but I do not see the Show IP in Page Information as seen in the screenshot. I do see the Show IP on the other pages though like Revision History.

OS: macOS 13.0
Browsers: Chrome 110
Skins: Vector 2022, 2010
Environment: Local

Page Info

T331017_IPMasking_PageInfo_ShowIP2.png (1×1 px, 188 KB)

Revision HIstory

T331017_IPMasking_PageInfo_ShowIP.png (1×3 px, 475 KB)

@GMikesell-WMF seems to work for me:

image.png (538×1 px, 81 KB)

I'm running Firefox on Windows 11 using Vector 2022 on my docker local environment.

@Dreamy_Jazz Hmmm, I guess I play around with my configs or preferences more to see why I'm not seeing it. Thanks for the update!

No problem. Let me know if you want me to check what config settings I have set that might be affecting this.

If you don't mind that would be great. Hopefully, this isn't just a mac issue. It's just weird that I see it on the other pages though. My core and checkuser extension are up to date too.

Versions being run (as reported by Special:Version):

  • CheckUser - 2.5 (d960666) 19:20, 15 March 2023
  • core - 1.41.0-alpha (c79b1df) 19:15, 15 March 2023

Relevant config settings:

  • $wgAutoCreateTempUser['enabled'] = true;
  • wfLoadExtensions([..., "CheckUser", ...]);
  • $wgGroupPermissions['sysop']['checkuser-temporary-account'] = true;

Preference enabled to see temporary account IPs.

Also checked on Vector 2010 which seemed to not affect it being shown for me.

I can share more of my LocalSettings.php file if wanted.

Page Info

T331017_IPMasking_PageInfo_ShowIP2.png (1×1 px, 188 KB)

One thing I would note that is different is that your screenshot doesn't seem to have links to the user page or contributions page of the temporary user. That likely explains why it doesn't show, because the JS script looks for the class mw-tempuserlink which presumably isn't added when there is no user link, but not sure why there is that difference.

Thanks for the info! Here's a better screenshot. It does have a link and links to the Special:Contribution page

T331017_IPMasking_PageInfo_ShowIP3.png (311×776 px, 46 KB)

@Dreamy_Jazz Ok after playing around with it more, I now see it. Thanks for the assist!

T331017_IPMasking_PageInfo_ShowIP4.png (984×3 px, 229 KB)

@Cyndymediawiksim Chrome and Firefox were fine but in Safari I was not getting the Show IP as seen in the screenshot below on page information.

OS: macOS 13.0
Browser: Safari 16.3, Chrome 111, Firefox 111
Environment: Local

BrowserShow IP Result
Safari 16.3
T331017_IPMasking_PageInfo_ShowIP_Safari.png (1×1 px, 242 KB)
Chrome 111
T331017_IPMasking_PageInfo_ShowIP_Chrome.png (1×1 px, 193 KB)
Firefox 111
T331017_IPMasking_PageInfo_ShowIP_FF.png (1×1 px, 203 KB)

I found T328754, which might explain the issue? It's odd though because I would have thought the button would either show everywhere or nowhere on safari.

@Cyndymediawiksim Chrome and Firefox were fine but in Safari I was not getting the Show IP as seen in the screenshot below on page information.

OS: macOS 13.0
Browser: Safari 16.3, Chrome 111, Firefox 111
Environment: Local

BrowserShow IP Result
Safari 16.3
T331017_IPMasking_PageInfo_ShowIP_Safari.png (1×1 px, 242 KB)
Chrome 111
T331017_IPMasking_PageInfo_ShowIP_Chrome.png (1×1 px, 193 KB)
Firefox 111
T331017_IPMasking_PageInfo_ShowIP_FF.png (1×1 px, 203 KB)

@GMikesell-WMF , Hhhmm... i tested on Safari, am able to see the Show IP button.My Safari Version : Version 16.3 (17614.4.6.11.6, 17614)

@Cyndymediawiksim That is interesting because I have the Show IP button for Chrome and Firefox where they are designed, not just page information but nowhere in Safari 16.3 (18614.4.6.1.6). I mean it can't be my config and settings since the Show IP is visible everywhere for Chrome and Firefox, right? I wonder what could cause Show IP not to be not visible at all when I too have the latest Safari?

T331017_IPMasking_PageInfo_ShowIP_Safari2.png (1×2 px, 837 KB)

@Cyndymediawiksim Sorry this is on me, it was one of my settings in Safari that was causing the issue. It's resolved now as seen in the screenshot below for Safari. Moving this to Done. Thanks again for your help!

OS: macOS 13.2
Browser: Safari 16.3, Chrome 111, Firefox 111
Skins: Vector 2022, 2010, Timeless, Minerva, Monobook
Environment: Local

T331017_IPMasking_PageInfo_ShowIP_Safari3.png (1×1 px, 299 KB)