Page MenuHomePhabricator
Create Task
Maniphest T331052

Enable page tools for anonymous users
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Description

The page tools feature is enabled for logged in users but not anonymous users.
Enabling the feature for anonymous users will fix T313611.
There are some reservations about shipping this feature that Alex and Olga need to talk through

Note: Scheduled deployment date: Wednesday, March 22

TODO

  • Define blocking tasks as necessary

Acceptance criteria

  • Enable page tools for anonymous users
  • Update default in Vector skin

Sign off steps

  • Open task for removing feature flag and associated code for disabled state

QA Results - Prod

ACStatusDetails
1✅T331052#8726888
2✅T331052#8726888

Details

SubjectRepoBranchLines +/-
Enable page tools for anonymous usersoperations/mediawiki-configmaster+1 -6
Enable page tools for anonymous usersmediawiki/skins/Vectormaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedBUG REPORTNoneT331052 Enable page tools for anonymous users
 ResolvedFeatureNoneT331657 Enable pinning for anonymous users when page tools is enabled
 ResolvedBUG REPORTNoneT331563 Layout shift on small viewports from page tools

Event Timeline

Jdlrobson created this task.Mar 2 2023, 6:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2023, 6:25 PM
ovasileva triaged this task as High priority.Mar 9 2023, 3:55 PM
ovasileva moved this task from Incoming to Current Quarter on the Web-Team-Backlog board.
Jdlrobson added a project: Wikimedia-Site-requests.Mar 9 2023, 6:35 PM
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptMar 9 2023, 6:35 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5); removed Web-Team-Backlog.Mar 10 2023, 8:21 PM
ovasileva added a subtask: T331657: Enable pinning for anonymous users when page tools is enabled.Mar 13 2023, 5:43 PM
ovasileva added a subtask: T331563: Layout shift on small viewports from page tools.
ovasileva moved this task from Incoming to Blocked on Others on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.
LGoto set the point value for this task to 2.Mar 13 2023, 5:47 PM
LGoto moved this task from Blocked on Others to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.
ovasileva moved this task from Ready for Development to Blocked on Others on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.Mar 13 2023, 5:47 PM
Jdlrobson mentioned this in T332090: Post page tools cleanup: Remove page tools disabled code.Mar 14 2023, 9:42 PM
Jdlrobson added a subscriber: ovasileva.Mar 16 2023, 12:19 AM

@ovasileva I think this is unblocked? Both blocking tasks are in QA but presumably we can begin work on preparing the patches?

Jdlrobson moved this task from Blocked on Others to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.Mar 16 2023, 4:40 PM
ovasileva updated the task description. (Show Details)Mar 16 2023, 4:41 PM
• nray claimed this task.Mar 16 2023, 4:51 PM
• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.
gerritbot added a comment.Mar 17 2023, 7:51 PM

Change 900737 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Enable page tools for anonymous users

https://gerrit.wikimedia.org/r/900737

gerritbot added a project: Patch-For-Review.Mar 17 2023, 7:51 PM
• nray removed • nray as the assignee of this task.Mar 17 2023, 7:52 PM
• nray moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.
• nray subscribed.
gerritbot added a comment.Mar 17 2023, 8:47 PM

Change 900737 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Enable page tools for anonymous users

https://gerrit.wikimedia.org/r/900737

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 17 2023, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 17 2023, 9:10 PM
gerritbot added a comment.Mar 18 2023, 1:06 AM

Change 900748 had a related patch set uploaded (by Nray; author: Nray):

[operations/mediawiki-config@master] Enable page tools for anonymous users

https://gerrit.wikimedia.org/r/900748

gerritbot added a project: Patch-For-Review.Mar 18 2023, 1:06 AM
• nray moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.Mar 20 2023, 5:14 PM
• nray added a comment.Mar 20 2023, 6:24 PM

Moved this to block to wait for deployment date. When ready, the patches associated with T331657 should be backported first, followed by the config change to enable page tools for anons

Jdlrobson moved this task from Blocked on Others to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.Mar 22 2023, 4:28 PM
• nray claimed this task.Mar 22 2023, 6:47 PM
• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.
gerritbot added a comment.Mar 22 2023, 8:38 PM

Change 900748 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable page tools for anonymous users

https://gerrit.wikimedia.org/r/900748

Stashbot added a comment.Mar 22 2023, 8:54 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-22T20:54:50Z] <samtar@deploy2002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:900748|Enable page tools for anonymous users (T331052)]] (duration: 10m 10s)

Maintenance_bot removed a project: Patch-For-Review.Mar 22 2023, 9:10 PM
• nray reassigned this task from • nray to Edtadros.Mar 22 2023, 10:54 PM
• nray moved this task from Doing to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.
Edtadros closed this task as Resolved.Mar 26 2023, 2:26 AM
Edtadros removed Edtadros as the assignee of this task.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Enable page tools for anonymous users
✅ AC1: Update default in Vector skin

Screenshot 2023-03-25 at 7.24.45 PM.png (911×1 px, 421 KB)

Screenshot 2023-03-25 at 7.24.31 PM.png (804×1 px, 373 KB)

Edtadros updated the task description. (Show Details)Mar 26 2023, 2:27 AM
Edtadros closed subtask T331657: Enable pinning for anonymous users when page tools is enabled as Resolved.Mar 26 2023, 2:30 AM
Jdlrobson mentioned this in T313611: In vector-2022 the main menu becomes full screen width under 1000px.Mar 27 2023, 5:40 PM
Edtadros closed subtask T331563: Layout shift on small viewports from page tools as Resolved.Apr 1 2023, 11:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL