Page MenuHomePhabricator
Create Task
Maniphest T331657

Enable pinning for anonymous users when page tools is enabled
Closed, ResolvedPublic2 Estimated Story PointsFeature
Actions

Assigned To
None
Authored By
Jdlrobson
Mar 9 2023, 6:27 PM
Tags
Referenced Files
F36927871: Screen Recording 2023-03-25 at 7.29.57 PM.mov.gif
Mar 26 2023, 2:30 AM
F36927869: Screen Recording 2023-03-25 at 7.29.03 PM.mov.gif
Mar 26 2023, 2:30 AM
F36913804: Screen Recording 2023-03-15 at 5.57.00 PM.mov.gif
Mar 16 2023, 12:58 AM
F36913802: Screen Recording 2023-03-15 at 5.56.33 PM.mov.gif
Mar 16 2023, 12:58 AM
Subscribers
Aklapper
Edtadros
Iniquity
Jdlrobson
• nray
Nux
ovasileva

Description

Feature summary (what you would like to be able to do and where):

  • Enable pinning for anonymous users when page tools is enabled. Currently we hide the controls. We should show them.
  • There is no need to make the functionality persistent.

Benefits (why should this be implemented?):

Some power users would benefit from having a sticky page tools on the right hand side of the screen and easier access (scroll rather than click) to access the main menu.

QA steps

  1. Visit https://en.wikipedia.beta.wmflabs.org/wiki/Dog?vectorpagetools=1
  2. Open page tools menu in the page toolbar.
  3. Verify that the menu has the "move to sidebar" option and that it works.
  4. Open the main menu.
  5. Verify that the main menu has the "move to sidebar" option and that it works.

QA Results - Beta

ACStatusDetails
1✅T331657#8700648
2✅T331657#8700648

QA Results - Prod

ACStatusDetails
1✅T331657#8726893
2✅T331657#8726893

Details

SubjectRepoBranchLines +/-
Enable pinning for anon main menu when page tools is enabledmediawiki/skins/Vectorwmf/1.40.0-wmf.27+9 -10
Enable pinning for anon main menu when page tools is enabledmediawiki/skins/Vectormaster+9 -10
Enable the pinning for anonymous users when page tools is enabled.mediawiki/skins/Vectormaster+26 -19
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedBUG REPORTNoneT331052 Enable page tools for anonymous users
 ResolvedFeatureNoneT331657 Enable pinning for anonymous users when page tools is enabled

Event Timeline

Jdlrobson created this task.Mar 9 2023, 6:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2023, 6:27 PM
ovasileva triaged this task as High priority.Mar 9 2023, 6:29 PM
ovasileva moved this task from Incoming to Current Quarter on the Web-Team-Backlog board.
ovasileva set the point value for this task to 2.Mar 9 2023, 6:36 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5); removed Web-Team-Backlog.Mar 10 2023, 8:14 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.Mar 10 2023, 8:28 PM
ovasileva mentioned this in T329719: [Page tools] Allow anonymous users to pin / unpin menus, reconsider default pinning states.Mar 10 2023, 8:34 PM
ovasileva merged a task: T329719: [Page tools] Allow anonymous users to pin / unpin menus, reconsider default pinning states.
ovasileva added subscribers: Nux, ovasileva, Iniquity.
ovasileva added a parent task: T331052: Enable page tools for anonymous users.Mar 13 2023, 5:43 PM
• nray claimed this task.Mar 13 2023, 5:55 PM
• nray moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.
gerritbot added a comment.Mar 13 2023, 9:21 PM

Change 897998 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Enable the pinning for anonymous users when page tools is enabled.

https://gerrit.wikimedia.org/r/897998

gerritbot added a project: Patch-For-Review.Mar 13 2023, 9:21 PM
• nray removed • nray as the assignee of this task.Mar 13 2023, 9:24 PM
• nray moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.
• nray subscribed.
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.Mar 13 2023, 11:30 PM
Jdlrobson moved this task from QA to Needs More Work on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.Mar 13 2023, 11:53 PM

I might be wrong but I'm not seeing the pinning functionality in the main menu, only in page tools. It's late in my day so I'll check again tomorrow. Maybe I've got my local setup in a muddle.

gerritbot added a comment.Mar 14 2023, 12:39 AM

Change 897998 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Enable the pinning for anonymous users when page tools is enabled.

https://gerrit.wikimedia.org/r/897998

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.27; 2023-03-13).Mar 14 2023, 1:01 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 14 2023, 1:10 AM
gerritbot added a comment.Mar 14 2023, 3:27 PM

Change 898782 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Enable pinning for anon main menu whenn page tools is enabled

https://gerrit.wikimedia.org/r/898782

gerritbot added a project: Patch-For-Review.Mar 14 2023, 3:27 PM
• nray added a comment.Mar 14 2023, 3:30 PM
In T331657#8690150, @Jdlrobson wrote:

I might be wrong but I'm not seeing the pinning functionality in the main menu, only in page tools. It's late in my day so I'll check again tomorrow. Maybe I've got my local setup in a muddle.

Oh, I thought this ticket was only enabling pinning for the page tools menu. If the main menu is also needed, 898782 should take care of that

• nray moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.Mar 14 2023, 3:30 PM
Jdlrobson claimed this task.Mar 14 2023, 4:33 PM
gerritbot added a comment.Mar 14 2023, 9:12 PM

Change 898782 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Enable pinning for anon main menu when page tools is enabled

https://gerrit.wikimedia.org/r/898782

Maintenance_bot removed a project: Patch-For-Review.Mar 14 2023, 9:30 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.Mar 14 2023, 9:35 PM
Jdlrobson reassigned this task from Jdlrobson to Edtadros.Mar 14 2023, 9:37 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 14 2023, 10:00 PM
• nray claimed this task.Mar 15 2023, 8:48 PM
• nray added a subscriber: Edtadros.

@Edtadros I will add QA steps, sorry for not including them earlier

• nray reassigned this task from • nray to Edtadros.Mar 15 2023, 9:57 PM
• nray updated the task description. (Show Details)
Edtadros reassigned this task from Edtadros to ovasileva.Mar 16 2023, 12:58 AM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Dog?vectorpagetools=1
Open page tools menu in the page toolbar.
✅ AC1: Verify that the menu has the "move to sidebar" option and that it works.

Screen Recording 2023-03-15 at 5.56.33 PM.mov.gif (932×1 px, 736 KB)

Open the main menu.
✅ AC2: Verify that the main menu has the "move to sidebar" option and that it works.

Screen Recording 2023-03-15 at 5.57.00 PM.mov.gif (932×1 px, 696 KB)

Edtadros updated the task description. (Show Details)Mar 16 2023, 12:59 AM
ovasileva moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.Mar 20 2023, 3:30 PM
ovasileva reassigned this task from ovasileva to Edtadros.Mar 20 2023, 6:03 PM
ovasileva moved this task from QA in Production to Ready for Signoff on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.
ovasileva moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 5) board.
• nray mentioned this in T331052: Enable page tools for anonymous users.Mar 20 2023, 6:24 PM
gerritbot added a comment.Mar 22 2023, 6:47 PM

Change 902150 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@wmf/1.40.0-wmf.27] Enable pinning for anon main menu when page tools is enabled

https://gerrit.wikimedia.org/r/902150

gerritbot added a project: Patch-For-Review.Mar 22 2023, 6:47 PM
gerritbot added a comment.Mar 22 2023, 8:17 PM

Change 902150 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.40.0-wmf.27] Enable pinning for anon main menu when page tools is enabled

https://gerrit.wikimedia.org/r/902150

Stashbot added a comment.Mar 22 2023, 8:24 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-22T20:24:51Z] <samtar@deploy2002> Started scap: Backport for [[gerrit:902150|Enable pinning for anon main menu when page tools is enabled (T331657)]]

Stashbot added a comment.Mar 22 2023, 8:28 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-22T20:28:29Z] <samtar@deploy2002> samtar and nray: Backport for [[gerrit:902150|Enable pinning for anon main menu when page tools is enabled (T331657)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet

Maintenance_bot removed a project: Patch-For-Review.Mar 22 2023, 8:30 PM
Stashbot added a comment.Mar 22 2023, 8:36 PM

Mentioned in SAL (#wikimedia-operations) [2023-03-22T20:36:39Z] <samtar@deploy2002> Finished scap: Backport for [[gerrit:902150|Enable pinning for anon main menu when page tools is enabled (T331657)]] (duration: 11m 47s)

Edtadros closed this task as Resolved.Mar 26 2023, 2:30 AM
Edtadros removed Edtadros as the assignee of this task.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.org/wiki/Dog?vectorpagetools=1
Open page tools menu in the page toolbar.
✅ AC1: Verify that the menu has the "move to sidebar" option and that it works.

Screen Recording 2023-03-25 at 7.29.03 PM.mov.gif (1×1 px, 822 KB)

Open the main menu.
✅ AC2: Verify that the main menu has the "move to sidebar" option and that it works.

Screen Recording 2023-03-25 at 7.29.57 PM.mov.gif (1×1 px, 647 KB)

Edtadros updated the task description. (Show Details)Mar 26 2023, 2:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL