Given the resource constraints we face for Q1 and Q2 there is a pressing need for the engineering work to pick up on this fairly soon. In terms of kicking that work off, I'd like to set an expectation following a discussion between the various apps managers that we'd like to lock in the current scope and have any further design changes for the initial implementation be limited limited to color, typography and icon updates. If there are any flow changes or additional features to be proposed, that should go to product and engineering for discussion and estimation.

@OTichonova We are nearing the end of native editor. Can we confirm final designs for this entry point? Thanks!

@OTichonova In the interest of time, would it be okay to leave the existing internet connection error handling on the Publish page? It looks like this:

Part 1 PR: https://github.com/wikimedia/wikipedia-ios/pull/4721

Hi @Tsevener!

In T331935#9470308, @Tsevener wrote:

We are nearing the end of native editor. Can we confirm final designs for this entry point? Thanks!

Keeping the entry point from the overflow menu from the toolbar.
@JTannerWMF

In T331935#9479112, @Tsevener wrote:

In the interest of time, would it be okay to leave the existing internet connection error handling on the Publish page?

Sounds good to me.

Hi @Tsevener,
Very exciting changes! Some minor comments.

1. T331936#9485275

Similar comment about action sheet rather than the model when people try to tap out after editing (without publishing).

Current	Action sheet

2. Small copy update, can it say 'Edit source' rather than edit article, sorry didn't check the talk page ticket before updating the screen yesterday and it would be good to have he copy consistent.

Updated copy

3. I had a hard time tapping out in the article and talk page editor (had to tap the 'x' multiple times to leave).

@OTichonova would it be okay if I use an SFSymbol for the close icon? The tap area is much better for that. I will make an experimental build for you to test out before my EOD.

@Tsevener, yes works for me.

@OTichonova

Here's a couple of screenshots of the action sheet. Note I'm setting the "keep editing" button as a cancel style, which bolds and separates it on iPhone. On iPad it removes it entirely, since popovers can be dismissed by tapping elsewhere. If you want I could use a default style which would unbold and force the button to remain on both.

@OTichonova

Kicked off a new experimental build with these changes (#73).

Hi @Tsevener, thank you for screenshots!
The point of the sheet is to inform the editor that their edit will not be saved, so it does that in both cases. I think we can keep the sheet/popover as you have it above.
Who knows, maybe one day we could add a 'Save draft' option to it for offline editing.

Looks good to me on 7.4.7 (3162), however, I am not seeing Internet Connection issues with the link to settings. Testing on iPhone 12 on iOS 17.4 and iPad Pro 12.9 on iOS 17.4.

@ABorbaWMF Sorry this was a bit buried in the comments, but I asked if we could use our existing stuff here, currently we don't display a Settings link in our internet connection error banners. - https://phabricator.wikimedia.org/T331935#9479112.