Replace `line-height-heading`'s 1.3 by 1.375
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Volker_E
	Mar 15 2023, 1:03 PM

Description

Background

Coming from newly established Codex Figma font definitions, and in relations to parent tasks, we should settle on 1.375 for headings' line-height across products instead of current 1.3.

CodeSearch: https://codesearch-beta.wmcloud.org/search/?q=%40line-height-heading&files=&excludeFiles=&repos=

Example in legacy Vector

before	with 1.375

Example in Vector 2022

before	with 1.375

We're talking about an increase from 37.44px to 39.6px. This should not cause any side-effects.

Acceptance criteria for done

Replace 1.3 by 1.375 in all occurrences

Details

Other Assignee: Volker_E

	Subject	Repo	Branch	Lines +/-
	styles: Increase `line-heading-heading` slightly to follow Codex	mediawiki/skins/Vector	master	+1 -1
	Increase `line-height-heading` slightly to follow Codex	wikimedia-ui-base	master	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T331403 Replace legacy value tokens in Codex, OOUI and downstream; originated in WikimediaUI Base
		Resolved		Volker_E	T332171 Replace `line-height-heading`'s 1.3 by 1.375

Event Timeline

Volker_E created this task.Mar 15 2023, 1:03 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMar 15 2023, 1:03 PM

Volker_E updated the task description. (Show Details)Mar 15 2023, 1:04 PM

Change 899617 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] styles: Increase `line-heading-heading` slightly to follow Codex

https://gerrit.wikimedia.org/r/899617

gerritbot added a project: Patch-For-Review.Mar 15 2023, 1:07 PM

Change 899618 had a related patch set uploaded (by VolkerE; author: VolkerE):

[wikimedia-ui-base@master] Increase `line-height-heading` slightly to follow Codex

https://gerrit.wikimedia.org/r/899618

Change 899618 merged by jenkins-bot:

[wikimedia-ui-base@master] Increase `line-height-heading` slightly to follow Codex

https://gerrit.wikimedia.org/r/899618

Volker_E mentioned this in rWMUI6f33063f4fbe: Increase `line-height-heading` slightly to follow Codex.Mar 15 2023, 6:44 PM

Volker_E moved this task from Inbox to Design-System-Sprint on the Design-System-Team board.Mar 16 2023, 3:46 PM

Volker_E edited projects, added Design-System-Team (Design-System-Sprint); removed Design-System-Team.

Restricted Application triaged this task as High priority. · View Herald TranscriptMar 16 2023, 3:46 PM

Volker_E changed the task status from Open to Stalled.Mar 16 2023, 5:33 PM

Volker_E moved this task from Committed to Blocked ⛔ on the Design-System-Team (Design-System-Sprint) board.

Assuming this is blocked on web team. If so, adding to our backlog to make sure @ovasileva sees this request. Please let me know if I've misunderstood.

@Jdlrobson That's correct. Also brought to attention of @KieranMcCann and @RHo already. Note that this (small) change would also unblock a small technical debt in the Codex tokens application IMO easily resolvable.

Jdlrobson mentioned this in T316950: [Visual refinements] Reduce height of article toolbar.Mar 20 2023, 4:47 PM

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Mar 20 2023, 4:52 PM

Jdlrobson moved this task from Not ready to estimate to Current Quarter on the Web-Team-Backlog board.Mar 20 2023, 8:58 PM

LGoto set the point value for this task to 2.Mar 23 2023, 5:38 PM

ovasileva edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6); removed Web-Team-Backlog.Mar 27 2023, 3:12 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.Mar 27 2023, 5:19 PM

Jdlrobson claimed this task.Mar 27 2023, 8:52 PM

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.

Jdlrobson reassigned this task from Jdlrobson to • KieranMcCann.Mar 29 2023, 12:27 AM

Jdlrobson moved this task from Code Review to Design Review on the Web-Team-Backlog (Web Team FY2022-23 Q3 Sprint 6) board.

Change 899617 merged by jenkins-bot:

[mediawiki/skins/Vector@master] styles: Increase `line-heading-heading` slightly to follow Codex