Page MenuHomePhabricator
Create Task
Maniphest T333872

Mobile reply tool doesn't expand the relevant section when recovering autosaved changes
Closed, ResolvedPublic
Actions

Description

Mobile reply tool doesn't expand the relevant section when recovering autosaved changes. You can't expand it manually either, so that makes the reply almost completely inaccessible.

This seems to be the result of T320753 + T322628. We didn't consider how these changes would work together.

Details

SubjectRepoBranchLines +/-
Toggler: Ignore collapsible-heading-disabled when restoring from saved statemediawiki/extensions/MobileFrontendmaster+6 -5
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Apr 3 2023, 7:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 3 2023, 7:15 PM
matmarex added a project: Editing-team (Kanban Board).Apr 13 2023, 11:51 PM
Esanders added a comment.Apr 14 2023, 3:06 PM

I think this only happens if you recover in a new tab. We "upgraded" to localStorage, whereas MobileFrontend still uses sessionStorage for remembering which sections are expanded.

matmarex added a comment.Apr 14 2023, 6:03 PM

Ordinarily it does, but we disable this behavior in DiscussionTools. I can reproduce the problem by just refreshing the page after typing a comment.

matmarex moved this task from Backlog to Triaged on the DiscussionTools board.Apr 20 2023, 2:57 PM
Esanders added a comment.Apr 24 2023, 2:24 PM
In T333872#8782655, @matmarex wrote:

Ordinarily it does, but we disable this behavior in DiscussionTools. I can reproduce the problem by just refreshing the page after typing a comment.

We don't disable it, but it doesn't work when the page is wide (which it will be if you are testing on desktop).

It appears when the page is narrow we just add the disabling class too early.

gerritbot added a comment.Apr 24 2023, 2:29 PM

Change 911318 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] Ignore collapsible-heading-disabled when restoring from saved state

https://gerrit.wikimedia.org/r/911318

gerritbot added a project: Patch-For-Review.Apr 24 2023, 2:29 PM
Esanders added a comment.Apr 24 2023, 2:31 PM

^ The above patch fixes narrow mobile. We have a slightly broader problem on wide mobile, as the MF code assumes that sections are never auto-collapsed, so doesn't try to restore expanded selections.

matmarex merged a task: T335245: Mobile version: Can't resume unsaved (or any) comment because collapsed heading can't be expanded.Apr 24 2023, 3:35 PM
matmarex added subscribers: FrankGeerlings, Mbch331.
gerritbot added a comment.Apr 25 2023, 3:58 PM

Change 911318 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Toggler: Ignore collapsible-heading-disabled when restoring from saved state

https://gerrit.wikimedia.org/r/911318

Maintenance_bot removed a project: Patch-For-Review.Apr 25 2023, 4:10 PM
matmarex added a comment.Apr 25 2023, 4:46 PM
In T333872#8801769, @Esanders wrote:

We have a slightly broader problem on wide mobile, as the MF code assumes that sections are never auto-collapsed, so doesn't try to restore expanded selections.

Is this fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/911324?

matmarex moved this task from Incoming to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Apr 25 2023, 4:46 PM
Esanders added a comment.Apr 27 2023, 3:36 PM
In T333872#8805301, @matmarex wrote:
In T333872#8801769, @Esanders wrote:

We have a slightly broader problem on wide mobile, as the MF code assumes that sections are never auto-collapsed, so doesn't try to restore expanded selections.

Is this fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/911324?

Yes

matmarex moved this task from Blocked / Needs More Work to QA on the Editing-team (Kanban Board) board.Apr 27 2023, 5:06 PM
matmarex added a project: Editing QA.
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.May 1 2023, 9:58 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
matmarex closed this task as Resolved.May 2 2023, 10:58 PM
matmarex assigned this task to Esanders.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 9:02 PM
matmarex reopened this task as Open.Jun 13 2023, 4:55 PM
matmarex merged a task: T338920: Discussion tool saved answer not accessible on mobile when multiple pages are included.
matmarex moved this task from Ready for Sign Off to Ready to Be Worked On on the Editing-team (Kanban Board) board.
matmarex removed projects: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Verified.
matmarex added a subscriber: Escargot_rouge.

Either we missed something, or this broke again. I can reproduce the bug in the duplicate report.

Esanders added a comment.Jun 14 2023, 4:43 PM

I think the original bug here was that it was never working. The new bug is about the localStorage vs sessionStorage issue.

Esanders closed this task as Resolved.Jun 14 2023, 5:03 PM
Esanders mentioned this in T338920: Discussion tool saved answer not accessible on mobile when multiple pages are included.

Re-opened T338920 instead

matmarex moved this task from Ready to Be Worked On to Ready for Sign Off on the Editing-team (Kanban Board) board.Jun 14 2023, 6:50 PM
matmarex added projects: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Verified.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL