Page MenuHomePhabricator
Create Task
Maniphest T334377

DefaultView Widgets: Create a Function Explorer widget for the implementation page
Closed, ResolvedPublic
Actions

Assigned To
allanjeremy.thisdot
Authored By
gengh
Apr 10 2023, 9:12 AM
Tags
Referenced Files
F36947217: CleanShot 2023-04-11 at 19.15.45@2x.png
Apr 11 2023, 5:16 PM
F36947211: CleanShot 2023-04-11 at 19.13.37@2x.png
Apr 11 2023, 5:16 PM
F36947205: CleanShot 2023-04-11 at 19.11.12@2x.png
Apr 11 2023, 5:16 PM
Subscribers
AAlhazwani-WMF
gengh

Description

Description

Function Explorer is a component that provides additional information about a selected function to help the contributor through the experience of creating or editing a function implementation (code or composition)

Desired behavior/Acceptance criteria

  • The function explorer can take an input Function ZID
    • The function zid should be checked for validity (does it exist? is it a function?) as it can be set from the url parameters (E.g. "Special:CreateZObject&zid=Z14&Z14K1=Z99999"
    • If the provided function zid is not found or not a function, initialize the widget empty
  • The function explorer should also have an empty state (no selected function)
  • The function explorer has a static mode (only info) and a searchable mode
  • Function explorer static mode:
    • shown on implementation view page ?? (need @AAlhazwani-WMF input)
    • the function shown is the zid on Z14K1 (Implementation function id)
  • Function searchable mode:
    • shown on implementation edit page ?? (need @AAlhazwani-WMF input)
    • initialized with the function zid on Z14K1 (Implementation function id)
    • lookup field can search and select other functions to aid during implementation creation/edit

Devices and Design (URLs or screenshots)

https://www.figma.com/file/q9ZFXjK0PXqLhLXVaqXuT7/T-Function-explorer?node-id=0%3A1&t=ePR8NpIJnNuhJ9hz-1

Completion checklist

Details

SubjectRepoBranchLines +/-
DefaultView Widgets: Create a Function explorer widget for the implementation pagemediawiki/extensions/WikiLambdamaster+911 -10
DefaultView Widgets: Create a Function Explorer widget for the implementation pagemediawiki/extensions/WikiLambdamaster+761 -19
]Feat: DefaultView Widgets: Create a Function Explorer widget for the implementation pagemediawiki/extensions/WikiLambdamaster+383 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

gengh created this task.Apr 10 2023, 9:12 AM
Jdforrester-WMF moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Apr 10 2023, 3:51 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready: G5. Fallback view on the Abstract Wikipedia team (Phase θ – Throttling) board.Apr 10 2023, 3:53 PM
AAlhazwani-WMF added a comment.Apr 11 2023, 5:16 PM

hello hello! i updated the figma file attached in the task description in order to take into account the following suggestions:

  • function explorer static mode. when viewing an implementation in "read" mode we don't display the function being implemented as a function selector.

CleanShot 2023-04-11 at 19.11.12@2x.png (1×2 px, 148 KB)

  • function explorer searchable mode. when viewing an implementation in "edit source" mode we display the function being implemented as a function selector.

CleanShot 2023-04-11 at 19.13.37@2x.png (1×2 px, 229 KB)

  • function explorer reset button. when editors select a different function from the one being implemented, we enable them to switch back to the original function via a reset button.

CleanShot 2023-04-11 at 19.15.45@2x.png (1×1 px, 152 KB)

AAlhazwani-WMF updated the task description. (Show Details)Apr 11 2023, 5:16 PM
gerritbot added a comment.Apr 18 2023, 6:03 PM

Change 909721 had a related patch set uploaded (by AllanJeremy (ThisDot); author: AllanJeremy (ThisDot)):

[mediawiki/extensions/WikiLambda@master] Feat: DefaultView Widgets: Create a Function Explorer widget for the implementation page

https://gerrit.wikimedia.org/r/909721

gerritbot added a project: Patch-For-Review.Apr 18 2023, 6:03 PM
gerritbot added a comment.May 8 2023, 9:23 AM

Change 909721 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] ]Feat: DefaultView Widgets: Create a Function Explorer widget for the implementation page

Reason:

Development has moved to I80e4cc20784595d3207c4fd450246d5a130070ed.

https://gerrit.wikimedia.org/r/909721

gerritbot added a comment.May 8 2023, 9:24 AM

Change 913958 had a related patch set uploaded (by Jforrester; author: AllanJeremy (ThisDot)):

[mediawiki/extensions/WikiLambda@master] DefaultView Widgets: Create a Function Explorer widget for the implementation page

https://gerrit.wikimedia.org/r/913958

AAlhazwani-WMF assigned this task to allanjeremy.thisdot.May 8 2023, 12:50 PM
gerritbot added a comment.May 8 2023, 2:25 PM

Change 917348 had a related patch set uploaded (by Jforrester; author: AllanJeremy (ThisDot)):

[mediawiki/extensions/WikiLambda@master] DefaultView Widgets: Create a Function Explorer widget for the implementation page

https://gerrit.wikimedia.org/r/917348

gerritbot added a comment.May 9 2023, 2:55 PM

Change 913958 had a related patch set uploaded (by Jforrester; author: AllanJeremy (ThisDot)):

[mediawiki/extensions/WikiLambda@master] DefaultView Widgets: Create a Function Explorer widget for the implementation page

https://gerrit.wikimedia.org/r/913958

gerritbot added a comment.May 9 2023, 2:55 PM

Change 917348 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] DefaultView Widgets: Create a Function Explorer widget for the implementation page

Reason:

Folded back into I80e4cc20784595d3207c4fd450246d5a130070ed.

https://gerrit.wikimedia.org/r/917348

gerritbot added a comment.May 17 2023, 2:49 PM

Change 913958 had a related patch set uploaded (by Jforrester; author: AllanJeremy (ThisDot)):

[mediawiki/extensions/WikiLambda@master] DefaultView Widgets: Create a Function explorer widget for the implementation page

https://gerrit.wikimedia.org/r/913958

gerritbot added a comment.May 17 2023, 3:02 PM

Change 913958 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] DefaultView Widgets: Create a Function explorer widget for the implementation page

https://gerrit.wikimedia.org/r/913958

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 17 2023, 4:00 PM
AAlhazwani-WMF moved this task from Ready: G5. Fallback view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.May 22 2023, 1:51 PM
Jdforrester-WMF moved this task from Phase θ – Throttling to Phase λ – Launch on the Abstract Wikipedia team board.Jun 16 2023, 9:05 AM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase λ – Launch); removed Abstract Wikipedia team (Phase θ – Throttling).
Jdforrester-WMF moved this task from Incoming to In progress on the Abstract Wikipedia team (Phase λ – Launch) board.Jun 16 2023, 9:40 AM
Jdforrester-WMF added a parent task: T324802: Phase θ Goal 5: Fallback view.Jun 20 2023, 7:03 PM
gengh moved this task from In progress to QA needed on the Abstract Wikipedia team (Phase λ – Launch) board.Jul 12 2023, 8:32 AM
DVrandecic closed this task as Resolved.Jul 19 2023, 3:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL