Page MenuHomePhabricator
Create Task
Maniphest T340774

e2e tests for DefaultView: Fix and re-enable once DefaultView is fully finished
Closed, ResolvedPublic
Actions

Description

Description

Some e2e tests are currently testing Implementation and Tester pages, and Evaluate Function widgets, which are currently going through some structural changes.

Once the following tasks are finished:

We can re-activate the tests and work on fixing them.

Tests to fix:

  • specs/function.js
    • should allow to evaluate a function
  • specs/implementation.js
    • Implementation via composition
      • should navigate to the implementation form
      • should fill the entries in the about section
      • should fill the entries in the composition block
      • should publish the new implementation
      • should display the entries in the about section
  • specs/tester.js
    • should display the call function block parameters
    • should display the validation block parameters
  • specs/type.js
    • should fill the entries in the keys block
  • specs/connect.js (stopped working with new Function Evaluator path 934407)
    • Normal user:
      • Connect implementation
        • should open the "Detail" view of the function page
        • should not be able to either approve or deactivate the implementation
      • Connect tester
        • should open the "Detail" view of the function page
        • should not be able to approve or deactivate the test case

Completion checklist

Details

SubjectRepoBranchLines +/-
e2e: Enable the tests againmediawiki/extensions/WikiLambdamaster+98 -123
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNik.xyz.inT340774 e2e tests for DefaultView: Fix and re-enable once DefaultView is fully finished
 ResolvedDVrandecicT324802 Phase θ Goal 5: Fallback view
 ResolvedBUG REPORTTeleosteenT321901 ZObjectSelector: throws a console error on the typeUrl function
 Declined• SWoodruff-WMFT285422 Function editor: User education, interface copy, notifications and alerts
 ResolvedBUG REPORT• AdesojiThisDotT323055 ZLabelsBlock: Saving and loading empty string aliases
 Resolved• JKiesermanT315099 zObject creation: errors / blockers to saving are not surfaced well or at all
 Resolved• SWoodruff-WMFT315002 Error handling in the front-end after returning the response for every API
 Resolved• JKiesermanT320269 Don't disable buttons on failed validation, instead, surface errors and highlight missing fields when button is clicked
 Resolved• JKiesermanT321401 Catch missing ZTester and ZImplementation properties with FE error management
 Resolved• JKiesermanT321404 update cdx-text-input to use native codex error state as part of FE error management
 InvalidNoneT321623 modify error message system to accomodate links and special formatting
 ResolvedDdwaalT321381 Publish component: Create a publish component used in all Wikifunctions create and edit pages
 ResolvedDdwaalT321739 Handle shouldUnattachImplementationTester passed to this.submitZObject in the PublishDialog
 ResolvedDdwaalT321741 Add a success snackbar to the redirect page after successful zObject creation.
 ResolvedDdwaalT321742 Replace mock data with error data from the store
 InvalidDdwaalT321743 Trigger check for error warnings in ZObjectPublish
 ResolvedDdwaalT321744 Make the publish component mobile friendly
 InvalidDdwaalT322265 Look into linking to implementation and tester page on warning
 ResolvedgenghT317556 Design and implement: evaluate a function
 Resolvedallanjeremy.thisdotT334377 DefaultView Widgets: Create a Function Explorer widget for the implementation page
 ResolvedgenghT339956 Fix default view regressions after merging the typed list component
 ResolvedBUG REPORTgenghT339876 About widget: When create new page, Name/Labels field doesn't show "Untitled"

Event Timeline

gengh created this task.Jun 29 2023, 5:21 PM
Jdforrester-WMF moved this task from To triage to Phase λ – Launch on the Abstract Wikipedia team board.Jun 29 2023, 5:48 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase λ – Launch); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Engineering tasks on the Abstract Wikipedia team (Phase λ – Launch) board.
gengh updated the task description. (Show Details)Jun 29 2023, 6:01 PM
Nik.xyz.in claimed this task.Jun 30 2023, 5:10 AM
gengh mentioned this in T317556: Design and implement: evaluate a function.Jun 30 2023, 9:11 AM
Jdforrester-WMF added a subtask: T324802: Phase θ Goal 5: Fallback view.Jun 30 2023, 4:18 PM
Jdforrester-WMF subscribed.

Marked as blocked by T324802 as a proxy for all that work.

gengh updated the task description. (Show Details)Jul 5 2023, 5:18 PM
Nik.xyz.in added a comment.Jul 7 2023, 10:00 AM

@gengh could you let me know if I can start fixing the e2e tests once 934407 is merged or there is more UI updates going to be done on default view?

gengh added a comment.Jul 7 2023, 10:41 AM

@Nik.xyz.in yes, I believe after this patch we can safely fix the e2e tests.

Other tasks might slightly alter things:

  • T340733 will fix error reporting in the Publish Dialog
  • T336877 introducing a "Cancel" button in the Publish widget
  • T336984 on implementation - composition, in the collapsed view of the function call, instead of showing the argument reference keys, we will show the labels:

Screenshot from 2023-07-07 12-38-21.png (115×692 px, 17 KB)

But I think these changes are very little that should not significantly affect the e2e tests

gerritbot added a comment.Jul 9 2023, 5:16 AM

Change 935878 had a related patch set uploaded (by Nik.xyz.in; author: Nik.xyz.in):

[mediawiki/extensions/WikiLambda@master] e2e: Enable the tests again

https://gerrit.wikimedia.org/r/935878

gerritbot added a project: Patch-For-Review.Jul 9 2023, 5:16 AM
Jdforrester-WMF changed the task status from Open to In Progress.Jul 10 2023, 2:32 PM
Jdforrester-WMF moved this task from Engineering tasks to In progress on the Abstract Wikipedia team (Phase λ – Launch) board.
gerritbot added a comment.Jul 11 2023, 2:21 PM

Change 935878 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] e2e: Enable the tests again

https://gerrit.wikimedia.org/r/935878

Maintenance_bot removed a project: Patch-For-Review.Jul 11 2023, 2:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 11 2023, 3:00 PM
Jdforrester-WMF moved this task from In progress to QA needed on the Abstract Wikipedia team (Phase λ – Launch) board.Jul 11 2023, 3:50 PM
DVrandecic closed this task as Resolved.Jul 12 2023, 1:00 AM
DVrandecic subscribed.

Thank you Nikhil!

DVrandecic closed subtask T324802: Phase θ Goal 5: Fallback view as Resolved.Jul 27 2023, 2:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits