Page MenuHomePhabricator
Create Task
Maniphest T317556

Design and implement: evaluate a function
Closed, ResolvedPublic
Actions

Description

Discovery and definition

https://www.notion.so/wikimediadesign/Function-evaluator-69475792956b45b1a106791b9dce80dd?pvs=4

Research and plan
- [ ] Conduct first round of usability testing with 2–3 variants of design proposals, being sure to center target audiences and measuring impact on accessibility goals and guardrails. Surface possible biases in user testing
- [ ] Share outcomes of usability testing with internal and external stakeholders

Design and develop

  • High fidelity design proposal with variants

- [ ] Share design updates (metawiki, newsletter)
- [ ] Ask for community input

Figma file

Widget anatomy

image.png (1×2 px, 354 KB)

Example pages

image.png (890×2 px, 221 KB)

Engineering

  • Replace old components with new ones
  • Implement new design/structure changes
  • Tests:
    • Unit tests (as part of this task)
    • Integration test: T318416
    • Fix e2e tests: T340774

Test and iterate

  • Test concept via an Alpha, Beta or Prototype with partner communities and those potentially impacted by feature, in their preferred language

Implement and refine

  • Design review on updated software

Completion checklist
Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Design_Task_Completion_Checklist

Details

SubjectRepoBranchLines +/-
Implement new Function Evaluator widget designmediawiki/extensions/WikiLambdamaster+1 K -572
Customize query in gerrit

Related Objects
Search...

Event Timeline

AAlhazwani-WMF created this task.Sep 12 2022, 5:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2022, 5:22 PM
AAlhazwani-WMF mentioned this in T316552: Tests: Add proper FE integration tests for most important use case(s).Sep 12 2022, 5:25 PM
EWright mentioned this in T318416: Tests: Implement Function Evaluator widget integration test for evaluating a function.Sep 23 2022, 1:15 PM
Jdforrester-WMF added a parent task: T318922: CUJ 1: Evaluate a function.Oct 3 2022, 3:45 PM
AAlhazwani-WMF renamed this task from Function Viewer: Design the Evaluate Function experience to Evaluate a function experience design.Nov 25 2022, 9:55 AM
AAlhazwani-WMF updated the task description. (Show Details)
AAlhazwani-WMF renamed this task from Evaluate a function experience design to Design : evaluate a function.Nov 25 2022, 10:19 AM
AAlhazwani-WMF updated the task description. (Show Details)Nov 25 2022, 10:34 AM
AAlhazwani-WMF edited projects, added Abstract Wikipedia team; removed WikiLambda Front-end, Abstract Wikipedia team (Phase θ – Throttling).Nov 25 2022, 10:46 AM
AAlhazwani-WMF renamed this task from Design : evaluate a function to Design: evaluate a function.Nov 25 2022, 5:09 PM
AAlhazwani-WMF removed a project: Design.
AAlhazwani-WMF added a project: Design.
Jdforrester-WMF subscribed.Nov 29 2022, 7:42 PM

Amin, this work appears to be re-design for work already done. Are you suggesting doing that before launch, or is this a placeholder for most of the work already done?

AAlhazwani-WMF moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Dec 19 2022, 2:14 PM
AAlhazwani-WMF edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
AAlhazwani-WMF moved this task from Ready: G4. Function view to Ready: G10. Function calls UX on the Abstract Wikipedia team (Phase θ – Throttling) board.
AAlhazwani-WMF updated the task description. (Show Details)Dec 19 2022, 5:38 PM
AAlhazwani-WMF added a subtask: T296697: Build out a conceptual design model to support "A user needs a way to use a function i.e. ask a question, and receive an answer".
Etonkovidova mentioned this in T331077: [QA - task] wikifunction mobile UI issues.Mar 3 2023, 6:23 PM
Jdforrester-WMF added a parent task: T324802: Phase θ Goal 5: Fallback view.Jun 14 2023, 12:42 PM
Jdforrester-WMF moved this task from Phase θ – Throttling to Phase λ – Launch on the Abstract Wikipedia team board.Jun 16 2023, 8:47 AM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase λ – Launch); removed Abstract Wikipedia team (Phase θ – Throttling).
Jdforrester-WMF moved this task from Incoming to Engineering tasks on the Abstract Wikipedia team (Phase λ – Launch) board.Jun 16 2023, 8:53 AM
Jdforrester-WMF removed a subtask: T296697: Build out a conceptual design model to support "A user needs a way to use a function i.e. ask a question, and receive an answer".Jun 20 2023, 12:52 PM
Jdforrester-WMF added a parent task: T318416: Tests: Implement Function Evaluator widget integration test for evaluating a function.Jun 21 2023, 3:08 PM
AAlhazwani-WMF changed the task status from Open to In Progress.Jun 22 2023, 12:52 PM
AAlhazwani-WMF claimed this task.
Jdforrester-WMF moved this task from Engineering tasks to In progress on the Abstract Wikipedia team (Phase λ – Launch) board.Jun 22 2023, 1:08 PM
gengh mentioned this in T340774: e2e tests for DefaultView: Fix and re-enable once DefaultView is fully finished.Jun 29 2023, 5:21 PM
gengh subscribed.Jun 29 2023, 5:35 PM

Design reviewed and approved, available in https://www.figma.com/file/K0yOWUesk54JZC3MoNsAhv/T317556-Function-evaluator?type=design&node-id=90-8170&mode=design&t=nIv91N7oUIArSsm8-0

Jdforrester-WMF added a comment.Jun 29 2023, 6:04 PM
In T317556#8977421, @gengh wrote:

Design reviewed and approved, available in https://www.figma.com/file/K0yOWUesk54JZC3MoNsAhv/T317556-Function-evaluator?type=design&node-id=90-8170&mode=design&t=nIv91N7oUIArSsm8-0

Let's move implementation up to T318922 then?

gerritbot added a comment.Jun 29 2023, 7:49 PM

Change 934407 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] [WIP] Implement new Function Evaluator widget design

https://gerrit.wikimedia.org/r/934407

gerritbot added a project: Patch-For-Review.Jun 29 2023, 7:49 PM
AAlhazwani-WMF updated the task description. (Show Details)Jun 30 2023, 8:55 AM
AAlhazwani-WMF updated the task description. (Show Details)
gengh added a comment.Jun 30 2023, 9:03 AM

@Jdforrester-WMF I think we would prefer to do the development under this task to have some continuity Design-Implementation.

@AAlhazwani-WMF is now adding more details to the description, I will change the name to s/Design/Create/ and add a couple of details for implementation and assign it to myself.

gengh renamed this task from Design: evaluate a function to Design and implement: evaluate a function.Jun 30 2023, 9:11 AM
gengh updated the task description. (Show Details)
gengh edited projects, added WikiLambda, WikiLambda Front-end; removed Design.Jun 30 2023, 9:16 AM
AAlhazwani-WMF reassigned this task from AAlhazwani-WMF to gengh.Jul 3 2023, 1:39 PM
AAlhazwani-WMF updated the task description. (Show Details)
gengh updated the task description. (Show Details)Jul 5 2023, 5:32 PM
gerritbot added a comment.Jul 7 2023, 4:41 PM

Change 934407 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Implement new Function Evaluator widget design

https://gerrit.wikimedia.org/r/934407

Maintenance_bot removed a project: Patch-For-Review.Jul 7 2023, 5:10 PM
Jdforrester-WMF moved this task from In progress to QA needed on the Abstract Wikipedia team (Phase λ – Launch) board.Jul 11 2023, 3:50 PM
DVrandecic closed this task as Resolved.Jul 12 2023, 12:58 AM
DVrandecic subscribed.

Awesome step forward!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits