Page MenuHomePhabricator
Create Task
Maniphest T335307

Deploy fixed width indicator to English Wikipedia
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Jdlrobson
Authored By
ovasileva
Apr 24 2023, 4:31 PM
Tags
Referenced Files
F36991641: Screenshot 2023-05-10 at 3.32.30 PM.png
May 10 2023, 10:44 PM
F36991644: Screenshot 2023-05-10 at 3.38.19 PM.png
May 10 2023, 10:44 PM
F36991026: Screenshot 2023-05-10 at 12.56.54.png
May 10 2023, 11:58 AM
F36989880: Screenshot 2023-05-09 at 10.22.25 AM.png
May 9 2023, 2:27 PM
Subscribers
Aklapper
Edtadros
Galobtter
Jdlrobson
ovasileva
Samwalton9-WMF

Description

Background

We would like to deploy the indicator built in T333601 to English Wikipedia to test how this indicator affects width usage

Pre-deployment criteria

  • Ensure that instrumentation for clicking the button and current state is up to date (and has not seen additional changes)
  • Ensure latest copy is discussed with the community and update based on the conversation

Copy:
Neutral state: You can toggle between a fixed width and full width by clicking this button.
If going from fixed width to full: You have switched your layout to full width. To go back to fixed width, press this button.

Acceptance criteria

Post-deployment criteria

Details

SubjectRepoBranchLines +/-
Deploy fixed width indicator to wikisoperations/mediawiki-configmaster+5 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ovasileva created this task.Apr 24 2023, 4:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 24 2023, 4:31 PM
ovasileva triaged this task as High priority.Apr 24 2023, 4:31 PM
LGoto set the point value for this task to 3.Apr 24 2023, 5:29 PM
LGoto moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.
Jdlrobson moved this task from Ready for Development to Blocked on Others on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.Apr 25 2023, 12:57 AM
Edtadros mentioned this in T333601: Inform logged-out users of their ability to select page density.Apr 27 2023, 6:13 PM
Edtadros mentioned this in T334366: Make it possible for indicator to show on page load.
Jdlrobson updated the task description. (Show Details)Apr 27 2023, 6:45 PM
Jdlrobson updated the task description. (Show Details)
ovasileva removed ovasileva as the assignee of this task.Apr 28 2023, 6:06 PM
ovasileva updated the task description. (Show Details)
ovasileva moved this task from Blocked on Others to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.
ovasileva moved this task from Web Team FY2022-23 Q4 Sprint 2 to Web Team FY2022-23 Q4 Sprint 3 on the Web-Team-Backlog board.May 1 2023, 5:24 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3); removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2).
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.May 8 2023, 2:22 PM
Jdlrobson updated the task description. (Show Details)May 8 2023, 5:23 PM
Jdlrobson claimed this task.May 8 2023, 6:31 PM
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.
ovasileva renamed this task from Deploy fixed width indicator to wikis to Deploy fixed width indicator to English Wikipedia.May 8 2023, 6:46 PM
gerritbot added a comment.May 8 2023, 6:48 PM

Change 917395 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Deploy fixed width indicator to wikis

https://gerrit.wikimedia.org/r/917395

gerritbot added a project: Patch-For-Review.May 8 2023, 6:48 PM
Jdlrobson mentioned this in T336197: Remove popup indicator on page load and associated configuration.May 8 2023, 6:56 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.May 8 2023, 8:26 PM

Change 917395 merged by jenkins-bot:

[operations/mediawiki-config@master] Deploy fixed width indicator to wikis

https://gerrit.wikimedia.org/r/917395

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.May 8 2023, 8:27 PM
Maintenance_bot removed a project: Patch-For-Review.May 8 2023, 8:30 PM
Stashbot added a comment.May 8 2023, 8:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-08T20:30:31Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:917395|Deploy fixed width indicator to wikis (T335307)]]

Stashbot added a comment.May 8 2023, 8:31 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-08T20:31:54Z] <taavi@deploy1002> jdlrobson and taavi: Backport for [[gerrit:917395|Deploy fixed width indicator to wikis (T335307)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.May 8 2023, 8:38 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-08T20:38:54Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:917395|Deploy fixed width indicator to wikis (T335307)]] (duration: 08m 22s)

Jdlrobson reassigned this task from Jdlrobson to Edtadros.May 8 2023, 8:52 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.
Jdlrobson subscribed.

@ovasileva this is now deployed. QA should be done in production.

Jdlrobson updated the task description. (Show Details)May 8 2023, 9:36 PM
Jdlrobson updated the task description. (Show Details)
ovasileva moved this task from QA to Needs More Work on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.May 9 2023, 2:27 PM

Seems there's now an issue with the indicator appearing:

Screenshot 2023-05-09 at 10.22.25 AM.png (268×706 px, 29 KB)

ovasileva moved this task from Needs More Work to QA on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.May 9 2023, 3:21 PM
Samwalton9-WMF subscribed.May 10 2023, 11:58 AM

When the editor help panel is enabled (Preferences > User profile > Enabled the editor help panel), the toggle and popup close button are pushed off the screen.

Screenshot 2023-05-10 at 12.56.54.png (322×702 px, 35 KB)

Jdlrobson added a comment.May 10 2023, 6:29 PM

@Samwalton9 : https://phabricator.wikimedia.org/T336431

Edtadros removed Edtadros as the assignee of this task.May 10 2023, 10:44 PM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Neutral state: You can toggle between a fixed width and full width by clicking this button.

Screenshot 2023-05-10 at 3.38.19 PM.png (897×1 px, 295 KB)

✅ AC2: If going from fixed width to full: You have switched your layout to full width. To go back to fixed width, press this button.

Screenshot 2023-05-10 at 3.32.30 PM.png (548×1 px, 130 KB)

Jdlrobson claimed this task.May 11 2023, 4:39 PM
Galobtter subscribed.May 12 2023, 2:55 AM

See this thread: this popup keeps nagging people even for just opening a new tab.

Jdlrobson closed this task as Resolved.May 16 2023, 4:32 PM

Will be removed in T336197

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits