Page MenuHomePhabricator

Make it possible for indicator to show on page load
Closed, ResolvedPublic5 Estimated Story Points

Description

This is an accompanying task of:
https://phabricator.wikimedia.org/T333601

Solution 1:

  • Copy needed CSS/Js of the component over from ooui.
  • Server side rendering of a drop in replacement for OOUI popup
  • Using toggle of show/hide (display: none/default) with mw.msg() for the message key to replace inner text

Solution 2:

  • Load OOUI after pageload (nonblocking)
  • once it is loaded we create and show the appropriate messages

QA Results - Beta

ACStatusDetails
1T334366#8797988

QA Results - Prod

ACStatusDetails
1T334366#8811599

Details

Other Assignee
bwang

Event Timeline

Mabualruz renamed this task from Performance tweaks for on page load ooui library to Performance tweaks for on page load OOUI library.Apr 10 2023, 4:32 AM
Jdlrobson renamed this task from Performance tweaks for on page load OOUI library to Make it possible for indicator to show on page load.Apr 10 2023, 5:17 PM
LGoto set the point value for this task to 5.Apr 10 2023, 5:25 PM
Jdlrobson updated Other Assignee, added: bwang; removed: Jdlrobson.
Jdlrobson added a subscriber: bwang.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: This is validated in T333601#8794746

Edtadros removed ovasileva as the assignee of this task.
Edtadros added a subscriber: ovasileva.

Test Result - Prod

Status: ⬜ not tested
Environment: na
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Prod deployment will be tested in T335307