Revision Slider does not resize appropriately when moving main and tools menu to and from sidebar
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	May 16 2023, 8:07 AM

Description

What is the problem?

Vector 2022 allows a user to move the main menu and the tools menu to and from the sidebar. If you do this with the Revisions Slider open, the Slider does not resize.

The effect can be quite dramatic as seen in the screenshots below.

Steps to reproduce problem

https://en.wikipedia.org/w/index.php?diff=1155038775&oldid=1155038566&title=Paint_It_Black
If the main menu and tools menu are not already hidden, click the "Hide" button (as highlighted in this screenshot)
Open the revision slider (click "Browse history interactively")
Move the main menu and tools menu back to the sidebar (click "Move to sidebar" as highlighted in the screenshots)

Expected behavior: Revision Slider should be appropriately resized
Observed behavior: Revision Slider overlaps the tools menu

Similarly, if the main and tool menus are in the sidebar when you open the Revision Slider, if you hide the menus the Slider does not increase its width to match the contents.

Environment

Browser: Firefox 102, Chromium 112.
Wiki(s): https://en.wikipedia.org RevisionSlider – (50fe9c4) 10:49, 5 May 2023. Vector 1.0.0 (03570d4) 23:00, 8 May 2023.

Screenshots

revisions_slider_overlaps.png (832×1 px, 166 KB)

revisions_slider_overlaps_enwiki.png (850×1 px, 167 KB)

revisions_slider_narrow_enwiki.png (839×1 px, 125 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Trigger window.resize when toggeling pinnableElement	mediawiki/skins/Vector	master	+1 -0
	Add `overflow-x: clip` to minimize impact of resize issues	mediawiki/extensions/RevisionSlider	master	+3 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open	BUG REPORT	None	T352195 RevisionSlider does not resize when pinning the Vector 2022 TOC to the sidebar
		Resolved	BUG REPORT	Tobi_WMDE_SW	T336729 Revision Slider does not resize appropriately when moving main and tools menu to and from sidebar

Event Timeline

dom_walden created this task.May 16 2023, 8:07 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 16 2023, 8:07 AM

dom_walden updated the task description. (Show Details)May 16 2023, 8:58 AM

Jdlrobson removed a project: Desktop Improvements (Vector 2022).Jun 9 2023, 12:10 AM

thiemowmde added projects: Desktop Improvements (Vector 2022), Regression, WMDE-TechWish-Maintenance, WMDE-TechWish-Maintenance-2023.Jun 12 2023, 7:16 AM

thiemowmde added subscribers: Lena_WMDE, thiemowmde, WMDE-Fisch.

Jdlrobson moved this task from Incoming to Tracking (Waiting on other teams) on the Desktop Improvements (Vector 2022) board.Jun 12 2023, 5:59 PM

lilients_WMDE moved this task from Incoming to Maintenance on the Revision-Slider board.Jun 13 2023, 2:24 PM

thiemowmde mentioned this in T338318: Evaluate & improve accessibility of TechWish products.Jun 15 2023, 9:14 AM

Change 930553 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/RevisionSlider@master] Add `overflow-x: clip` to minimize impact of resize issues

https://gerrit.wikimedia.org/r/930553

gerritbot added a project: Patch-For-Review.Jun 15 2023, 10:16 AM

Change 930553 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Add `overflow-x: clip` to minimize impact of resize issues

https://gerrit.wikimedia.org/r/930553

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 15 2023, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 15 2023, 4:10 PM

Looks to me like this is already fixed on beta. I guess it will just take a few more days until it is live.

lilients_WMDE moved this task from Backlog to Watching / Epic on the WMDE-TechWish-Maintenance-2023 board.Jun 28 2023, 1:56 PM

Nice. Looks like this patch fixed it: https://gerrit.wikimedia.org/r/884289. Tracked via T328121. Not a duplicate, though. Let's close this when we verified it. It might be possible to do this locally, or just wait for the update on production.

In T336729#8975894, @thiemowmde wrote:

Nice. Looks like this patch fixed it: https://gerrit.wikimedia.org/r/884289. Tracked via T328121. Not a duplicate, though. Let's close this when we verified it. It might be possible to do this locally, or just wait for the update on production.

The train went through and I don't see the issue fully fixed when I follow the example give in the description. :-/

Oh, I see. We are talking about two slightly different click-paths here. https://gerrit.wikimedia.org/r/884289 was about the full-width button at the very bottom of the skin. This triggers a resize event and works fine. But the same issue still exists when pinning one of the menus to the side. This also changes the width of the page but doesn't trigger a resize event.

Moving back.

thiemowmde moved this task from Watching or blocked to Priority backlog on the WMDE-TechWish-Maintenance board.Jun 30 2023, 11:13 AM

WMDE-Fisch claimed this task.Oct 18 2023, 11:04 AM

WMDE-Fisch moved this task from Backlog to Doing on the WMDE-TechWish-Maintenance-2023 board.

Change 966852 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/skins/Vector@master] Trigger window.resize when toggeling pinnableElement

https://gerrit.wikimedia.org/r/966852

gerritbot added a project: Patch-For-Review.Oct 18 2023, 11:12 AM

WMDE-Fisch moved this task from Doing to Review on the WMDE-TechWish-Maintenance-2023 board.Oct 18 2023, 11:13 AM

thiemowmde moved this task from Priority backlog to In progress on the WMDE-TechWish-Maintenance board.Oct 20 2023, 9:03 AM

Change 966852 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Trigger window.resize when toggeling pinnableElement

https://gerrit.wikimedia.org/r/966852

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.3; 2023-10-31).Oct 26 2023, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 26 2023, 5:10 PM

WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Oct 27 2023, 1:49 PM

WMDE-Fisch moved this task from Review to Done on the WMDE-TechWish-Maintenance-2023 board.

Tobi_WMDE_SW closed this task as Resolved.Nov 21 2023, 9:11 AM

Tobi_WMDE_SW claimed this task.

thiemowmde mentioned this in T352195: RevisionSlider does not resize when pinning the Vector 2022 TOC to the sidebar.Nov 28 2023, 5:11 PM

thiemowmde added a parent task: T352195: RevisionSlider does not resize when pinning the Vector 2022 TOC to the sidebar.

	F37000582: revisions_slider_narrow_enwiki.png
	May 16 2023, 8:07 AM

	F37000579: revisions_slider_overlaps_enwiki.png
	May 16 2023, 8:07 AM

	F37000574: revisions_slider_overlaps.png
	May 16 2023, 8:07 AM

	F37000586: main_tools_menu_enwiki_highlighted.png
	May 16 2023, 8:07 AM

Revision Slider does not resize appropriately when moving main and tools menu to and from sidebarClosed, ResolvedPublicBUG REPORTActions