[IMPLEMENTATION] Front end: (no js), Allow participants to edit their answers on RegisterForEvent/{eventID}
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	cmelo
	May 17 2023, 12:16 PM

Description

Acceptance criteria

Scenario: Participants wants to change their answers

Given a Participant goes to the event registration page
And the Participant is already registered
Then the participant will be able to see all event questions and the answers the participant provided when registering
And the participant should be able to edit the answers by updating them and clicking on "Edit Registration"

Design

https://www.figma.com/file/lJUO73TtMpoyn30zm1qFq7/Campaigns-registration-V2?type=design&node-id=632%3A31380&t=ex0RfBSGy4qirzoT-1

External dependencies

Other dependencies

T319454
T335808
Backend

OBS: We may want to change the name of the special page now that is not only Registering the participant, but this should be done in another patch

Details

	Subject	Repo	Branch	Lines +/-
	SpecialRegisterForEvent: Make it possible to edit answers	mediawiki/extensions/CampaignEvents	master	+30 -37

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Daimona	T341392 Mark the CampaignEvents extension as stable
Resolved	cmelo	T321822 [EPIC] Participant Questions - MVP
Resolved	Daimona	T336852 [IMPLEMENTATION] Front end: (no js), Allow participants to edit their answers on RegisterForEvent/{eventID}
Resolved	Daimona	T319454 Participant can switch between public/private registration
Resolved	cmelo	T335808 [IMPLEMENTATION] Front end: (no JS ), add the questions on Special:RegisterForEvent/{id}

Event Timeline

cmelo created this task.May 17 2023, 12:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 17 2023, 12:16 PM

cmelo updated the task description. (Show Details)May 17 2023, 12:17 PM

cmelo renamed this task from [IMPLEMENTATION] Front end: (no js), change CancelEventRegistration special page to add Event Questions there so participants can edit it to [IMPLEMENTATION] Front end: (no js), Allow participants to edit their event registration on RegisterForEvent/{eventID}.May 19 2023, 7:22 PM

cmelo renamed this task from [IMPLEMENTATION] Front end: (no js), Allow participants to edit their event registration on RegisterForEvent/{eventID} to [IMPLEMENTATION] Front end: (no js), Allow participants to edit their answers on RegisterForEvent/{eventID}.

cmelo updated the task description. (Show Details)

cmelo updated the task description. (Show Details)May 19 2023, 7:25 PM

MHorsey-WMF updated the task description. (Show Details)Jun 15 2023, 1:39 PM

MHorsey-WMF updated the task description. (Show Details)Jun 15 2023, 1:49 PM

MHorsey-WMF set the point value for this task to 3.

MHorsey-WMF moved this task from Backlog to Estimated/Ready for work on the Campaign-Tools board.Jun 15 2023, 2:00 PM

MHorsey-WMF moved this task from Estimated/Ready for work to Campaign-Tools-Current-Sprint on the Campaign-Tools board.Jun 15 2023, 2:15 PM

MHorsey-WMF edited projects, added Campaign-Tools (Campaign-Tools-Current-Sprint); removed Campaign-Tools.

MHorsey-WMF moved this task from Needs Input / Design in progress to Ready for development on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jun 15 2023, 2:18 PM

Daimona added a subtask: T319454: Participant can switch between public/private registration.Jun 15 2023, 2:20 PM

MHorsey-WMF updated the task description. (Show Details)Jun 15 2023, 2:25 PM

Daimona added a subtask: T335808: [IMPLEMENTATION] Front end: (no JS ), add the questions on Special:RegisterForEvent/{id}.Jun 15 2023, 2:29 PM

Daimona mentioned this in T339259: form backend for participant questions.Jun 23 2023, 5:56 PM

Daimona claimed this task.Jun 27 2023, 4:14 PM

Daimona moved this task from Ready for development to In Progress 💻 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.

Change 933505 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] SpecialRegisterForEvent: Make it possible to edit answers

https://gerrit.wikimedia.org/r/933505

gerritbot added a project: Patch-For-Review.Jun 27 2023, 4:39 PM

Daimona moved this task from In Progress 💻 to Code Review on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jun 27 2023, 4:41 PM

Change 933505 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] SpecialRegisterForEvent: Make it possible to edit answers

https://gerrit.wikimedia.org/r/933505

Maintenance_bot removed a project: Patch-For-Review.Jun 30 2023, 8:11 PM

Daimona moved this task from Code Review to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jun 30 2023, 8:45 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jun 30 2023, 9:00 PM

✅ Then the participant will be able to see all event questions and the answers the participant provided when registering
✅ And the participant should be able to edit the answers by updating them and clicking on "Edit Registration"

@Daimona, I think this data in the affiliate free text field should be deleted on save of another option.
To reproduce:
Select affiliate, type something in the text field, save
Select another answer that removes the free text field (Chapter, User group, etc), save
Select affiliate again, the former answer is still in the free text field. I think that data should be erased on save like any other non selected data would be erased on save. Thoughts?

Screen Recording 2023-07-03 at 1.21.31 PM.gif (1×2 px, 2 MB)

(Note though that it does correctly delete that field when canceling registration and then re-registering)

In T336852#8986448, @vaughnwalters wrote:

@Daimona, I think this data in the affiliate free text field should be deleted on save of another option.
To reproduce:
Select affiliate, type something in the text field, save
Select another answer that removes the free text field (Chapter, User group, etc), save
Select affiliate again, the former answer is still in the free text field. I think that data should be erased on save like any other non selected data would be erased on save. Thoughts?

The data is actually removed from the DB, but it remains in the form until you close/refresh the page. This seems to be a builtin behaviour in MW core, and I'm not sure how to fix that, but maybe it could be considered a feature?

In T336852#8988374, @Daimona wrote:

In T336852#8986448, @vaughnwalters wrote:

@Daimona, I think this data in the affiliate free text field should be deleted on save of another option.
To reproduce:
Select affiliate, type something in the text field, save
Select another answer that removes the free text field (Chapter, User group, etc), save
Select affiliate again, the former answer is still in the free text field. I think that data should be erased on save like any other non selected data would be erased on save. Thoughts?

The data is actually removed from the DB, but it remains in the form until you close/refresh the page. This seems to be a builtin behaviour in MW core, and I'm not sure how to fix that, but maybe it could be considered a feature?

Ah yes, as long as it is removed from the DB then this is a feature! AC is met, moving to product sign off.

This looks good, as shown in QA notes. I'm marking this as Done.

ifried closed subtask T319454: Participant can switch between public/private registration as Resolved.Jul 21 2023, 5:59 PM

ifried closed subtask T335808: [IMPLEMENTATION] Front end: (no JS ), add the questions on Special:RegisterForEvent/{id} as Resolved.Sep 22 2023, 4:40 PM

	F37127177: Screen Recording 2023-07-03 at 1.21.31 PM.gif
	Jul 3 2023, 6:28 PM

[IMPLEMENTATION] Front end: (no js), Allow participants to edit their answers on RegisterForEvent/{eventID}Closed, ResolvedPublic3 Estimated Story PointsActions