Page MenuHomePhabricator
Create Task
Maniphest T337366

Tabs on the "Contribute" page not showing for some skins
Closed, ResolvedPublic
Actions

Assigned To
Pginer-WMF
Authored By
Pginer-WMF
May 24 2023, 8:01 AM
Tags
Referenced Files
F37030935: Artboard.png
May 24 2023, 8:40 AM
F37030901: bn.wikipedia.org_wiki_%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7_Contribute(iPad Air).png
May 24 2023, 8:01 AM
F37030899: bn.wikipedia.org_wiki_%E0%A6%AA%E0%A7%8D%E0%A6%B0%E0%A6%A7%E0%A6%BE%E0%A6%A8_%E0%A6%AA%E0%A6%BE%E0%A6%A4%E0%A6%BE(iPad Air).png
May 24 2023, 8:01 AM
Subscribers
Aklapper
• Elitre
Jdlrobson
KartikMistry
NBaca-WMF
Pginer-WMF

Description

The Contribute entry point (T322740) allows users to start new contributions while providing access to the list of previous contributions they made.
While this works as described for the new "Vector 2022" skin, that is not the case for other skins such as "Vector Legacy" or "Monobook". For those skins, the "Contribute" option is shown in the user menu and it leads to the Contribute page. However, the Contribute page is missing the tabs that allow users to to switch to the Contributions page.

This ticket proposes to make sure the tabs are visible on the Contribute and Contributions page regardless of the skin used.

For example, on Bengali Wikipedia using Vector legacy, users in the main page have the "Contribute" option which leads to the Contribute page which is lacking the tabs to access the Contributions page with the list of their contributions. This represents a regression for users where they can no longer access their list of contributions. The expected behaviour s for the page to include the tabs. This example is illustrated below.

Main page using Vector Legacy with "Contribute" option in the user toolbar on topContribute page without tabs to switch to view user contributionsExpected result: Contribute page should have tabs to access the "view contributions" option
bn.wikipedia.org_wiki_%E0%A6%AA%E0%A7%8D%E0%A6%B0%E0%A6%A7%E0%A6%BE%E0%A6%A8_%E0%A6%AA%E0%A6%BE%E0%A6%A4%E0%A6%BE(iPad Air).png (1×2 px, 1 MB)
bn.wikipedia.org_wiki_%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7_Contribute(iPad Air).png (1×2 px, 384 KB)
Artboard.png (1×2 px, 344 KB)

Details

SubjectRepoBranchLines +/-
Undeploy Special:Contribute from unsupported skinsoperations/mediawiki-configmaster+6 -6
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT322740 Contribute entry point
 ResolvedPginer-WMFT337366 Tabs on the "Contribute" page not showing for some skins

Event Timeline

Pginer-WMF created this task.May 24 2023, 8:01 AM
Pginer-WMF mentioned this in T336839: Inform initial communities about the Contribute entry point.May 24 2023, 8:08 AM
Pginer-WMF mentioned this in T322740: Contribute entry point.May 24 2023, 8:16 AM
Pginer-WMF renamed this task from Keep the link to "Contributions" for skins where the Contribute entry point is not enabled to Tabs on the "Contribute" page not showing for some skins.May 24 2023, 8:40 AM
Pginer-WMF updated the task description. (Show Details)
Pginer-WMF added a subscriber: NBaca-WMF.May 24 2023, 8:58 AM
Jdlrobson added a comment.May 25 2023, 2:46 PM

This is currently working as expected. The tabs are only supported in modern skins.

We can add to Vector legacy and/or Monobook but that may have some undesired side effects on other special pages that make use of the feature e.g. SpecialWatchlist so I'd recommend carefully reviewing exactly what you'd be enabling.

• Elitre subscribed.May 25 2023, 5:20 PM

"As expected" would be that I get the list of my contributions. There's no other button for that.

Jdlrobson added a subscriber: KartikMistry.EditedMay 25 2023, 7:01 PM
In T337366#8880823, @Elitre wrote:

"As expected" would be that I get the list of my contributions. There's no other button for that.

Let me rephrase this :-)

My understanding from the original story was that Special:Contribute was a feature only for the Minerva skin (and that later evolved to include Vector 2022). The Special:Contribute page should not be accessible directly from the UI from other skins.

The configuration in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/921049/3/wmf-config/InitialiseSettings.php#8286 looks wrong to me as it enables it on Monobook and Vector which was never discussed and was not something we promised initially. I suggest the configuration is updated to be limited to vector-2022 and minerva for now. cc @KartikMistry

If we need to support Monobook and Vector, this is substantial work and we should revisit this project as it sounds like potentially some wires have got crossed. The Web team typical don't add new features for skins that are not in active development.

KartikMistry added a comment.May 26 2023, 8:19 AM
In T337366#8881341, @Jdlrobson wrote:
In T337366#8880823, @Elitre wrote:

"As expected" would be that I get the list of my contributions. There's no other button for that.

Let me rephrase this :-)

My understanding from the original story was that Special:Contribute was a feature only for the Minerva skin (and that later evolved to include Vector 2022). The Special:Contribute page should not be accessible directly from the UI from other skins.

The configuration in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/921049/3/wmf-config/InitialiseSettings.php#8286 looks wrong to me as it enables it on Monobook and Vector which was never discussed and was not something we promised initially. I suggest the configuration is updated to be limited to vector-2022 and minerva for now. cc @KartikMistry

If we need to support Monobook and Vector, this is substantial work and we should revisit this project as it sounds like potentially some wires have got crossed. The Web team typical don't add new features for skins that are not in active development.

Thanks for the update and context. I'll submit a fix for undeploying entrypoint from unsupported skins.

gerritbot added a comment.May 26 2023, 8:20 AM

Change 923527 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/mediawiki-config@master] Undeploy Special:Contribute from unsupported skins

https://gerrit.wikimedia.org/r/923527

gerritbot added a project: Patch-For-Review.May 26 2023, 8:20 AM
KartikMistry moved this task from Quarter Backlog to In Review on the Language-Team (Language-2023-April-June) board.May 26 2023, 8:20 AM
gerritbot added a comment.May 30 2023, 7:04 AM

Change 923527 merged by jenkins-bot:

[operations/mediawiki-config@master] Undeploy Special:Contribute from unsupported skins

https://gerrit.wikimedia.org/r/923527

Stashbot added a comment.May 30 2023, 7:04 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-30T07:04:48Z] <kartik@deploy1002> Started scap: Backport for [[gerrit:923527|Undeploy Special:Contribute from unsupported skins (T337366)]]

Stashbot added a comment.May 30 2023, 7:06 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-30T07:06:26Z] <kartik@deploy1002> kartik: Backport for [[gerrit:923527|Undeploy Special:Contribute from unsupported skins (T337366)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Maintenance_bot removed a project: Patch-For-Review.May 30 2023, 7:10 AM
Stashbot added a comment.May 30 2023, 7:16 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-30T07:16:37Z] <kartik@deploy1002> Finished scap: Backport for [[gerrit:923527|Undeploy Special:Contribute from unsupported skins (T337366)]] (duration: 11m 49s)

KartikMistry added a comment.May 30 2023, 7:17 AM
In T337366#8882216, @KartikMistry wrote:
In T337366#8881341, @Jdlrobson wrote:
In T337366#8880823, @Elitre wrote:

"As expected" would be that I get the list of my contributions. There's no other button for that.

Let me rephrase this :-)

My understanding from the original story was that Special:Contribute was a feature only for the Minerva skin (and that later evolved to include Vector 2022). The Special:Contribute page should not be accessible directly from the UI from other skins.

The configuration in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/921049/3/wmf-config/InitialiseSettings.php#8286 looks wrong to me as it enables it on Monobook and Vector which was never discussed and was not something we promised initially. I suggest the configuration is updated to be limited to vector-2022 and minerva for now. cc @KartikMistry

If we need to support Monobook and Vector, this is substantial work and we should revisit this project as it sounds like potentially some wires have got crossed. The Web team typical don't add new features for skins that are not in active development.

Thanks for the update and context. I'll submit a fix for undeploying entrypoint from unsupported skins.

This is done.

Jdlrobson added a comment.Jun 8 2023, 2:37 PM

Can this ticket be resolved? If not, what needs to happen?

Pginer-WMF closed this task as Resolved.Jun 13 2023, 2:59 PM
Pginer-WMF claimed this task.
In T337366#8914297, @Jdlrobson wrote:

Can this ticket be resolved? If not, what needs to happen?

Yes. If we consider that the Contribute entry point has to be exposed in other skins, a separate ticket can be created.

Nikerabbit moved this task from In Review to Done on the Language-Team (Language-2023-April-June) board.Jun 22 2023, 9:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL