Page MenuHomePhabricator

Special:Log mis-parses target with tab in it
Closed, ResolvedPublicBUG REPORT

Description

Go to https://en.wikipedia.org/wiki/Special:Log?type=renameuser&user=&page=User%3A%09Foo&wpdate=&tagfilter=&wpFormIdentifier=logeventslist

What happens?:
You get log entries for all renames

What should have happened instead?:
It should ignore the extraneous whitespace after the ":"

Event Timeline

A tab character when URL encoded gives %09 and when used as part of a page name/title, it's normalized to a bad title from my tests with User:%09Foobar etc. Maybe we should validate the input and error that the username is invalid rather than try to normalize to a name that doesn't match the input?

I think the output you're getting now isn't supposed to even work that way since that would normalize to a bad title instead of showing the list of all renames.

@daniel / @Krinkle, what do you think should be a proper behavior here? Are we accepting %09 as part of a page name?

Seems that the invalid title is not reported correctly to the form and internally using no title which results in showing the whole result (T338042)

The title is invalid in mediawiki: https://en.wikipedia.org/wiki/User%3A%09Foo

matmarex assigned this task to Func.
matmarex subscribed.

Resolved by the fix for the subtask (there's an error message now).